ChallengeThe code review bug that gives me nightmares

time to read 1 min | 148 words

I was writing a fairly low level piece of code recently, this is deep in the guts of how RavenDB handles query. I’m adding a cache for some processing inside of RavenDB and the performance benefits are amazing (three orders of magnitude better). As you can imagine, this is the sort of things that I would really like to get into the main codebase. So I did all the usual taxes, created a pull request and moved to other things. Part of our process is to review all pull requests by another pair of eyes. And while there was some minor comments about the code, there was one comment asking about a particular line that had be break out in cold sweat.

I created a simpler reproduction for discussion purposes, here is the code:

Take a look, and let’s me know if you see the bug and its consequences.

More posts in "Challenge" series:

  1. (16 Dec 2021) Find the slow down–answer
  2. (15 Dec 2021) Find the slow down
  3. (03 Nov 2021) The code review bug that gives me nightmares–The fix
  4. (02 Nov 2021) The code review bug that gives me nightmares–the issue
  5. (01 Nov 2021) The code review bug that gives me nightmares
  6. (16 Jun 2021) Detecting livelihood in a distributed cluster
  7. (21 Apr 2020) Generate matching shard id–answer
  8. (20 Apr 2020) Generate matching shard id
  9. (02 Jan 2020) Spot the bug in the stream
  10. (28 Sep 2018) The loop that leaks–Answer
  11. (27 Sep 2018) The loop that leaks
  12. (03 Apr 2018) The invisible concurrency bug–Answer
  13. (02 Apr 2018) The invisible concurrency bug
  14. (31 Jan 2018) Find the bug in the fix–answer
  15. (30 Jan 2018) Find the bug in the fix
  16. (19 Jan 2017) What does this code do?
  17. (26 Jul 2016) The race condition in the TCP stack, answer
  18. (25 Jul 2016) The race condition in the TCP stack
  19. (28 Apr 2015) What is the meaning of this change?
  20. (26 Sep 2013) Spot the bug
  21. (27 May 2013) The problem of locking down tasks…
  22. (17 Oct 2011) Minimum number of round trips
  23. (23 Aug 2011) Recent Comments with Future Posts
  24. (02 Aug 2011) Modifying execution approaches
  25. (29 Apr 2011) Stop the leaks
  26. (23 Dec 2010) This code should never hit production
  27. (17 Dec 2010) Your own ThreadLocal
  28. (03 Dec 2010) Querying relative information with RavenDB
  29. (29 Jun 2010) Find the bug
  30. (23 Jun 2010) Dynamically dynamic
  31. (28 Apr 2010) What killed the application?
  32. (19 Mar 2010) What does this code do?
  33. (04 Mar 2010) Robust enumeration over external code
  34. (16 Feb 2010) Premature optimization, and all of that…
  35. (12 Feb 2010) Efficient querying
  36. (10 Feb 2010) Find the resource leak
  37. (21 Oct 2009) Can you spot the bug?
  38. (18 Oct 2009) Why is this wrong?
  39. (17 Oct 2009) Write the check in comment
  40. (15 Sep 2009) NH Prof Exporting Reports
  41. (02 Sep 2009) The lazy loaded inheritance many to one association OR/M conundrum
  42. (01 Sep 2009) Why isn’t select broken?
  43. (06 Aug 2009) Find the bug fixes
  44. (26 May 2009) Find the bug
  45. (14 May 2009) multi threaded test failure
  46. (11 May 2009) The regex that doesn’t match
  47. (24 Mar 2009) probability based selection
  48. (13 Mar 2009) C# Rewriting
  49. (18 Feb 2009) write a self extracting program
  50. (04 Sep 2008) Don't stop with the first DSL abstraction
  51. (02 Aug 2008) What is the problem?
  52. (28 Jul 2008) What does this code do?
  53. (26 Jul 2008) Find the bug fix
  54. (05 Jul 2008) Find the deadlock
  55. (03 Jul 2008) Find the bug
  56. (02 Jul 2008) What is wrong with this code
  57. (05 Jun 2008) why did the tests fail?
  58. (27 May 2008) Striving for better syntax
  59. (13 Apr 2008) calling generics without the generic type
  60. (12 Apr 2008) The directory tree
  61. (24 Mar 2008) Find the version
  62. (21 Jan 2008) Strongly typing weakly typed code
  63. (28 Jun 2007) Windsor Null Object Dependency Facility