ChallengeThe directory tree
Since people seems to really enjoy posts like this, here is another one. This time it is an interesting issue that I dealt with today.
Given a set of versioned file, you need to cache them locally. Note that IPersistentCache semantics means that if you put a value in it, is is always going to remain there.
Here is the skeleton:
public interface IPersistentCache { void Set(string key, params string[] items); string[] Get(string key); } public enum Recursion { None, OneLevel, Full } public class VersionedFile { public int Version; public string Name; } public class FileSystemCache : IFileSystemCache { IPersistentCache cache; public FileSystemCache(IPersistentCache cahce) { this.cache = cache; } public void Add(VersionedFile[] files) { // to do } public string[] ListFilesAndFolders(string root, int version, Recursion recursion) { // to do } }
How would you implement this? Note that your only allowed external dependency is the ICache interface.
The usage is something like this:
// given var fsc = new FileSystemCache(cache); fsc.Add(new [] { new VersionFile{Version = 1, Name = "/"}, new VersionFile{Version = 1, Name = "/foo"}, new VersionFile{Version = 1, Name = "/foo/bar"}, new VersionFile{Version = 1, Name = "/foo/bar/text.txt"}, }); fsc.Add(new [] { new VersionFile{Version = 2, Name = "/"}, new VersionFile{Version = 2, Name = "/foo"}, new VersionFile{Version = 2, Name = "/foo/bar"}, new VersionFile{Version = 2, Name = "/foo/bar/text.txt"}, new VersionFile{Version = 2, Name = "/test.txt"}, }); // then fsc.ListFilesAndFolders("/", 1, Recursion.None) == { "/" } fsc.ListFilesAndFolders("/", 1, Recursion.OneLevel) == { "/", "/foo", } fsc.ListFilesAndFolders("/", 2, Recursion.OneLevel) == { "/", "/foo", "test.txt" } fsc.ListFilesAndFolders("/", 1, Recursion.Full) == { "/", "/foo", "/foo/bar", "/foo/bar/text.txt"}
You can assume that all paths are '/' separated and they always starts with '/'.
More posts in "Challenge" series:
- (01 Jul 2024) Efficient snapshotable state
- (13 Oct 2023) Fastest node selection metastable error state–answer
- (12 Oct 2023) Fastest node selection metastable error state
- (19 Sep 2023) Spot the bug
- (04 Jan 2023) what does this code print?
- (14 Dec 2022) What does this code print?
- (01 Jul 2022) Find the stack smash bug… – answer
- (30 Jun 2022) Find the stack smash bug…
- (03 Jun 2022) Spot the data corruption
- (06 May 2022) Spot the optimization–solution
- (05 May 2022) Spot the optimization
- (06 Apr 2022) Why is this code broken?
- (16 Dec 2021) Find the slow down–answer
- (15 Dec 2021) Find the slow down
- (03 Nov 2021) The code review bug that gives me nightmares–The fix
- (02 Nov 2021) The code review bug that gives me nightmares–the issue
- (01 Nov 2021) The code review bug that gives me nightmares
- (16 Jun 2021) Detecting livelihood in a distributed cluster
- (21 Apr 2020) Generate matching shard id–answer
- (20 Apr 2020) Generate matching shard id
- (02 Jan 2020) Spot the bug in the stream
- (28 Sep 2018) The loop that leaks–Answer
- (27 Sep 2018) The loop that leaks
- (03 Apr 2018) The invisible concurrency bug–Answer
- (02 Apr 2018) The invisible concurrency bug
- (31 Jan 2018) Find the bug in the fix–answer
- (30 Jan 2018) Find the bug in the fix
- (19 Jan 2017) What does this code do?
- (26 Jul 2016) The race condition in the TCP stack, answer
- (25 Jul 2016) The race condition in the TCP stack
- (28 Apr 2015) What is the meaning of this change?
- (26 Sep 2013) Spot the bug
- (27 May 2013) The problem of locking down tasks…
- (17 Oct 2011) Minimum number of round trips
- (23 Aug 2011) Recent Comments with Future Posts
- (02 Aug 2011) Modifying execution approaches
- (29 Apr 2011) Stop the leaks
- (23 Dec 2010) This code should never hit production
- (17 Dec 2010) Your own ThreadLocal
- (03 Dec 2010) Querying relative information with RavenDB
- (29 Jun 2010) Find the bug
- (23 Jun 2010) Dynamically dynamic
- (28 Apr 2010) What killed the application?
- (19 Mar 2010) What does this code do?
- (04 Mar 2010) Robust enumeration over external code
- (16 Feb 2010) Premature optimization, and all of that…
- (12 Feb 2010) Efficient querying
- (10 Feb 2010) Find the resource leak
- (21 Oct 2009) Can you spot the bug?
- (18 Oct 2009) Why is this wrong?
- (17 Oct 2009) Write the check in comment
- (15 Sep 2009) NH Prof Exporting Reports
- (02 Sep 2009) The lazy loaded inheritance many to one association OR/M conundrum
- (01 Sep 2009) Why isn’t select broken?
- (06 Aug 2009) Find the bug fixes
- (26 May 2009) Find the bug
- (14 May 2009) multi threaded test failure
- (11 May 2009) The regex that doesn’t match
- (24 Mar 2009) probability based selection
- (13 Mar 2009) C# Rewriting
- (18 Feb 2009) write a self extracting program
- (04 Sep 2008) Don't stop with the first DSL abstraction
- (02 Aug 2008) What is the problem?
- (28 Jul 2008) What does this code do?
- (26 Jul 2008) Find the bug fix
- (05 Jul 2008) Find the deadlock
- (03 Jul 2008) Find the bug
- (02 Jul 2008) What is wrong with this code
- (05 Jun 2008) why did the tests fail?
- (27 May 2008) Striving for better syntax
- (13 Apr 2008) calling generics without the generic type
- (12 Apr 2008) The directory tree
- (24 Mar 2008) Find the version
- (21 Jan 2008) Strongly typing weakly typed code
- (28 Jun 2007) Windsor Null Object Dependency Facility
Comments
So there is no way I can override a value in IPersistentCache? e.g. I can't do:
cache.Set("a", "test");
cache.Set("a", "nother test");
Without this limitation it should be easier. I use the path to the directory or file to be cached as a key in IPersistentCache and put the path + version to the file as a single item in its value arrays (with some separator like ":"). Then I add the item to the parent directory's item array (again path + version).
Of course adding this item means getting the complete array, building another array and setting this as the new value, which is far from ideal, but you could propably make this more performant by growing the array in larger sizes and setting items in the returned instance directly (if Get doesn't return a clone, but the actual instance of the array).
Another issue with this solution is that you have to enumerate through all versions of files in a directory even if you don't need them.
Other than that the lookup is simply done by getting the values for the path specified in ListFilesAndFolders enumerating them and depending on the recursion mode make further lookups for subdirectories.
Without the possibility to override a value in the cache, you could still simulate something like this with some sort of convention. For example, the first 2 entries are stored in key "PATHNAME", the next 4 are stored in "PATHNAME:2", the next 8 in "PATHNAME:3" ...
But Of course this requires further lookups and is ugly as hell...
Interesting challenge however, I'm excited to see your solution.
Thomas,
Each key have a single unique value.
You can do:
cache.Set("a", "test");
cache.Set("a", "nother test");
and then cache.Get("a") would return "another test".
You are in the right path.
what's your target perf for Add / List? O(?)
O(1), I init the list with the 101 capacity, so it should do no memory alloc
I know this does not meet all of your requirements, but to help ease my easily-confused brain, here is a rough draft, unit tested based upon your usage data. Note that when you say "no external dependencies" I assume that means no list processing, and my array experience is weak at best.
public class FileSystemCache : IFileSystemCache
I have posted a solution at my website, <a href="http://sharpbites.blogspot.com/2008/04/ayendes-challenge-2-directory-tree.html>here . :)
Comment preview