Talk directly to the TFS cube instead?

public int GetVersionForDate(DateTime date)

{

return sourceControl.QueryLog

(

    new DateVersionSpec(date),

    new ChangesetVersionSpec(DateTime.Now),

    1

).History[0].ChangeSetId - 1;

}

• corner case handling

Is that only 1 call or am I overestimating the TFS API?

You are missing a couple of corner cases, yes.

Handling requests for dates before the repository started, and handling dates after the last commit.

Both would cause exceptions in the API

Does it throw useful exceptions (e.g. something like DateRangeException rather than BadCallException)? If so, I'd be tempted to catch them and report them to the caller or user. It would be more 'correct' to ask TFS for the information first, but if cutting down on wire traffic (or new TCP connections - it can't be that bad, can it?) is that important then I think it's fair to break the "exceptions are for stuff you couldn't anticipate" rule.

I suppose the repository's first commit isn't going to change, so you can cache that, at least.

In one case, it throw something useful (date before anything in the repos), in the other, it just do random things.

In your code, it would return the second most recent commit

I think I might now have the same worst case as yourself.

class TFSRepository

{

private const TFSFirstRevisionId = 1; // Assumption.


private DateTime initialRevisionDate;


private DateTime InitialRevisionDate()

{

    if (initialRevisionDate == null)

    {

         initialRevisionDate = sourceControl.QueryLog(

             new ChangesetVersionSpec(TFSFirstRevisionId), 

             new ChangesetVersionSpec(TFSFirstRevisionId),

             1

        ).History[0].CommitDateTime;

    }


    return initialRevisionDate;

}


private void AssertRepositoryInitialized(int latestRevisionId)

{

    if (latestRevisionId < TFSFirstRevisionId)

        throw new RepositoryNotYetBornException();

}


private DateTime RevisionDateTime(int revisionId)

{

    DateTime currentRevisionDate = sourceControl.QueryLog

    (

           new ChangesetVersionSpec(revisionId),

           new ChangesetVersionSpec(revisionId),

           1

    ).History[0].CommitDateTime;

}


public int GetVersionForDate(DateTime date)

{

    int currentRevisionId = sourceControl.GetLatestId();


    AssertRepositoryInitialized(currentRevisionId);


    DateTime initialRevisionDateTime = RevisionDateTime(TFSFirstRevisionId);


    DateTime currentRevisionDateTime = RevisionDateTime(currentRevisionId);


   if (date < InitialRevisionDateTime)

       throw new DateBeforeFirstRevisionException(date);


   if (date > currentRevisionDateTime)

       throw new DateAfterCurrentRevisionException(date);


    return sourceControl.QueryLog

    (

        new DateVersionSpec(date),

        new ChangesetVersionSpec(currentRevisionDateTime),

    ).History[0].ChangeSetId - 1;

}

}

Rik, take a look at:

http://www.codeplex.com/SvnBridge/SourceControl/FileView.aspx?itemId=94304&changeSetId=17051

GetVersionForDate()

Amazing

Wow, you incorporated my code quickly! ;)

What's up with this? A 2d return array that always has only one element in each array?

BranchRelative[][] branches =

                        SourceControlService.QueryBranches(serverUrl,

                                                           credentials,

                                                           null,

                                                           new ItemSpec[] { spec },

                                                           branchChangeset);

                    string oldName =

                        branches[0][branches[0].GetUpperBound(0)].BranchFromItem.item.Substring(rootPath.Length);

pb,

I will make no comment about TFS at this time.