ChallengePremature optimization, and all of that…

time to read 6 min | 1174 words

Let us look at the following pieces of code:

public void Consume(MyBooksRequest message)
{
    var user = session.Get<User>(message.UserId);
    
    bus.Reply(new MyBooksResponse
    {
        UserId = message.UserId,
        Timestamp = DateTime.Now,
        Books = user.CurrentlyReading.ToBookDtoArray()
    });
}

public void Consume(MyQueueRequest message)
{
    var user = session.Get<User>(message.UserId);

    bus.Reply(new MyQueueResponse
    {
        UserId = message.UserId,
        Timestamp = DateTime.Now,
        Queue = user.Queue.ToBookDtoArray()
    });
}

public void Consume(MyRecommendationsRequest message)
{
    var user = session.Get<User>(message.UserId);

    bus.Reply(new MyRecommendationsResponse
    {
        UserId = message.UserId,
        Timestamp = DateTime.Now,
        Recommendations = user.Recommendations.ToBookDtoArray()
    });
}

Looking at this, I see that I have a requirement to getting my books, my queues and my recommendations. It appears that getting each datum is going to result in 2 queries, the first to load the User, and the second to lazy load the actual collection that we want to return.

An almost trivial optimization would be to eliminate the lazy loading, right? That would reduce the cost from 6 queries to just 3.

However, that assumption would be wrong. The following client code:

bus.Send(
    new MyBooksRequest
    {
        UserId = userId
    },
    new MyQueueRequest
    {
        UserId = userId
    },
    new MyRecommendationsRequest
    {
        UserId = userId
    });

Produces this SQL:

-- statement #1
enlisted session in distributed transaction with isolation level: Serializable

-- statement #2
SELECT user0_.Id          as Id2_0_,
       user0_.Name        as Name2_0_,
       user0_.Street      as Street2_0_,
       user0_.Country     as Country2_0_,
       user0_.City        as City2_0_,
       user0_.ZipCode     as ZipCode2_0_,
       user0_.HouseNumber as HouseNum7_2_0_
FROM   Users user0_
WHERE  user0_.Id = 1 /* @p0 */

-- statement #3
SELECT currentlyr0_.[User] as User1_1_,
       currentlyr0_.Book   as Book1_,
       book1_.Id           as Id0_0_,
       book1_.Name         as Name0_0_,
       book1_.ImageUrl     as ImageUrl0_0_,
       book1_.Image        as Image0_0_,
       book1_.Author       as Author0_0_
FROM   UsersReadingBooks currentlyr0_
       left outer join Books book1_
         on currentlyr0_.Book = book1_.Id
WHERE  currentlyr0_.[User] = 1 /* @p0 */

-- statement #4
SELECT queue0_.[User]  as User1_1_,
       queue0_.Book    as Book1_,
       queue0_.[Index] as Index3_1_,
       book1_.Id       as Id0_0_,
       book1_.Name     as Name0_0_,
       book1_.ImageUrl as ImageUrl0_0_,
       book1_.Image    as Image0_0_,
       book1_.Author   as Author0_0_
FROM   UsersWaitingBooks queue0_
       left outer join Books book1_
         on queue0_.Book = book1_.Id
WHERE  queue0_.[User] = 1 /* @p0 */

-- statement #5
SELECT recommenda0_.[User]  as User1_1_,
       recommenda0_.Book    as Book1_,
       recommenda0_.[Index] as Index3_1_,
       book1_.Id            as Id0_0_,
       book1_.Name          as Name0_0_,
       book1_.ImageUrl      as ImageUrl0_0_,
       book1_.Image         as Image0_0_,
       book1_.Author        as Author0_0_
FROM   UsersRecommendedBooks recommenda0_
       left outer join Books book1_
         on recommenda0_.Book = book1_.Id
WHERE  recommenda0_.[User] = 1 /* @p0 */


-- statement #7
commit transaction

That seems strange, can you figure out why?

Bonus points for figuring out whatever it would be worth it to do the eager load optimization or not.

More posts in "Challenge" series:

  1. (21 Apr 2020) Generate matching shard id–answer
  2. (20 Apr 2020) Generate matching shard id
  3. (02 Jan 2020) Spot the bug in the stream
  4. (28 Sep 2018) The loop that leaks–Answer
  5. (27 Sep 2018) The loop that leaks
  6. (03 Apr 2018) The invisible concurrency bug–Answer
  7. (02 Apr 2018) The invisible concurrency bug
  8. (31 Jan 2018) Find the bug in the fix–answer
  9. (30 Jan 2018) Find the bug in the fix
  10. (19 Jan 2017) What does this code do?
  11. (26 Jul 2016) The race condition in the TCP stack, answer
  12. (25 Jul 2016) The race condition in the TCP stack
  13. (28 Apr 2015) What is the meaning of this change?
  14. (26 Sep 2013) Spot the bug
  15. (27 May 2013) The problem of locking down tasks…
  16. (17 Oct 2011) Minimum number of round trips
  17. (23 Aug 2011) Recent Comments with Future Posts
  18. (02 Aug 2011) Modifying execution approaches
  19. (29 Apr 2011) Stop the leaks
  20. (23 Dec 2010) This code should never hit production
  21. (17 Dec 2010) Your own ThreadLocal
  22. (03 Dec 2010) Querying relative information with RavenDB
  23. (29 Jun 2010) Find the bug
  24. (23 Jun 2010) Dynamically dynamic
  25. (28 Apr 2010) What killed the application?
  26. (19 Mar 2010) What does this code do?
  27. (04 Mar 2010) Robust enumeration over external code
  28. (16 Feb 2010) Premature optimization, and all of that…
  29. (12 Feb 2010) Efficient querying
  30. (10 Feb 2010) Find the resource leak
  31. (21 Oct 2009) Can you spot the bug?
  32. (18 Oct 2009) Why is this wrong?
  33. (17 Oct 2009) Write the check in comment
  34. (15 Sep 2009) NH Prof Exporting Reports
  35. (02 Sep 2009) The lazy loaded inheritance many to one association OR/M conundrum
  36. (01 Sep 2009) Why isn’t select broken?
  37. (06 Aug 2009) Find the bug fixes
  38. (26 May 2009) Find the bug
  39. (14 May 2009) multi threaded test failure
  40. (11 May 2009) The regex that doesn’t match
  41. (24 Mar 2009) probability based selection
  42. (13 Mar 2009) C# Rewriting
  43. (18 Feb 2009) write a self extracting program
  44. (04 Sep 2008) Don't stop with the first DSL abstraction
  45. (02 Aug 2008) What is the problem?
  46. (28 Jul 2008) What does this code do?
  47. (26 Jul 2008) Find the bug fix
  48. (05 Jul 2008) Find the deadlock
  49. (03 Jul 2008) Find the bug
  50. (02 Jul 2008) What is wrong with this code
  51. (05 Jun 2008) why did the tests fail?
  52. (27 May 2008) Striving for better syntax
  53. (13 Apr 2008) calling generics without the generic type
  54. (12 Apr 2008) The directory tree
  55. (24 Mar 2008) Find the version
  56. (21 Jan 2008) Strongly typing weakly typed code
  57. (28 Jun 2007) Windsor Null Object Dependency Facility