ChallengePremature optimization, and all of that…
Let us look at the following pieces of code:
public void Consume(MyBooksRequest message) { var user = session.Get<User>(message.UserId); bus.Reply(new MyBooksResponse { UserId = message.UserId, Timestamp = DateTime.Now, Books = user.CurrentlyReading.ToBookDtoArray() }); } public void Consume(MyQueueRequest message) { var user = session.Get<User>(message.UserId); bus.Reply(new MyQueueResponse { UserId = message.UserId, Timestamp = DateTime.Now, Queue = user.Queue.ToBookDtoArray() }); } public void Consume(MyRecommendationsRequest message) { var user = session.Get<User>(message.UserId); bus.Reply(new MyRecommendationsResponse { UserId = message.UserId, Timestamp = DateTime.Now, Recommendations = user.Recommendations.ToBookDtoArray() }); }
Looking at this, I see that I have a requirement to getting my books, my queues and my recommendations. It appears that getting each datum is going to result in 2 queries, the first to load the User, and the second to lazy load the actual collection that we want to return.
An almost trivial optimization would be to eliminate the lazy loading, right? That would reduce the cost from 6 queries to just 3.
However, that assumption would be wrong. The following client code:
bus.Send( new MyBooksRequest { UserId = userId }, new MyQueueRequest { UserId = userId }, new MyRecommendationsRequest { UserId = userId });
Produces this SQL:
-- statement #1 enlisted session in distributed transaction with isolation level: Serializable -- statement #2 SELECT user0_.Id as Id2_0_, user0_.Name as Name2_0_, user0_.Street as Street2_0_, user0_.Country as Country2_0_, user0_.City as City2_0_, user0_.ZipCode as ZipCode2_0_, user0_.HouseNumber as HouseNum7_2_0_ FROM Users user0_ WHERE user0_.Id = 1 /* @p0 */ -- statement #3 SELECT currentlyr0_.[User] as User1_1_, currentlyr0_.Book as Book1_, book1_.Id as Id0_0_, book1_.Name as Name0_0_, book1_.ImageUrl as ImageUrl0_0_, book1_.Image as Image0_0_, book1_.Author as Author0_0_ FROM UsersReadingBooks currentlyr0_ left outer join Books book1_ on currentlyr0_.Book = book1_.Id WHERE currentlyr0_.[User] = 1 /* @p0 */ -- statement #4 SELECT queue0_.[User] as User1_1_, queue0_.Book as Book1_, queue0_.[Index] as Index3_1_, book1_.Id as Id0_0_, book1_.Name as Name0_0_, book1_.ImageUrl as ImageUrl0_0_, book1_.Image as Image0_0_, book1_.Author as Author0_0_ FROM UsersWaitingBooks queue0_ left outer join Books book1_ on queue0_.Book = book1_.Id WHERE queue0_.[User] = 1 /* @p0 */ -- statement #5 SELECT recommenda0_.[User] as User1_1_, recommenda0_.Book as Book1_, recommenda0_.[Index] as Index3_1_, book1_.Id as Id0_0_, book1_.Name as Name0_0_, book1_.ImageUrl as ImageUrl0_0_, book1_.Image as Image0_0_, book1_.Author as Author0_0_ FROM UsersRecommendedBooks recommenda0_ left outer join Books book1_ on recommenda0_.Book = book1_.Id WHERE recommenda0_.[User] = 1 /* @p0 */ -- statement #7 commit transaction
That seems strange, can you figure out why?
Bonus points for figuring out whatever it would be worth it to do the eager load optimization or not.
More posts in "Challenge" series:
- (01 Jul 2024) Efficient snapshotable state
- (13 Oct 2023) Fastest node selection metastable error state–answer
- (12 Oct 2023) Fastest node selection metastable error state
- (19 Sep 2023) Spot the bug
- (04 Jan 2023) what does this code print?
- (14 Dec 2022) What does this code print?
- (01 Jul 2022) Find the stack smash bug… – answer
- (30 Jun 2022) Find the stack smash bug…
- (03 Jun 2022) Spot the data corruption
- (06 May 2022) Spot the optimization–solution
- (05 May 2022) Spot the optimization
- (06 Apr 2022) Why is this code broken?
- (16 Dec 2021) Find the slow down–answer
- (15 Dec 2021) Find the slow down
- (03 Nov 2021) The code review bug that gives me nightmares–The fix
- (02 Nov 2021) The code review bug that gives me nightmares–the issue
- (01 Nov 2021) The code review bug that gives me nightmares
- (16 Jun 2021) Detecting livelihood in a distributed cluster
- (21 Apr 2020) Generate matching shard id–answer
- (20 Apr 2020) Generate matching shard id
- (02 Jan 2020) Spot the bug in the stream
- (28 Sep 2018) The loop that leaks–Answer
- (27 Sep 2018) The loop that leaks
- (03 Apr 2018) The invisible concurrency bug–Answer
- (02 Apr 2018) The invisible concurrency bug
- (31 Jan 2018) Find the bug in the fix–answer
- (30 Jan 2018) Find the bug in the fix
- (19 Jan 2017) What does this code do?
- (26 Jul 2016) The race condition in the TCP stack, answer
- (25 Jul 2016) The race condition in the TCP stack
- (28 Apr 2015) What is the meaning of this change?
- (26 Sep 2013) Spot the bug
- (27 May 2013) The problem of locking down tasks…
- (17 Oct 2011) Minimum number of round trips
- (23 Aug 2011) Recent Comments with Future Posts
- (02 Aug 2011) Modifying execution approaches
- (29 Apr 2011) Stop the leaks
- (23 Dec 2010) This code should never hit production
- (17 Dec 2010) Your own ThreadLocal
- (03 Dec 2010) Querying relative information with RavenDB
- (29 Jun 2010) Find the bug
- (23 Jun 2010) Dynamically dynamic
- (28 Apr 2010) What killed the application?
- (19 Mar 2010) What does this code do?
- (04 Mar 2010) Robust enumeration over external code
- (16 Feb 2010) Premature optimization, and all of that…
- (12 Feb 2010) Efficient querying
- (10 Feb 2010) Find the resource leak
- (21 Oct 2009) Can you spot the bug?
- (18 Oct 2009) Why is this wrong?
- (17 Oct 2009) Write the check in comment
- (15 Sep 2009) NH Prof Exporting Reports
- (02 Sep 2009) The lazy loaded inheritance many to one association OR/M conundrum
- (01 Sep 2009) Why isn’t select broken?
- (06 Aug 2009) Find the bug fixes
- (26 May 2009) Find the bug
- (14 May 2009) multi threaded test failure
- (11 May 2009) The regex that doesn’t match
- (24 Mar 2009) probability based selection
- (13 Mar 2009) C# Rewriting
- (18 Feb 2009) write a self extracting program
- (04 Sep 2008) Don't stop with the first DSL abstraction
- (02 Aug 2008) What is the problem?
- (28 Jul 2008) What does this code do?
- (26 Jul 2008) Find the bug fix
- (05 Jul 2008) Find the deadlock
- (03 Jul 2008) Find the bug
- (02 Jul 2008) What is wrong with this code
- (05 Jun 2008) why did the tests fail?
- (27 May 2008) Striving for better syntax
- (13 Apr 2008) calling generics without the generic type
- (12 Apr 2008) The directory tree
- (24 Mar 2008) Find the version
- (21 Jan 2008) Strongly typing weakly typed code
- (28 Jun 2007) Windsor Null Object Dependency Facility
Comments
Looks like RSB handles message batches in a single transaction. Is it a bug or feature? BTW, serializable isolation level is almost guaranteed to cause problems in real world application.
Rafal,
Yes, that IS a feature.
And serializable isolation is actually a good thing in some circumstances. For one, it make it really simple to think about concurrency, and if all our data is user scoped, we aren't going to deal with a lot of complexity either.
Ah, I thought that sending an array of message is there only for performance reasons or developer convenience, didn't know about this little side effect.
Uhmm,
If the session crunching the messages is the same for all the messages in this example, then the first level cache is already an optimization. Eagerly fetch more then one collection at a time may results in a cartesian product query, that is worst than executing the 3 query to load the collection when needed.
Since one session is used, calls to session.Get <user(message.UserId) will only hit the database once.
The first time this is done, the books, queues and collections are eagerly loaded (if specified, you can't tell from the queries), but in a seperate select statements. I would not set fetchmode to join because this will lead to cartesian product. Further optimization could be to use a multicriteriaquery to send the three queries at once. But that would be an MS SQL specific optimization.
may be grouping all those queries into the same transaction might cause some more deadlocks?
Simone,
Can you envision a way in which two concurrent transactions (even for the same user) can deadlock with this code?
The problem in fact is with the type of transaction you're using
A transaction with Serializable Isolation places a range lock on the data set, preventing other users from updating or inserting rows into the data set until the transaction is complete.
Grouping those 4 queries on the same transaction will eventually put some more stress to the database if used in conjunction with a serializable transaction .
here I wrote a little bit more :)
http://smnbss.spaces.live.com/blog/cns!A117AA5E007A0648!1894.entry?&_c02_vws=1
Simone,
All the data that I am accessing is local to the current user
Sure, in your specific case it might not be a problem, but if you have other services accessing the same data with other queries it might create some problems. BTW, what is the problem then with that query? :)
Comment preview