ChallengeWhat killed the application?

time to read 2 min | 267 words

I have been doing a lot of heavy performance testing on Raven, and I run into a lot of very strange scenarios. I found a lot of interesting stuff (runaway cache causing OutOfMemoryException, unnecessary re-parsing, etc). But one thing that I wasn’t able to resolve was the concurrency issue.

In particular, Raven would slow down and crash under load. I scoured the code, trying to figure out what was going on, but I couldn’t figure it out. It seemed that after several minutes of executing, request times would grow longer and longer, until finally the server would start raising errors on most requests.

I am ashamed to say that it took me a while to figure out what was actually going on. Can you figure it out?

Here is the client code:

Parallel.ForEach(Directory.GetFiles("Docs","*.json"), file =>
{
    PostTo("http://localhost:9090/bulk_docs", file);
});

The Docs directory contains about 90,000 files, and there is no concurrent connection limit. Average processing time for each request when running in a single threaded mode was 100 – 200 ms.

That should be enough information to figure out what is going on.

Why did the application crash?

More posts in "Challenge" series:

  1. (21 Apr 2020) Generate matching shard id–answer
  2. (20 Apr 2020) Generate matching shard id
  3. (02 Jan 2020) Spot the bug in the stream
  4. (28 Sep 2018) The loop that leaks–Answer
  5. (27 Sep 2018) The loop that leaks
  6. (03 Apr 2018) The invisible concurrency bug–Answer
  7. (02 Apr 2018) The invisible concurrency bug
  8. (31 Jan 2018) Find the bug in the fix–answer
  9. (30 Jan 2018) Find the bug in the fix
  10. (19 Jan 2017) What does this code do?
  11. (26 Jul 2016) The race condition in the TCP stack, answer
  12. (25 Jul 2016) The race condition in the TCP stack
  13. (28 Apr 2015) What is the meaning of this change?
  14. (26 Sep 2013) Spot the bug
  15. (27 May 2013) The problem of locking down tasks…
  16. (17 Oct 2011) Minimum number of round trips
  17. (23 Aug 2011) Recent Comments with Future Posts
  18. (02 Aug 2011) Modifying execution approaches
  19. (29 Apr 2011) Stop the leaks
  20. (23 Dec 2010) This code should never hit production
  21. (17 Dec 2010) Your own ThreadLocal
  22. (03 Dec 2010) Querying relative information with RavenDB
  23. (29 Jun 2010) Find the bug
  24. (23 Jun 2010) Dynamically dynamic
  25. (28 Apr 2010) What killed the application?
  26. (19 Mar 2010) What does this code do?
  27. (04 Mar 2010) Robust enumeration over external code
  28. (16 Feb 2010) Premature optimization, and all of that…
  29. (12 Feb 2010) Efficient querying
  30. (10 Feb 2010) Find the resource leak
  31. (21 Oct 2009) Can you spot the bug?
  32. (18 Oct 2009) Why is this wrong?
  33. (17 Oct 2009) Write the check in comment
  34. (15 Sep 2009) NH Prof Exporting Reports
  35. (02 Sep 2009) The lazy loaded inheritance many to one association OR/M conundrum
  36. (01 Sep 2009) Why isn’t select broken?
  37. (06 Aug 2009) Find the bug fixes
  38. (26 May 2009) Find the bug
  39. (14 May 2009) multi threaded test failure
  40. (11 May 2009) The regex that doesn’t match
  41. (24 Mar 2009) probability based selection
  42. (13 Mar 2009) C# Rewriting
  43. (18 Feb 2009) write a self extracting program
  44. (04 Sep 2008) Don't stop with the first DSL abstraction
  45. (02 Aug 2008) What is the problem?
  46. (28 Jul 2008) What does this code do?
  47. (26 Jul 2008) Find the bug fix
  48. (05 Jul 2008) Find the deadlock
  49. (03 Jul 2008) Find the bug
  50. (02 Jul 2008) What is wrong with this code
  51. (05 Jun 2008) why did the tests fail?
  52. (27 May 2008) Striving for better syntax
  53. (13 Apr 2008) calling generics without the generic type
  54. (12 Apr 2008) The directory tree
  55. (24 Mar 2008) Find the version
  56. (21 Jan 2008) Strongly typing weakly typed code
  57. (28 Jun 2007) Windsor Null Object Dependency Facility