Small optimizations? Did you check that idiot checkbox yet?
time to read 2 min | 296 words

I started to write the following code:

operationsInTransactions.GetOrAdd(txId,  new List<Command>())
    .Add(new Command
    {
        Key = key,
        Position = position,
        Type = CommandType.Put
    });

But then I realized that in the happy path, I would always allocate a list, even if I don’t need it, and I changed it to this:

operationsInTransactions.GetOrAdd(txId, guid => new List<Command>())
    .Add(new Command
    {
        Key = key,
        Position = position,
        Type = CommandType.Put
    });

Why am I being stupid?

Hint: It has nothing to do with the stupidity associated with trying to do micro optimizations…

0 comments

Related posts that you may find interesting:

17 May 2012 When using the Task Parallel Library, Wait() is a BAD warning sign
design development
13 Feb 2012 Limit your abstractions: You only get six to a dozen in the entire app
architecture
04 Jan 2010 Using ReaderWriterLockSlim’s EnterUpgradeableReadLock
Programming