Bug of the day...
time to read 1 min | 13 words
Using MbUnit 2.4, this test pass:
Guid g = Guid.Empty; Assert.AreEqual(Guid.Empty, g); Assert.AreNotEqual(Guid.Empty, g);
Ayende @ Rahien
Ayende @ Rahien
Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by email or phone:
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by email or phone:
+972 52-548-6969
FUTURE POSTS
No future posts left, oh my!
RECENT SERIES
-
Inside RavenDB 4.0
(7):
16 Apr 2018 - Chapter 16 is done -
RavenDB Security Report
(5):
06 Apr 2018 - Collision in Certificate Serial Numbers -
Challenge
(52):
03 Apr 2018 - The invisible concurrency bug–Answer -
RavenDB Security Review
(5):
27 Mar 2018 - Non-Constant Time Secret Comparison -
Properly getting into jail
(13):
19 Mar 2018 - The almighty document
RECENT COMMENTS
-
By peter on NHibernate Profiler and Entity Framework Profiler 5.0 RTM
-
By Gabriel on Avoid a standalone DbService process
-
By M. Schopman on Soliciting feedback about RavenDB 4.0 and TODOs for 4.1
-
By Pure Krome on Soliciting feedback about RavenDB 4.0 and TODOs for 4.1
-
By Oren Eini on Soliciting feedback about RavenDB 4.0 and TODOs for 4.1
Syndication
| Main feed | |
| Comments feed |
Comments
well that's helpful
Yep, ran into that one a while ago...
http://code.google.com/p/mb-unit/issues/detail?id=114
It's funny that I have stumbled in the exactly same bug today.
Well, seems almost no one is actually using AreNotEqual if this lived to the 2.4.
Thanks Oren, I'll need to investigate this more but I think in the absence of an assert for Guid that MbUnit is casting to object and then equating as a null. The AreNotEqual has this gem.
if (expected == null ^ actual == null)
return;
As both become null in the cast it passes. Thats a complete guess at the moment until I can investigate more. Always fun.
Andy
Maybe it been updated since the version I'm running (1.0.2700) but the real problem I see is that AreEqual(object, object) uses the object's Equals() methods (via ObjectsEqual) which is customized to the class, while AreNotEqual just uses !(obj==obj) which ultimately just Object.ReferenceEquals.
That's because GUIDs are so unique that even two identical GUIDs are not quite equal. Duh.
That's nothing compared to my bug of the day:
try running this piece of code in the immediate window and then in the body of a funcion.
bool a = object.ReferenceEquals("A","A")
a would be true as the compiler would have inturned the string "A"
Comment preview