Bug of the day...
time to read 1 min | 13 words
Using MbUnit 2.4, this test pass:
Guid g = Guid.Empty; Assert.AreEqual(Guid.Empty, g); Assert.AreNotEqual(Guid.Empty, g);
Ayende @ Rahien
Ayende @ Rahien
Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:
+972 52-548-6969
FUTURE POSTS
- RavenDB Restorspective - 8 days from now
- Playing with the StackOverflow datasets : All the wrong ways - 11 days from now
There are posts all the way to Oct 10, 2016
RECENT SERIES
-
Interview question
(3):
29 Sep 2016 - Stackoverflow THAT -
Voron internals
(5):
13 Sep 2016 - The diff is the way -
Database Building 101
(8):
25 Aug 2016 - Graph querying over large datasets -
Production postmortem
(16):
23 Aug 2016 - The insidious cost of managed memory -
Digging into the CoreCLR
(3):
12 Aug 2016 - Exceptional costs, Part II
RECENT COMMENTS
-
By Jesús López on Interview question: Stackoverflow THAT
-
By Ian Cross on Interview question: Stackoverflow THAT
-
By ren on Interview question: Stackoverflow THAT
-
By Alex Davidson on Interview question: Stackoverflow THAT
-
By Carsten Hansen on Interview question: Stackoverflow THAT
Syndication
| Main feed |
|
| Comments feed | |
Comments
well that's helpful
Yep, ran into that one a while ago...
http://code.google.com/p/mb-unit/issues/detail?id=114
It's funny that I have stumbled in the exactly same bug today.
Well, seems almost no one is actually using AreNotEqual if this lived to the 2.4.
Thanks Oren, I'll need to investigate this more but I think in the absence of an assert for Guid that MbUnit is casting to object and then equating as a null. The AreNotEqual has this gem.
if (expected == null ^ actual == null)
return;
As both become null in the cast it passes. Thats a complete guess at the moment until I can investigate more. Always fun.
Andy
Maybe it been updated since the version I'm running (1.0.2700) but the real problem I see is that AreEqual(object, object) uses the object's Equals() methods (via ObjectsEqual) which is customized to the class, while AreNotEqual just uses !(obj==obj) which ultimately just Object.ReferenceEquals.
That's because GUIDs are so unique that even two identical GUIDs are not quite equal. Duh.
That's nothing compared to my bug of the day:
try running this piece of code in the immediate window and then in the body of a funcion.
bool a = object.ReferenceEquals("A","A")
a would be true as the compiler would have inturned the string "A"
Comment preview