It's returning an IEnumerable using yield. The caller would take out the ones they need. There's no sense in passing parameters like limit as it would the the callers' responsibility to get only the number they need. IEnumerable won't trigger data access until and unless the data is required and so the limit parameter doesn't have any use.

An endId and limit seem at odds with one another.

I'd change it to IEnumerable <dictionary<int,jsondocument>

, I think key-value dependencies are better handled using Dictionary. Any ideas?

Oh no, damned HTML. Again:

I'd change it to IEnumerable<Dictionary<int,JsonDocument>> I think key-value dependencies are better handled using Dictionary. Any ideas?

This might be personal preference but I really don't like methods exposing tuple types. Create a type (possibly a struct) that has carries some semantics instead of the tuple.

Note that this in C#, this would obviously not be my thoughts if the language was F#, Haskell, Erlang or any other functional language.

Is the collection between the startId and endId not continuous? A limit would make sense then.

Is it not also bad practice to publicly expose IEnumerable for methods like this ?

Yeah now that I've thought it through, I'm unsure why I even said that. I read something like this on someone's blog recently and haven't had time to process it.

When using 'yield' the resulting items will be returned 'lazily' (delayed execution).

This might not be what the method is intended to do. I think the intention is to have the results ready after the call.

It also might have potential issue when the underlying data store is closed and the enumeration gets executed.

Cheers,

Dmitriy,

@Patrik,

What I do in order to use the ease of tuples and other complex generic types, and get readable code, is to at least give them a friendly name by utilizing the using statement of C#.

An example is given on my blog: http://goo.gl/ksCm

In a specific context, you can also give the type friendly method names (like e.g. Ruby's alias methods) by using extension methods that are just simple pass-throughs.