Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 6,131 | Comments: 45,568

filter by tags archive

Comments

ashic

It's returning an IEnumerable using yield. The caller would take out the ones they need. There's no sense in passing parameters like limit as it would the the callers' responsibility to get only the number they need. IEnumerable won't trigger data access until and unless the data is required and so the limit parameter doesn't have any use.

James Newton-King

An endId and limit seem at odds with one another.

Ayende Rahien

James,

startId: 1

endId: 100000

limit: 100

Chojrak

I'd change it to IEnumerable <dictionary<int,jsondocument>

, I think key-value dependencies are better handled using Dictionary. Any ideas?

Chojrak

Oh no, damned HTML. Again:

I'd change it to IEnumerable<Dictionary<int,JsonDocument>> I think key-value dependencies are better handled using Dictionary. Any ideas?

Ayende Rahien

Chojrak,

It isn't key value. It is a tuple, it isn't a set of int to json doc, it is a int & json doc.

Patrik

This might be personal preference but I really don't like methods exposing tuple types. Create a type (possibly a struct) that has carries some semantics instead of the tuple.

Note that this in C#, this would obviously not be my thoughts if the language was F#, Haskell, Erlang or any other functional language.

James Newton-King

Is the collection between the startId and endId not continuous? A limit would make sense then.

Ayende Rahien

James,

Yes, the collection may not be continuous

Ayende Rahien

Patrik,

This is mostly for internal API needs, it just doesn't make sense to create a type here, it wouldn't add enough meaning

Andrew

Is it not also bad practice to publicly expose IEnumerable for methods like this ?

Ayende Rahien

Andrew,

I disagree with that quite strongly

Andrew

Yeah now that I've thought it through, I'm unsure why I even said that. I read something like this on someone's blog recently and haven't had time to process it.

Dmitriy Nagirnyak

When using 'yield' the resulting items will be returned 'lazily' (delayed execution).

This might not be what the method is intended to do. I think the intention is to have the results ready after the call.

It also might have potential issue when the underlying data store is closed and the enumeration gets executed.

Cheers,

Dmitriy,

Martin R-L

@Patrik,

What I do in order to use the ease of tuples and other complex generic types, and get readable code, is to at least give them a friendly name by utilizing the using statement of C#.

An example is given on my blog: http://goo.gl/ksCm

In a specific context, you can also give the type friendly method names (like e.g. Ruby's alias methods) by using extension methods that are just simple pass-throughs.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. RavenDB Conference 2016–Slides - 2 hours from now
  2. Proposed solution to the low level interview question - about one day from now

There are posts all the way to Jun 02, 2016

RECENT SERIES

  1. The design of RavenDB 4.0 (14):
    26 May 2016 - The client side
  2. RavenDB 3.5 whirl wind tour (14):
    25 May 2016 - Got anything to declare, ya smuggler?
  3. Tasks for the new comer (2):
    15 Apr 2016 - Quartz.NET with RavenDB
  4. Code through the looking glass (5):
    18 Mar 2016 - And a linear search to rule them
  5. Find the bug (8):
    29 Feb 2016 - When you can't rely on your own identity
View all series

RECENT COMMENTS

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats