Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 6,128 | Comments: 45,549

filter by tags archive

Hunt the bug

time to read 1 min | 180 words

The following code will throw under certain circumstances, what are they?

public class Global : HttpApplication
{
       public void Application_Start(object sender, EventArgs e)
       {
            HttpUtility.UrlEncode("Error inside!");
       }
}

Hint, the exception will not be raised because of transient conditions such as low memory.

What are the conditions in which it would throw, and why?

Hint #2, I had to write my own (well, take the one from Mono and modify it) HttpUtility to avoid this bug.

ARGH!


Comments

tobi

I guess it has to do with the new HttpEncoder support. I can be disabled by setting Response.DisableCustomHttpEncoder but that is not available in application start. You could have used HttpEncoder.Default however.

Artur

I'm guessing that HttpUtility underneath requires an HttpContext and that might not be present at Application_Start.

Victor Kornov

Yep, starting .NET 4 HttpUtility requires a HttpContext /HttpResponse wich is not yet available at the time of Application_Start with IIS7 in integrated mode. I guess the stack trace looks like:

[HttpException (0x80004005): Response is not available in this context.]

System.Web.HttpContext.get_Response() +8753496

System.Web.Util.HttpEncoder.get_Current() +39

System.Web.HttpUtility.UrlEncodeToBytes(String str, Encoding e) +31

System.Web.HttpUtility.UrlEncode(String str) +41

Global.Application_Start(Object sender, EventArgs e)

tobi

This means that the context is available but it is a fake one - getting the response throws. My workaround that I posted is still valid ;-)

Sebastien Ros

There has been some changes in .NET 4 which introduced this bug. I hit it when we switched our solution to VS2010. So as it's actually forgetting to check HttpContext.Current null values before using it, we hacked this by assigning a mock HttpContext around it.

Sebastien

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. The worker pattern - 2 days from now

There are posts all the way to May 30, 2016

RECENT SERIES

  1. The design of RavenDB 4.0 (14):
    26 May 2016 - The client side
  2. RavenDB 3.5 whirl wind tour (14):
    25 May 2016 - Got anything to declare, ya smuggler?
  3. Tasks for the new comer (2):
    15 Apr 2016 - Quartz.NET with RavenDB
  4. Code through the looking glass (5):
    18 Mar 2016 - And a linear search to rule them
  5. Find the bug (8):
    29 Feb 2016 - When you can't rely on your own identity
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats