I am doing a big merge, and as you can imagine, some tests are failing. I am currently just to get it out the door, and failing tests are really annoying.
I identified the problem, but resolving it would be too hard right now, so I opted for the following solution instead:
Wouldn't it be more useful to Assert.Inconclusive on the test that failed until the time was up and then just run the test as normal? At least then it would report on the correct test.
Matt,
Assert.Inconclusive is not a feature of XUnit. And we don't want to have an inconclusive test, we want one that doesn't run until a specific time.
> Email-style angle brackets
> are used for blockquotes.
> > And, they can be nested.
> #### Headers in blockquotes
>
> * You can quote a list.
> * Etc.
Horizontal Rules
Three or more dashes or asterisks:
---
* * *
- - - -
Manual Line Breaks
End a line with two or more spaces:
Roses are red,
Violets are blue.
Fenced Code Blocks
Code blocks delimited by 3 or more backticks or tildas:
```
This is a preformatted
code block
```
Header IDs
Set the id of headings with {#<id>} at end of heading line:
## My Heading {#myheading}
Tables
Fruit |Color
---------|----------
Apples |Red
Pears |Green
Bananas |Yellow
Definition Lists
Term 1
: Definition 1
Term 2
: Definition 2
Footnotes
Body text with a footnote [^1]
[^1]: Footnote text here
Abbreviations
MDD <- will have title
*[MDD]: MarkdownDeep
FUTURE POSTS
Partial writes, IO_Uring and safety - about one day from now
Configuration values & Escape hatches - 5 days from now
What happens when a sparse file allocation fails? - 7 days from now
NTFS has an emergency stash of disk space - 9 days from now
Challenge: Giving file system developer ulcer - 12 days from now
And 4 more posts are pending...
There are posts all the way to Feb 17, 2025
RECENT SERIES
Challenge
(77): 20 Jan 2025 - What does this code do?
Answer
(13): 22 Jan 2025 - What does this code do?
Comments
What a nice time bomb planted under your desk! The future version of you will course the past version.
*curse
"identified the problem, but resolving it would be too hard right now" - it will be even harder later.
Not using your SystemTime class for that one then :D
Maybe you should throw a TimeoutException instead ... ;)
// Ryan
@Franky Junge - that would make it tempting to fix the issue with: SystemTime.Now = () => new DateTime(2000,1,1); :-)
Wouldn't it be more useful to Assert.Inconclusive on the test that failed until the time was up and then just run the test as normal? At least then it would report on the correct test.
Matt, Assert.Inconclusive is not a feature of XUnit. And we don't want to have an inconclusive test, we want one that doesn't run until a specific time.
I have done this in the past. Just try and resist editing and pushing the date back three times before you really fix it! :-)
Comment preview