Spot the bug…
time to read 1 min | 39 words
Do you see it? It took me ages to find it.
Ayende @ Rahien
Ayende @ Rahien
Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by email or phone:
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by email or phone:
+972 52-548-6969
FUTURE POSTS
- Cost centers, revenue centers and politics in a cross organization world - 16 hours from now
- Giving Demeter PTSD - about one day from now
- PR Review: Code has cost, justify it - 3 days from now
- PR Review: Beware the things you can’t see - 6 days from now
- The right thing and what the user expect to happen are completely unrelated - 7 days from now
And 1 more posts are pending...
There are posts all the way to Oct 25, 2017
RECENT SERIES
-
PR Review
(7):
10 Aug 2017 - Errors, errors and more errors -
RavenDB 4.0
(15):
13 Oct 2017 - Interlocked distributed operations -
re
(21):
10 Oct 2017 - Entity Framework Core performance tuning–Part III -
RavenDB 4.0 Unsung Heroes
(5):
05 Oct 2017 - The design of the security error flow -
Writing SSL Proxy
(2):
27 Sep 2017 - Part II, delegating authentication
RECENT COMMENTS
-
By Judah Himango on Complex Linq queries in RavenDB 4.0
-
By Oren Eini on Complex Linq queries in RavenDB 4.0
-
By Aleksander Oven on Complex Linq queries in RavenDB 4.0
-
By Oren Eini on Security analysis on error reporting
-
By Oleg Mihailik on Security analysis on error reporting
Syndication
| Main feed |
|
| Comments feed | |
Comments
Yay scoping braces!
Ha ha, it's quite subtle, but so obvious once you spot it.
I think there is something 'else' missing ;-)
Missing else?
LOL, I didn't saw it either
Not to mention the sheer lunacy of mid not being related to target in any discernable way. Ugh.
(oh, yeah, and missing else)
Apart from missing else, what about arithmetic overflow?
I would change the line: var mid = (left + right + 1) / 2;
to this: var mid = left + (right - left + 1) / 2;
You still get the same result, but it's a little bit safer for higher values.
The bug aside, I'd use checked((left + right + 1) / 2).
Another potential problem: behavior of comparator might be not aligned with subtraction, so that
_comparator.Compare(mid-1, mid) >=0
This is really a tricky problem to spot. :) Everyone is focused on the code inside the brackets and the missing "else" is not being observed very fast.
Sorry to dissapoint, took me a second.
Anyway, I don't belive in scoping braces when they contain 1 line, it's not safer and not easier to read.. just redundant.
Comment preview