Spot the bug…
time to read 1 min | 39 words
Do you see it? It took me ages to find it.
Markdown formatting
ESC to close
Markdown turns plain text formatting into fancy HTML formatting.
Phrase Emphasis
*italic* **bold**
_italic_ __bold__
Links
Inline:
An [example](http://url.com/ "Title")
Reference-style labels (titles are optional):
An [example][id]. Then, anywhere
else in the doc, define the link:
[id]: http://example.com/ "Title"
Images
Inline (titles are optional):
Reference-style:
![alt text][id]
[id]: /url/to/img.jpg "Title"
Headers
Setext-style:
Header 1
========
Header 2
--------
atx-style (closing #'s are optional):
# Header 1 #
## Header 2 ##
###### Header 6
Lists
Ordered, without paragraphs:
1. Foo
2. Bar
Unordered, with paragraphs:
* A list item.
With multiple paragraphs.
* Bar
You can nest them:
* Abacus
* answer
* Bubbles
1. bunk
2. bupkis
* BELITTLER
3. burper
* Cunning
Blockquotes
> Email-style angle brackets
> are used for blockquotes.
> > And, they can be nested.
> #### Headers in blockquotes
>
> * You can quote a list.
> * Etc.
Horizontal Rules
Three or more dashes or asterisks:
---
* * *
- - - -
Manual Line Breaks
End a line with two or more spaces:
Roses are red,
Violets are blue.
Fenced Code Blocks
Code blocks delimited by 3 or more backticks or tildas:
```
This is a preformatted
code block
```
Header IDs
Set the id of headings with {#<id>} at end of heading line:
## My Heading {#myheading}
Tables
Fruit |Color
---------|----------
Apples |Red
Pears |Green
Bananas |YellowDefinition Lists
Term 1
: Definition 1
Term 2
: Definition 2Footnotes
Body text with a footnote [^1]
[^1]: Footnote text here
Abbreviations
MDD <- will have title
*[MDD]: MarkdownDeep
Comments
Yay scoping braces!
Ha ha, it's quite subtle, but so obvious once you spot it.
I think there is something 'else' missing ;-)
Missing else?
LOL, I didn't saw it either
Not to mention the sheer lunacy of mid not being related to target in any discernable way. Ugh.
(oh, yeah, and missing else)
Apart from missing else, what about arithmetic overflow?
I would change the line: var mid = (left + right + 1) / 2;
to this: var mid = left + (right - left + 1) / 2;
You still get the same result, but it's a little bit safer for higher values.
The bug aside, I'd use checked((left + right + 1) / 2).
Another potential problem: behavior of comparator might be not aligned with subtraction, so that
_comparator.Compare(mid-1, mid) >=0
This is really a tricky problem to spot. :) Everyone is focused on the code inside the brackets and the missing "else" is not being observed very fast.
Sorry to dissapoint, took me a second.
Anyway, I don't belive in scoping braces when they contain 1 line, it's not safer and not easier to read.. just redundant.
Comment preview