Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 6,125 | Comments: 45,486

filter by tags archive

Comments

Fredrik

Ha ha, it's quite subtle, but so obvious once you spot it.

Sebastian

I think there is something 'else' missing ;-)

Sam
Sam

LOL, I didn't saw it either

Marc Brooks

Not to mention the sheer lunacy of mid not being related to target in any discernable way. Ugh.

(oh, yeah, and missing else)

P.Czatrowski

Apart from missing else, what about arithmetic overflow?

I would change the line: var mid = (left + right + 1) / 2;

to this: var mid = left + (right - left + 1) / 2;

You still get the same result, but it's a little bit safer for higher values.

tobi

The bug aside, I'd use checked((left + right + 1) / 2).

Roman Boiko

Another potential problem: behavior of comparator might be not aligned with subtraction, so that

_comparator.Compare(mid-1, mid) >=0

Alex

This is really a tricky problem to spot. :) Everyone is focused on the code inside the brackets and the missing "else" is not being observed very fast.

Adam Fridental

Sorry to dissapoint, took me a second.

Anyway, I don't belive in scoping braces when they contain 1 line, it's not safer and not easier to read.. just redundant.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. The design of RavenDB 4.0: Physically segregating collections - one day from now
  2. RavenDB 3.5 Whirlwind tour: I need to be free to explore my data - about one day from now
  3. RavenDB 3.5 whirl wind tour: I'll have the 3+1 goodies to go, please - 5 days from now
  4. The design of RavenDB 4.0: Voron has a one track mind - 6 days from now
  5. RavenDB 3.5 whirl wind tour: Digging deep into the internals - 7 days from now

And 12 more posts are pending...

There are posts all the way to May 30, 2016

RECENT SERIES

  1. The design of RavenDB 4.0 (14):
    03 May 2016 - Making Lucene reliable
  2. RavenDB 3.5 whirl wind tour (14):
    04 May 2016 - I’ll find who is taking my I/O bandwidth and they SHALL pay
  3. Tasks for the new comer (2):
    15 Apr 2016 - Quartz.NET with RavenDB
  4. Code through the looking glass (5):
    18 Mar 2016 - And a linear search to rule them
  5. Find the bug (8):
    29 Feb 2016 - When you can't rely on your own identity
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats