Raven’s StorageMemtables are tough
Memtables are conceptually a very simple thing. You have the list of values that you were provided, as well as a skip list for searches.
- Memtables are meant to be used concurrently.
- We are going to have to have to hold all of our values in memory. And I am really not sure that I want to be doing that.
- When we switch between mem tables (and under write conditions, we might be doing that a lot), I want to immediately clear the used memory, not wait for the GC to kick in.
The first thing to do was to port the actual SkipList from the leveldb codebase. That isn’t really hard, but I had to make sure that assumptions made for the C++ memory model are valid for the CLR memory model. In particular, .NET doesn’t have AtomicPointer, but Volatile.Read / Volatile.Write are a good replacement, it seems. I decided to port the one from leveldb because I don’t know what assumptions other list implementations have made. That was the first step in order to create a memtable. The second was to decide where to actually store the data.
Here is the most important method for that part:
public void Add(ulong seq, ItemType type, Slice key, Stream val)
The problem is that we cannot just reference this. We have to copy those values into memory that we control. Why is that? Because the use is free to change the Stream contents or the Slice’s array as soon as we return from this method. By the same token, we can’t just batch this stuff in memory, again, because of the LOH. The way this is handled in leveldb never made much sense to me, so I am going to drastically change that behavior.
In my implementation, I decided to do the following:
- Copy the keys to our own buffer, and keep them inside the skip list. This is what we will use for actually doing searches.
- Change the SkipList to keep track of values, as well as the key.
- Keep the actual values in unmanaged memory, instead of managed memory. That avoid the whole LOH issue, and give me immediate control on when the memory is disposed.
This took some careful coding, because I want to explicitly give up on the GC for this. That means that I need to make damn sure that I don’t have bugs that would generate memory leak.
Each memtable would allocate 4MB of unmanaged memory, and would write the values to it. Note that you can write over 4MB (for example, by writing a very large value, or by writing a value whose length exceed the 4MB limit. At that point, we would allocate more unmanaged memory, and hand over the memory table to compaction.
The whole thing is pretty neat, even if I say so myself .