Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 10 | Comments: 37

filter by tags archive

1st April Post – The multi purpose method

time to read 2 min | 365 words

Since it appears to be customary, I decided that I need to make a few posts for April 1st. Here is the second of them.

public void RemoveReversalsMoveCompletedMessagesAndFinishSubQueueMove(Guid transactionId)
{
    Api.JetSetCurrentIndex(session, txs, "by_tx_id");
    Api.MakeKey(session, txs, transactionId.ToByteArray(), MakeKeyGrbit.NewKey);

    if (Api.TrySeek(session, txs, SeekGrbit.SeekEQ) == false)
        return;
    Api.MakeKey(session, txs, transactionId.ToByteArray(), MakeKeyGrbit.NewKey);
    Api.JetSetIndexRange(session, txs, SetIndexRangeGrbit.RangeInclusive | SetIndexRangeGrbit.RangeUpperLimit);
    
    do
    {
        var queue = Api.RetrieveColumnAsString(session, txs, txsColumns["queue"], Encoding.Unicode);
        var bookmarkData = Api.RetrieveColumn(session, txs, txsColumns["bookmark_data"]);
        var bookmarkSize = Api.RetrieveColumnAsInt32(session, txs, txsColumns["bookmark_size"]).Value;

        var actions = GetQueue(queue);

        var bookmark = new MessageBookmark
        {
            Bookmark = bookmarkData,
            QueueName = queue,
            Size = bookmarkSize
        };

        if (actions.GetMessageStatus(bookmark) == MessageStatus.Processing)
            actions.MoveToHistory(bookmark);
        else
            actions.SetMessageStatus(bookmark, MessageStatus.ReadyToDeliver);

        Api.JetDelete(session, txs);
    } while (Api.TryMoveNext(session, txs));
}

And yes, it is from real code, and it is going to production soon.


Comments

Neal Blomfield

Do you loose a little bit of hope every time you come across code like this (and your previous post)?

What are we doing so wrong that software is continually written so poorly as to make a grown developer cry ( or mumble and rant under his breath)?

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. Production postmortem: The case of the memory eater and high load - about one day from now
  2. Production postmortem: The case of the lying configuration file - 2 days from now
  3. Production postmortem: The industry at large - 3 days from now
  4. The insidious cost of allocations - 4 days from now
  5. Find the bug: The concurrent memory buster - 5 days from now

And 4 more posts are pending...

There are posts all the way to Sep 10, 2015

RECENT SERIES

  1. Find the bug (5):
    20 Apr 2011 - Why do I get a Null Reference Exception?
  2. Production postmortem (10):
    14 Aug 2015 - The case of the man in the middle
  3. What is new in RavenDB 3.5 (7):
    12 Aug 2015 - Monitoring support
  4. Career planning (6):
    24 Jul 2015 - The immortal choices aren't
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats