Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 18 | Comments: 87

filter by tags archive

Reusable tests

time to read 7 min | 1263 words

It is generally accepted that reusability is not something that you should strive for in your tests. However, I have found that reusing tests is an interesting way to save time when you are testing a full process. Take for instance this piece of code:

[Test]

public void SuccessfullySavingTemplateWillShowConfirmation()

{

    OpenNewTemplateDialog();

    Type("TemplateName", "Template1");

    ClickOkOnNewTemplate();

    WaitForAjax();

    AssertTextPresent("Template saved successfully", "Should have gotten a confirmation message");

}

[Test]

public void CannotAddTemplateWithDuplicateName()

{

    //Create a template called "Template1"

    SuccessfullySavingTemplateWillShowConfirmation();

    CloseSavedTemplateSuccessConfirmation();

    OpenNewTemplateDialog();

    Type("TemplateName", "Template1");

    ClickOkOnNewTemplate();

    WaitForAjax();

    AssertTextPresent("There is already a template called 'Template1', please choose another name.",

            "Should warn when trying to create template with duplicate name");

}

Some of the methods are utility methods, but on the second test, the first line of code actually calls to another tests to do the initialization of the test. I can see this kind of stacking useful in cases where I would usually want to have orderred tests.


Comments

Shane Courtrille

While I understand where you're coming from I definitely disagree strongly with how you got there. I personally would be worried about the fact that my one test is now dependent on another test for certain behavior. This of course creates the restriction on the first test that it needs to keep doing what it's doing. Now this is a fairly simple example and you are most likely going to be safe. But if you make a habit of this I'd be amazed if it didn't bite you in the ass over time.

Love the blog btw :)

Ayende Rahien

@Shane,

That is a good argument against it that I have no considered.

I'll give it some more thought.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. Buffer allocation strategies: A possible solution - about one day from now
  2. Buffer allocation strategies: Explaining the solution - 3 days from now
  3. Buffer allocation strategies: Bad usage patterns - 4 days from now
  4. The useless text book algorithms - 5 days from now
  5. Find the bug: The concurrent memory buster - 6 days from now

There are posts all the way to Sep 11, 2015

RECENT SERIES

  1. Find the bug (5):
    20 Apr 2011 - Why do I get a Null Reference Exception?
  2. Production postmortem (10):
    03 Sep 2015 - The industry at large
  3. What is new in RavenDB 3.5 (7):
    12 Aug 2015 - Monitoring support
  4. Career planning (6):
    24 Jul 2015 - The immortal choices aren't
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats