Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 5,953 | Comments: 44,408

filter by tags archive

Reusable tests


It is generally accepted that reusability is not something that you should strive for in your tests. However, I have found that reusing tests is an interesting way to save time when you are testing a full process. Take for instance this piece of code:

[Test]

public void SuccessfullySavingTemplateWillShowConfirmation()

{

    OpenNewTemplateDialog();

    Type("TemplateName", "Template1");

    ClickOkOnNewTemplate();

    WaitForAjax();

    AssertTextPresent("Template saved successfully", "Should have gotten a confirmation message");

}

[Test]

public void CannotAddTemplateWithDuplicateName()

{

    //Create a template called "Template1"

    SuccessfullySavingTemplateWillShowConfirmation();

    CloseSavedTemplateSuccessConfirmation();

    OpenNewTemplateDialog();

    Type("TemplateName", "Template1");

    ClickOkOnNewTemplate();

    WaitForAjax();

    AssertTextPresent("There is already a template called 'Template1', please choose another name.",

            "Should warn when trying to create template with duplicate name");

}

Some of the methods are utility methods, but on the second test, the first line of code actually calls to another tests to do the initialization of the test. I can see this kind of stacking useful in cases where I would usually want to have orderred tests.


Comments

Shane Courtrille

While I understand where you're coming from I definitely disagree strongly with how you got there. I personally would be worried about the fact that my one test is now dependent on another test for certain behavior. This of course creates the restriction on the first test that it needs to keep doing what it's doing. Now this is a fairly simple example and you are most likely going to be safe. But if you make a habit of this I'd be amazed if it didn't bite you in the ass over time.

Love the blog btw :)

Ayende Rahien

@Shane,

That is a good argument against it that I have no considered.

I'll give it some more thought.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

No future posts left, oh my!

RECENT SERIES

  1. The RavenDB Comic Strip (3):
    28 May 2015 - Part III – High availability & sleeping soundly
  2. Special Offer (2):
    27 May 2015 - 29% discount for all our products
  3. RavenDB Sharding (3):
    22 May 2015 - Adding a new shard to an existing cluster, splitting the shard
  4. Challenge (45):
    28 Apr 2015 - What is the meaning of this change?
  5. Interview question (2):
    30 Mar 2015 - fix the index
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats