Ayende @ Rahien

My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:


+972 52-548-6969

, @ Q c

Posts: 10 | Comments: 37

filter by tags archive

A pull request with all of the taxes already paid, gimme that again!

time to read 1 min | 122 words

I recently merged a pull request from Barry Hagan. The actual pull request is pretty boring, to tell you the truth, exposing a Lucene feature through the RavenDB API.

What really impressed me was how complete the pull request was.

What do I mean by complete?

A feature is not just supporting it in the engine. For this particular pull request, Barry have done:

  • Supported this in RavenDB Database Core.
  • The HTTP API.
  • The C# Client API.
  • The strongly typed C# Client API.
  • Included support for dynamic indexes.
  • Updated the query optimizer.
  • Exposed this feature in the UI.

Basically, the only things that I had to do were git pull and then review the code.

Very nicely done.



How does that work? People pay for RavenDB and still add features to it? And then have to pay for those features? I don't understand.

Ayende Rahien

Jiggaboo, This probably explains this best: http://twitter.com/randompunter/status/303499429313392642


But when it comes to new features why not add it in you own solution and sell? You sir may have found ideal business! :)

Ayende Rahien

Jiggaboo, Because a new feature on its own is pretty useless. It is the aggregation that make things useful

Tim Murphy

What about some tests to make it the perfect pull request :-)

Daniel Schilling

Looks to me like tests were included. Way to go, man!


Nobody dares to send you a sloppy pull request. I wouldn't be surprised if some significant amount of work was put in that pull request, just to meet your standards :)

Comment preview

Comments have been closed on this topic.


  1. Production postmortem: The case of the memory eater and high load - about one day from now
  2. Production postmortem: The case of the lying configuration file - 3 days from now
  3. Production postmortem: The industry at large - 4 days from now
  4. The insidious cost of allocations - 5 days from now
  5. Find the bug: The concurrent memory buster - 6 days from now

And 4 more posts are pending...

There are posts all the way to Sep 10, 2015


  1. Find the bug (5):
    20 Apr 2011 - Why do I get a Null Reference Exception?
  2. Production postmortem (10):
    14 Aug 2015 - The case of the man in the middle
  3. What is new in RavenDB 3.5 (7):
    12 Aug 2015 - Monitoring support
  4. Career planning (6):
    24 Jul 2015 - The immortal choices aren't
View all series


Main feed Feed Stats
Comments feed   Comments Feed Stats