Ayende @ Rahienhttp://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Jay R. Wren commented on An elegant ThreadLocal for SilverlightMy only thought was "be glad you have ConditionalWeakTable" I'd hate (or I'd like to see it, but I'd hate the added complexity) to see how you would have to do this in SL3 without CWThttp://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment13http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment13Sun, 22 May 2011 16:30:26 GMTSimone commented on An elegant ThreadLocal for Silverlight@Jon, I'd guess because you want the lifecycle of the Value to be tied to that of the TL instance, thus GCed when the TL instance is GCed but not earlier. http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment12http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment12Sat, 30 Apr 2011 01:08:21 GMTJon Wingfield commented on An elegant ThreadLocal for SilverlightI don't get why you're not using a weak reference instead of the table. Not in silverlight either? http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment11http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment11Sat, 30 Apr 2011 00:02:23 GMTSimone commented on An elegant ThreadLocal for SilverlightHi Oren, very nice solution. I think this might be an excellent TDD excercise, do you have any tests that cover your implementation you can share to create a sort of kata on top of them? http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment10http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment10Thu, 28 Apr 2011 21:16:34 GMTDuarte Nunes commented on An elegant ThreadLocal for SilverlightOops, the ConditionalWeakTable _is_ ThreadStatic. Nevermind my earlier post. http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment9http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment9Thu, 28 Apr 2011 10:33:14 GMTDuarte Nunes commented on An elegant ThreadLocal for SilverlightHm, let me try again: it's ConditionalWeakTable<Thread, Holder>. http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment8http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment8Thu, 28 Apr 2011 10:22:04 GMTDuarte Nunes commented on An elegant ThreadLocal for SilverlightThere's a disadvantage: if you have N threads using the ThreadLocal instance, and N-1 thread exit, then the values that they created will only be GCed when the Nth thread exits. Since ConditionalWeakTable is already thread-safe, I would have: private ConditionalWeakTable <thread,> _state; and index with Thread.CurrentThread. http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment7http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment7Thu, 28 Apr 2011 10:16:24 GMTconfigurator commented on An elegant ThreadLocal for SilverlightD'oh, I forgot that this is static... Been using ThreadLocal for too long! http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment6http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment6Thu, 28 Apr 2011 09:49:32 GMTAyende Rahien commented on An elegant ThreadLocal for SilverlightConfigurator, a) it won't be thread static? b) it won't ever get cleaned up? http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment5http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment5Thu, 28 Apr 2011 09:49:10 GMTconfigurator commented on An elegant ThreadLocal for SilverlightWhat's wrong with private static Holder _state; ? http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment4http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment4Thu, 28 Apr 2011 09:48:31 GMTPatrick Huizinga commented on An elegant ThreadLocal for Silverlight@configurator Because when a ThreadLocal instance is GCed, you want the value to be cleaned up with it. And since garbage collection is likely on a separate thread, you can't use the finalizer. http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment3http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment3Thu, 28 Apr 2011 09:47:02 GMTAyende Rahien commented on An elegant ThreadLocal for SilverlightConfigurator, Try putting anything else in its place http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment2http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment2Thu, 28 Apr 2011 09:45:37 GMTconfigurator commented on An elegant ThreadLocal for SilverlightWhy do you need the ConditionalWeakTable here though? http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment1http://ayende.com/4825/an-elegant-threadlocal-for-silverlight#comment1Thu, 28 Apr 2011 09:44:05 GMT