Ayende @ Rahien

Harry M commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Tue, 12 Apr 2011 12:49:56 GMT

@Scooletz i was thinking of the situation that you are calling an action that doesn't hit the database, but there are actions on the controller that do. With the lazy Func

Patrick Smacchia commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Tue, 12 Apr 2011 08:58:30 GMT

>While I don’t really mind having global state, it tends to bite you on the ass eventually, It always does bite afterthought IMHO

Dmitry commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Tue, 12 Apr 2011 04:10:21 GMT

Maybe DI is not cool anymore @ ALT .NET.

Nick Sergeev commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 17:40:43 GMT

Why we can't simply inject session directly to constructor? What the point of custom filter?

Scooletz commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 11:31:37 GMT

@Harry M It should end with an ISession injected right to a controller constructor (or the action itself :>). No current resolver needed.

Guillaume commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 09:33:56 GMT

Have you considered using a custom "ActionInvoker" in your controller instead ?

Harry M commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 09:31:30 GMT

Is this series going to end up with a constuctor injected (Func

Scooletz commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 09:18:35 GMT

Yeah, the session factory is hold in a static field, so it's singleton, but it cannot be used anywhere else (for instance if I need StatelessSession or evicition of some cache regions). It should be a singleton in a container.

Scooletz commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 09:16:27 GMT

Yes: - the session is injected via a property, constructor is much nicer. - the session factory is hold in a filter and I don't know if the filter is instantiated once per application (it should)

Paul Stovell commented on Refactoring toward frictionless & odorless code: Getting rid of globals

Mon, 11 Apr 2011 09:16:26 GMT

The attribute should probably create/commit a transaction too.