http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660I'm not a fan of singletons (well not container managed) and especially the infamous HttpContext.Current property but this is one place where when it does make sense to go down that route to leverage MSR Moles for testing purposes. Again, I usually try to design around that but there's times when it's just the best approach when complexity vs "purity" is balanced out in a solution. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment20http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment20Thu, 07 Apr 2011 18:36:30 GMTA IoC container is the way to go. That's all about this code http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment19http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment19Thu, 07 Apr 2011 10:03:42 GMTThanks, I just found your blog entry on the cost of opening a Session: [ayende.com/.../...e-cost-of-opening-a-session.aspx](http://ayende.com/Blog/archive/2009/08/16/what-is-the-cost-of-opening-a-session.aspx)http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment18http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment18Thu, 07 Apr 2011 09:53:03 GMTThere is no cost for opening a new NH session. And yes, you always want a session available, see my previous posts about why I dislike the repo pattern http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment17http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment17Thu, 07 Apr 2011 09:34:50 GMTIt's nice and simple. I have two comments though. In MVC 2, at least, we get a BeginRequest for every static resource, including images, Javascript, and CSS files. Maybe there is little overhead to opening an NH Session and I could be being excessively defensive, but I wrote a routine to check that we were processing an ASP request before I did anything like authenticating the user or opening an ISession. Secondly, do you always need an ISession? I prefer to use a simple 'repository' that opens the session on demand and uses NH CurrentSessionContext. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment16http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment16Thu, 07 Apr 2011 09:31:24 GMTAdam, In general, yes, a single session for the entire request is the way to go. As for replacing this. Please wait, we have much better coming up http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment15http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment15Thu, 07 Apr 2011 08:30:47 GMTI like it, but I was using the castle nhibernate facility and replacting that with this broke my app. Some requests used multiple sessions if certain filters were being invoked. Do you think that's actually a problem with *my* code? Should *all* requests come under one session? http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment14http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment14Thu, 07 Apr 2011 07:52:49 GMTGenerally I prefer taking a direct dependency on ISession rather than using some sort of "CurrentSession" accessor. Easy enough to set up ISession as a service in Windsor, at least, with a PerWebRequest scope. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment13http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment13Thu, 07 Apr 2011 05:49:24 GMTThere might be some overhead if running that in Cassini, which runs every request (including static content) through asp.net. I expect to see a lazy loaded UnitOfWork in the next post :) http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment12http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment12Wed, 06 Apr 2011 21:31:14 GMTCurious to see the upcoming series. I use code a lot like this in my MS MVC3 app(s). http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment11http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment11Wed, 06 Apr 2011 16:38:08 GMTYou are crazy idiot. This code is holy shit! http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment10http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment10Wed, 06 Apr 2011 16:04:50 GMTAs you say, It's really not bad at all, but you can definitely tuck some of the noise away by using a global action filter and your own base controller to manage your ISession. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment9http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment9Wed, 06 Apr 2011 15:30:34 GMTRyan, Relevance for the post? There are ways to handle that, based on however you determine which tenant you are in, but it isn't relevant for this scenario http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment8http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment8Wed, 06 Apr 2011 14:46:42 GMTCan't wait for the rest of this series. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment7http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment7Wed, 06 Apr 2011 14:46:16 GMTIn the case of a RavenDB session object, how could you provide a database name to the call to OpenSessoin() in BeginRequest ? http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment6http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment6Wed, 06 Apr 2011 14:43:50 GMTIs there much of an overhead opening a session for every request that hits the application - feels a little excessive. Would it not be better to place an filter attribute on the controller to restrict the creation of sessions to only requests that require it? http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment5http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment5Wed, 06 Apr 2011 14:36:27 GMTIn other words Open Session in View (OSIV). The next step I assume will be to configure NHibernate to use web session scope? http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment4http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment4Wed, 06 Apr 2011 14:02:11 GMTI'm very interested to see what you recommend. With your recent rantings on the demise of the Repository pattern, I looked at your code samples. The only things I could find were client projects, which require rather different architectures than web. MVC3 + NHibernate3 is an excellent combo. http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment3http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment3Wed, 06 Apr 2011 13:55:43 GMTWait for the whole series http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment2http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment2Wed, 06 Apr 2011 10:48:28 GMTIs this code still unit-testable? HttpContext and the static seems to be a problem if you try to write a test for the controller action. How do you solve this? Thanks, Robert http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment1http://ayende.com/4803/refactoring-toward-frictionless-odorless-code-the-baseline#comment1Wed, 06 Apr 2011 10:26:21 GMT