Ayende @ Rahienhttp://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Rian Schmits commented on Tales from a code review gone wrongI have been struggling with implementing Equals/GetHashCode, especially when lazy-loaded properties are part of an object's identity. Because then every time Equals or GetHashCode gets called those properties get lazy-loaded. I have posted a question about this on stackoverflow, but haven't yet received an answer that satisfies me 100%. [http://stackoverflow.com/q/5002670/104750](http://stackoverflow.com/q/5002670/104750)http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment9http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment9Sat, 26 Feb 2011 15:42:45 GMTRob Levine commented on Tales from a code review gone wrongProvided .Equals is implemented by calling down to the base, then this is fine :-D http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment8http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment8Fri, 25 Feb 2011 10:01:31 GMTAlex Simkin commented on Tales from a code review gone wrong@Juan Lopes You are right, S#arp Architecture's BaseObject class implements general purpose GetHashCode. [sharp-architecture.googlecode.com/.../BaseObjec...](http://sharp-architecture.googlecode.com/svn/trunk/src/SharpArch/SharpArch.Core/DomainModel/BaseObject.cs)http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment7http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment7Thu, 24 Feb 2011 22:09:39 GMTamiralles commented on Tales from a code review gone wrongA really good one ;-) http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment6http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment6Thu, 24 Feb 2011 22:01:24 GMTPiet commented on Tales from a code review gone wrongSo is the documentation wrong or the implementer? http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment5http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment5Thu, 24 Feb 2011 18:09:38 GMTJuan Lopes commented on Tales from a code review gone wrongEven if the base class (e.g. BaseEntity) has a valid logic for calculating GetHashCode based on all identifier properties, NHibernate will complain if the inherited class doesn't implement it. If you're using composite ids, you're oblitaded to do so. That being said, this code may not be so wrong. http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment4http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment4Thu, 24 Feb 2011 16:49:38 GMTPatrick Smacchia commented on Tales from a code review gone wrongR# would have catch it automatically, and would have shown this code grayed in the VS code editor wnd http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment3http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment3Thu, 24 Feb 2011 15:08:32 GMTjdn commented on Tales from a code review gone wrongYeah, it's missing the number 397 in it. http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment2http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment2Thu, 24 Feb 2011 14:26:17 GMTDave Mertens commented on Tales from a code review gone wrongThis one is a classic. It's also a showcase why code c.q. peer reviews are so important. You catch 'errors' you won't catch with a unit test.. http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment1http://ayende.com/4772/tales-from-a-code-review-gone-wrong#comment1Thu, 24 Feb 2011 10:19:34 GMT