Ayende @ Rahien

Ayende Rahien commented on RavenDB – The great simplification

Tue, 19 Oct 2010 15:19:22 GMT

Frans, Yes, it is something that the user would need to do, but I think that this is an acceptable pain consider the work required and the benefits given from that.

Frans Bouma commented on RavenDB – The great simplification

Tue, 19 Oct 2010 08:40:26 GMT

I meant: for the user of RavenDB: their code using the session with all the methods now has to be refactored all of a sudden when they use a later build. (not sure if that's a given / expected anyway)

Ayende Rahien commented on RavenDB – The great simplification

Mon, 18 Oct 2010 18:00:53 GMT

Frans, Yes, it does breaks everything. BUT, this isn't a problem for me right now, because the change is minor in terms of the code changes required.

Frans Bouma commented on RavenDB – The great simplification

Mon, 18 Oct 2010 14:28:13 GMT

Clever :) I wonder how you can pull this off with released code out there already? Wouldn't this change break everything?

Ayende Rahien commented on RavenDB – The great simplification

Sun, 17 Oct 2010 10:04:56 GMT

Alex, You already _can_ access all the methods.

Ayende Rahien commented on RavenDB – The great simplification

Sun, 17 Oct 2010 10:00:29 GMT

Cory, I agree that we could do it using different interfaces, sure. But the var keyword exists, and widely used.

Alex Vilela commented on RavenDB – The great simplification

Sun, 17 Oct 2010 09:58:34 GMT

Very interesting idea, thanks. Would you expect a scenario where you would like to have an advancedSession instance and want to have access to all methods?

addy santo commented on RavenDB – The great simplification

Sun, 17 Oct 2010 07:18:11 GMT

Matt: the idea was to use the attribute to hide the Equals, GetHashCode, GetType, ToString which are irrelevant in that context. For example, [www.clariusconsulting.net/.../58301.aspx](http://www.clariusconsulting.net/blogs/kzu/archive/2008/03/10/58301.aspx)

Cory Foy commented on RavenDB – The great simplification

Sun, 17 Oct 2010 00:15:00 GMT

@Matt - Actually, you can use that to specify "Advanced" properties which are only shown if you check the "Show Advanced Members" option for Intellisense. Not that I'd recommend it. @Ayende - I'm unsure about this. I mean, I love the simplification effort. But having Advanced as an option seems not right. Seems like that's only a problem because we are using the var keyword, so we can't be specific to Intellisense. For example, if you simply had the class implement both Interfaces, and you were being intentional in the code, you'd get something like: IDocumentSession session = //whatever So when I typed session

Matt Warren commented on RavenDB – The great simplification

Sat, 16 Oct 2010 22:47:21 GMT

Addy: if you use that attribute you won't see the method at all. The technique outlined in the post just "hides" the methods that aren't applicable for most users by making them type "session.Advanced" before they can see all the rest of the functions.

addy santo commented on RavenDB – The great simplification

Sat, 16 Oct 2010 18:10:45 GMT

I'll just leave this here and see what happens: EditorBrowsableAttribute, [msdn.microsoft.com/.../...rbrowsableattribute.aspx](http://msdn.microsoft.com/en-us/library/system.componentmodel.editorbrowsableattribute.aspx)

tobi commented on RavenDB – The great simplification

Sat, 16 Oct 2010 16:09:50 GMT

Good technique. Few people know how to design APIs these days.