http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Dave, See my blog for previous code reviews that touched on that. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment15http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment15Sat, 31 Jul 2010 09:18:20 GMTWhat is the problem with the account service? Is it just too complicated? The way I see it, it is necessary to implement them as a service so that they can be mocked later. I suppose though, you will probably not be unit testing the controllers directly and in isolation since they have to inherit from the base asp.net controller class. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment14http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment14Sat, 31 Jul 2010 07:36:11 GMTThat is true. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment13http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment13Thu, 29 Jul 2010 12:19:40 GMTTobi, The problem is that you'll have to go to the server multiple times. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment12http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment12Thu, 29 Jul 2010 11:15:32 GMTI don't thinks so because the indexes are materialized (as I understood it). Reading from them should be cheap. The difference is just that the indexes are maintained automatically at write time instead of manually at write time. Am I correct with this? http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment11http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment11Thu, 29 Jul 2010 11:10:06 GMTTobi, The problem is that you shift the burden to the read time, rather than the write time. That make it more expensive to work with. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment10http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment10Thu, 29 Jul 2010 07:04:43 GMTJust curious, LogOff action's httpmethod should be POST or GET? http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment9http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment9Thu, 29 Jul 2010 03:10:14 GMTI would try to store the very most of the data normalized and define indexes en masse. That would save the development effort of maintaining the denormalized documents and seemingly has no disadvantages. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment8http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment8Wed, 28 Jul 2010 19:31:23 GMTNever mind. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment7http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment7Wed, 28 Jul 2010 15:59:12 GMTStill no luck - first 5 indexes are OK, but then: {"{\r\n \"Url\": \"//indexes/AllStudents\",\r\n \"Error\": \"System.InvalidOperationException: Could not understand query: \\r\\n-- line 3 col 9: \\\")\\\" expected\\r\\n\\r\\n at Raven.Database.Linq.QueryParsingUtils.GetVariableDeclarationForLinqMethods(String query)\\r\\n at Raven.Database.Linq.DynamicViewCompiler.TransformMapDefinitionFromLinqMethodSyntax(String& entityName)\\r\\n ... http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment6http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment6Wed, 28 Jul 2010 15:55:15 GMTUncomment the CreateIndexes in the Global.asax http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment5http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment5Wed, 28 Jul 2010 15:41:57 GMTHow to initialize the database in this application? All am getting after login is "There is no index named: AllPeople". http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment4http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment4Wed, 28 Jul 2010 14:47:23 GMTIt would be great if the original sample could be updated integrating Ayende's comments. I am thinking of what Ayende said about the embedded references in the sample model (among other things). Ayende, in an upcoming post, could you inform us of the availability of the updated community course sample? Thanks a lot :) http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment3http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment3Wed, 28 Jul 2010 12:45:23 GMT@Martin yes, you would have to update all the other roots which contain the denormalized data. Raven does support set operations Good read :) some nice ideas in the original code and your suggestions for making improvements. http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment2http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment2Wed, 28 Jul 2010 10:18:06 GMT"Instead of pulling all of this data at read time (very expensive), we are going to denormalize the data at write time, leading to a document that looks like this" (haven't used RavenDB yet, so sorry if this is a stupid question) How do you handle updates of the denormalized data in that case? E.g. in the above example, if the person's name changes, would you have to update all documents which contain this (denormalized) data? http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment1http://ayende.com/4564/reviewing-communitycourses-a-ravendb-application#comment1Wed, 28 Jul 2010 10:09:44 GMT