Ayende @ Rahien

Martin R-L commented on Find the design flaw

Thu, 17 Jun 2010 06:27:46 GMT

@Patrik, What I do in order to use the ease of tuples and other complex generic types, *and* get readable code, is to at least give them a friendly name by utilizing the using statement of C#. An example is given on my blog: [http://goo.gl/ksCm](http://goo.gl/ksCm) In a specific context, you can also give the type friendly method names (like e.g. Ruby's alias methods) by using extension methods that are just simple pass-throughs.

Dmitriy Nagirnyak commented on Find the design flaw

Sun, 23 May 2010 23:56:58 GMT

When using 'yield' the resulting items will be returned 'lazily' (delayed execution). This might not be what the method is intended to do. I think the intention is to have the results ready after the call. It also might have potential issue when the underlying data store is closed and the enumeration gets executed. Cheers, Dmitriy,

Andrew commented on Find the design flaw

Sat, 22 May 2010 10:19:13 GMT

Yeah now that I've thought it through, I'm unsure why I even said that. I read something like this on someone's blog recently and haven't had time to process it.

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 10:03:46 GMT

Andrew, I disagree with that quite strongly

Andrew commented on Find the design flaw

Sat, 22 May 2010 09:56:26 GMT

Is it not also bad practice to publicly expose IEnumerable for methods like this ?

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 09:54:44 GMT

Patrik, This is mostly for internal API needs, it just doesn't make sense to create a type here, it wouldn't add enough meaning

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 09:54:03 GMT

James, Yes, the collection may not be continuous

James Newton-King commented on Find the design flaw

Sat, 22 May 2010 09:42:25 GMT

Is the collection between the startId and endId not continuous? A limit would make sense then.

Patrik commented on Find the design flaw

Sat, 22 May 2010 09:38:38 GMT

This might be personal preference but I _really_ don't like methods exposing tuple types. Create a type (possibly a struct) that has carries some semantics instead of the tuple. Note that this in C#, this would obviously not be my thoughts if the language was F#, Haskell, Erlang or any other functional language.

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 08:58:16 GMT

Chojrak, It isn't key value. It is a tuple, it isn't a set of int to json doc, it is a int & json doc.

Chojrak commented on Find the design flaw

Sat, 22 May 2010 08:56:49 GMT

Oh no, damned HTML. Again: I'd change it to IEnumerable> I think key-value dependencies are better handled using Dictionary. Any ideas?

Chojrak commented on Find the design flaw

Sat, 22 May 2010 08:55:25 GMT

I'd change it to IEnumerable >, I think key-value dependencies are better handled using Dictionary. Any ideas? >

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 08:41:12 GMT

James, startId: 1 endId: 100000 limit: 100

Ayende Rahien commented on Find the design flaw

Sat, 22 May 2010 08:40:52 GMT

Ashic, Yep!

James Newton-King commented on Find the design flaw

Sat, 22 May 2010 07:44:08 GMT

An endId and limit seem at odds with one another.

ashic commented on Find the design flaw

Sat, 22 May 2010 07:34:22 GMT

It's returning an IEnumerable using yield. The caller would take out the ones they need. There's no sense in passing parameters like limit as it would the the callers' responsibility to get only the number they need. IEnumerable won't trigger data access until and unless the data is required and so the limit parameter doesn't have any use.