Ayende @ Rahien

alwin commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 14:33:37 GMT

@Tommy Carlier, Well of course it's all just a matter of personal taste. For me a string has a value if it has something in it, and yes, spaces are a value too. I have this: public static bool IsNullOrEmpty(this string self) { return string.IsNullOrEmpty(self); } public static bool HasValue(this string self) { return !IsNullOrEmpty(self); } With HasValue I have one less negation wrt Is*Not*Empty, or *!*IsNullOrEmpty.

Tommy Carlier commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 13:42:57 GMT

@alwin I think that "empty" and "not empty" is clearly defined in relation to strings, while "value" is not as clearly defined: what is considered a value?

firefly commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 05:01:37 GMT

I think Oren just need another vacation :)

Try It commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 01:39:46 GMT

@Paul Batum I need to man up Paul. I owe you a great big apology, once I wipe the egg from my face. You're quite right. I was thinking how assigning with constants on the left upsets the compiler. I'll crawl back under my rock now with your permission.

Try It commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 00:50:03 GMT

@Paul Batum Do it, then come back and let us know what your experience is. I think you'll find it errors out quite nicely thank you.

Paul Batum commented on Sometimes I have code blinders on

Sat, 06 Mar 2010 00:40:24 GMT

@Mr_Simple Sure, its better if you're using a language like C, because if you accidentally use '=' instead of '==' then you'll get a compile error. But C# doesn't have this problem, so I'm not sure what "stupid bugs" you're thinking it prevents.

alwin commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 18:29:07 GMT

@Tommy Carlier, Why not string.HasValue() ? instead of IsNotEmpty()

Mr_Simple commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 15:15:14 GMT

@Grimace false == is even better. Saves time running after stupid bugs.

Jason Meckley commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 14:34:37 GMT

It's not that apparent to me either. I think it's that index will be null if TryGetValue returns false. in which case you either need to return after logging or put value.IndexDocuments in an else block.

Tommy Carlier commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 14:31:33 GMT

Actually, now that I think about it: I sometimes create 2 versions of a method: the regular one and the "not"-one. Some extension methods I wrote: - ICollection 0 - ICollection

Tommy Carlier commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 14:27:04 GMT

@Patrick I also use the exclamation mark, but I also think it's not always very obvious (only 1 character that looks like a letter). I'd actually prefer a "not"-keyword here, like in VB. Maybe the "condition == false" wouldn't be as easy to overlook if you turned it around (like they do in C++ for a different reason): if (false == condition) { ... }

Patrik Hägne commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:57:30 GMT

I'm totally with Matt on this one, the (condition == false) is BAD practice. It's SOOOO much easier to overlook than the exclamation mark. The exclamation mark adds the negation beforehand so that you know that you are negating the statement when you read it. I feel you on the bug though, been there, done that and in the end it's always like DUH!

Dmitry commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:45:22 GMT

There should be a "return" statement after log.Debug().

Demis Bellot commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:42:50 GMT

Yeah we've all been there, usually a good time for a break.

Grimace commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:35:11 GMT

@Matt I actually picked up that code style from Ayende. Shorter does not always mean more readable and an exclamation mark is easily overlooked. I used to apply the exclamation mark, but after trying the "== false" for a while, I'm sold.

Markus Zywitza commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:11:48 GMT

This is serious. It means that even you cannot code 20 hours a day for more than four weeks... ;-)

Matt commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 13:10:12 GMT

I'd be more ashamed of the if (condition == false) bit..

efdee commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 12:28:07 GMT

What Tommy Carlier said. You forgot 'return' when the TryGetValue fails :-)

daniel commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 11:59:17 GMT

nothing like another pair of eyes at times like that.

Brad commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 11:08:39 GMT

log is null?

Dirk commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:57:35 GMT

I think this post was not about "find the bug"! It's about "We all are humans..." ;-)

Lodewijk commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:32:57 GMT

String.Format fails because 'index' is null.

Tommy Carlier commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:22:39 GMT

Even if TryGetValue fails (and value is null), the last statement is still executed. Missing an else.

anon commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:16:40 GMT

index can be null. indexes can be null. value can be null. Simple.

James McKay commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:13:51 GMT

Um...so, the intention is that when you try to index on a non-existent index it should fail silently? That being the case I'd call the method TryIndex rather than Index and have it return a Boolean to indicate failure. If a method can't do what its name says it does, it should always throw.

Ian Nelson commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:12:12 GMT

OK, try again Ian: index parameter is null in rare cases, TryGetValue returns false in this case, and log.DebugFormat throws NullReferenceException ?

FallenGameR commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:12:11 GMT

Ayende, why have you stoped using HTML highlighting? Not it's only images for code.

Benny Thomas commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:11:43 GMT

Been there, done that! :-)

neonp commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:11:09 GMT

value maybe null if trygetvalue fails. So you have a NullReferenceException when call value.IndexDocuments(...)

Ian Nelson commented on Sometimes I have code blinders on

Fri, 05 Mar 2010 10:10:14 GMT

Oops, I'm blind too, just realised that "value" is the out parameter :-$