http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Ayende, Yes, I'm absolutely agree with you about enumerables if you can control event args, but events are different and even one sensible parameter, say on KeyDown event, would require to add handling method, if we need to look at the key pressed. What I have to do is ... WireEvents(instance); WireEventsWithParameter(instance); in Presenters and implement that method in similar manner. Thank you! http://ayende.com/4332/effectus-fatten-your-infrastructure#comment17http://ayende.com/4332/effectus-fatten-your-infrastructure#comment17Tue, 22 Dec 2009 11:31:19 GMTBrainboost, I am afraid that I am not sure that I am following you. If I need N parameters, I am going to have a method with an enumerable parameter http://ayende.com/4332/effectus-fatten-your-infrastructure#comment16http://ayende.com/4332/effectus-fatten-your-infrastructure#comment16Tue, 22 Dec 2009 07:25:32 GMTKevin, I can, but it is: a) too hard to do for something this trivial. b) don't assume that the observable is the source of the calculation, it is just the trigger for it. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment15http://ayende.com/4332/effectus-fatten-your-infrastructure#comment15Tue, 22 Dec 2009 07:24:14 GMTBrendan, A lot of the things in the source code would transfer to a service based model, yes. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment14http://ayende.com/4332/effectus-fatten-your-infrastructure#comment14Tue, 22 Dec 2009 07:23:33 GMTNick, The logic that you use isn't necessarily based on the observable, you only need to run it after the observable have run. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment13http://ayende.com/4332/effectus-fatten-your-infrastructure#comment13Tue, 22 Dec 2009 07:22:46 GMTFirefly, I would add a validation library, hook it into the DataBindingFactory and have the infrastructure automatically catch ValidationException and show them in the UI in the appropriate manner. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment12http://ayende.com/4332/effectus-fatten-your-infrastructure#comment12Tue, 22 Dec 2009 07:21:57 GMTVadi, Why would it fail? I tested it with both, so I am pretty sure it wouldn't http://ayende.com/4332/effectus-fatten-your-infrastructure#comment11http://ayende.com/4332/effectus-fatten-your-infrastructure#comment11Tue, 22 Dec 2009 07:21:13 GMTNice concept, first of all. Ok, binding to parameterless events is as easy as elegant but what about 2, 3 and more parameters in events? Are we need to put a method in the Presenters for any parameter case? Played with code, it fits not only WPF but WinForms apps as well, but then you need some presenter modifications. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment10http://ayende.com/4332/effectus-fatten-your-infrastructure#comment10Sun, 20 Dec 2009 22:37:28 GMTOuch. Forget prev comment. I didn't know it behaves differently in WinForms and WPF apps. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment9http://ayende.com/4332/effectus-fatten-your-infrastructure#comment9Sun, 20 Dec 2009 21:51:24 GMTWhy BackgroundWorker in Effectus.Features.CreateNew calls CompleteSave in thу UI thread? I tested in console App, RunWorkerCompleted runs in a new thread: private static void Print( string info ) { Console.WriteLine( "{0}: {1}", Thread.CurrentThread.GetHashCode(), info ); } private static void Main( ) { Print( "Main thread" ); var bw = new BackgroundWorker( ); bw.DoWork += (sender, args) => Print( "Do work thread" ); bw.RunWorkerCompleted += (sender, args) => Print( "Completed thread" ); bw.RunWorkerAsync( ); Thread.Sleep( 500 ); Print( "Press Enter to exit" ); Console.ReadLine( ); } http://ayende.com/4332/effectus-fatten-your-infrastructure#comment8http://ayende.com/4332/effectus-fatten-your-infrastructure#comment8Sun, 20 Dec 2009 21:48:00 GMTCan't you pull the identity of the Observable directly out of the expression tree, instead of having to specify it twice? That would also allow you to handle expressions that contain multiple Observables. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment7http://ayende.com/4332/effectus-fatten-your-infrastructure#comment7Sun, 20 Dec 2009 17:13:34 GMTI haven't had the chance to look into Effectus but it is on my list of things to do over the holidays. Typically any windows applications that I develop are client server based and running through a web service, Effectus looks to go straight to the database from what I have read. Is there any way you could maybe extend Effectus to work over services? It would be a great help to a lot of people and I would be very grateful. Thanks again for another insight into best practice with NHibernate... http://ayende.com/4332/effectus-fatten-your-infrastructure#comment6http://ayende.com/4332/effectus-fatten-your-infrastructure#comment6Sun, 20 Dec 2009 17:01:37 GMTAny reason not to pass the observable (or perhaps just the current value) to the fact like this: return new Fact(CurrentPage, x => x > 0); Decouples the Fact from the class a little, and should be easier to test the fact in isolation, right? -Nick http://ayende.com/4332/effectus-fatten-your-infrastructure#comment5http://ayende.com/4332/effectus-fatten-your-infrastructure#comment5Sun, 20 Dec 2009 15:53:41 GMTCurrently there is no validation logic for the save, which mean if the user enter no data the save will fail. So if I have the pleasure of picking your brain, may I ask where would you put such logic and why? http://ayende.com/4332/effectus-fatten-your-infrastructure#comment4http://ayende.com/4332/effectus-fatten-your-infrastructure#comment4Sun, 20 Dec 2009 15:27:38 GMTSorry for changing the context of this discussion .. looks like the code may fail when CurrentPage is MaxPage or CurrentPage is 0, I am referring to OnMovePrev and OnMoveNext http://ayende.com/4332/effectus-fatten-your-infrastructure#comment3http://ayende.com/4332/effectus-fatten-your-infrastructure#comment3Sun, 20 Dec 2009 14:43:30 GMTI am looking forward to the rest of the blog posts on Effectus. It deserves a lot more wordings than just the MSDN article. The article seems to be an overview only and much of the details didn't have an chance to delve into. It will be much better to explore section by section on the design decisions as well as the implementation details. It will be especially educational for people like me. Nowadays you need to know everything in order to do one thing great. Thanks. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment2http://ayende.com/4332/effectus-fatten-your-infrastructure#comment2Sun, 20 Dec 2009 12:11:40 GMTI am looking forward to the rest of the blog posts on Effectus. It deserves a lot more wordings than just the MSDN article. MSDN article seems to be an overview only and a lot of the details didn't have a chance to delve into. It will be extremely good to explore section by section on the reasons behind each design decision and implementation details. Thanks. http://ayende.com/4332/effectus-fatten-your-infrastructure#comment1http://ayende.com/4332/effectus-fatten-your-infrastructure#comment1Sun, 20 Dec 2009 12:08:16 GMT