http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Chris, YES! http://ayende.com/4267/write-the-checkin-comment-part-ii#comment21http://ayende.com/4267/write-the-checkin-comment-part-ii#comment21Mon, 26 Oct 2009 23:48:24 GMTI would say there are two main parts to this, the first having already been mentioned and that is a service does not have a console to write the error message to. The second is when running as a service re-throw the exception so that the service manager knows the app did not terminate correctly, when running from the command line you do not wish to re-throw the exception as it will cause the Microsoft error reporting dialog to show. Though it is traditional when running from the command line, on an error to have a non-zero exit code. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment20http://ayende.com/4267/write-the-checkin-comment-part-ii#comment20Mon, 26 Oct 2009 22:18:19 GMTClearly what the code is doing is writing the exception to the logger, rather than to the console. I'd venture that the *purpose* is to decouple your code from the command line, or to make your code more suitable for a class library/server, rather than a console app. But this seems too obvious, so maybe I'm missing something..? http://ayende.com/4267/write-the-checkin-comment-part-ii#comment19http://ayende.com/4267/write-the-checkin-comment-part-ii#comment19Mon, 26 Oct 2009 20:19:15 GMTThe inclusion of "log4net" is a simple change in that it is nothing more than a progression in development (e.g. the next step) the "executionOptions.Action == Action.Server" is the more important change that indicates the "Host" program can now run as a Client or as a Server http://ayende.com/4267/write-the-checkin-comment-part-ii#comment18http://ayende.com/4267/write-the-checkin-comment-part-ii#comment18Mon, 26 Oct 2009 17:33:51 GMT@Thilak Nathen - That's diff output, not complete code. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment17http://ayende.com/4267/write-the-checkin-comment-part-ii#comment17Mon, 26 Oct 2009 16:21:27 GMTDoes that even compile? You have a catch without a try. I don't know what those blue lines mean. I don't know what exception you're trying to rethrow. And yup, in the spirit of the post title... do write the check in comment.... please. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment16http://ayende.com/4267/write-the-checkin-comment-part-ii#comment16Mon, 26 Oct 2009 12:28:04 GMT*Introduce Log4Net dependency http://ayende.com/4267/write-the-checkin-comment-part-ii#comment15http://ayende.com/4267/write-the-checkin-comment-part-ii#comment15Mon, 26 Oct 2009 09:05:38 GMTI beleve that the lacking comment should describe why we started to simetimes(!) throw exception. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment14http://ayende.com/4267/write-the-checkin-comment-part-ii#comment14Mon, 26 Oct 2009 07:03:05 GMTAre you trying to figure out if your audience is _really_ reading your posts? I am guessing you expect them not to be! http://ayende.com/4267/write-the-checkin-comment-part-ii#comment13http://ayende.com/4267/write-the-checkin-comment-part-ii#comment13Mon, 26 Oct 2009 04:24:41 GMT* Use log4net to handle error logging so that we can easily capture fatal errors when necessary (along with the timestamp of the exception) * Re-throw the exception when we hit a fatal Server error as we would have arrived in an unusable state Something like that :) http://ayende.com/4267/write-the-checkin-comment-part-ii#comment12http://ayende.com/4267/write-the-checkin-comment-part-ii#comment12Mon, 26 Oct 2009 02:54:18 GMTEnsure that an error doesn't take down the service by trying to write to the Console (which doesn't exist for a Windows Service). http://ayende.com/4267/write-the-checkin-comment-part-ii#comment11http://ayende.com/4267/write-the-checkin-comment-part-ii#comment11Mon, 26 Oct 2009 01:43:20 GMT@Mr_Simple I can't see why you can't do both. Keeping a tight structure will typically improve the overall quality as well as making your job easier. It's not about remembering what you did yesterday. It's about documenting what you did five minutes ago. Unless you're a goldfish, that should be an easy task. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment10http://ayende.com/4267/write-the-checkin-comment-part-ii#comment10Sun, 25 Oct 2009 21:02:43 GMT@ Ayende I dont know about you, but I'd rather spend my time billing $$$ my clients than playing word association games trying to remember what the heck I programmed yesterday. It's all about zero friction when you're paying your own way. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment9http://ayende.com/4267/write-the-checkin-comment-part-ii#comment9Sun, 25 Oct 2009 17:29:59 GMTThrow only if error happens on a server... http://ayende.com/4267/write-the-checkin-comment-part-ii#comment8http://ayende.com/4267/write-the-checkin-comment-part-ii#comment8Sun, 25 Oct 2009 17:26:38 GMT"Host program fails fast (rethrow) and loud (log) if an error occurs." http://ayende.com/4267/write-the-checkin-comment-part-ii#comment7http://ayende.com/4267/write-the-checkin-comment-part-ii#comment7Sun, 25 Oct 2009 17:06:25 GMTI am not exactly sure what executionOptions are but it seems like the exception should only be thrown if it happens on the server. Otherwise, the code logs the exception and then swallows it. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment6http://ayende.com/4267/write-the-checkin-comment-part-ii#comment6Sun, 25 Oct 2009 15:52:24 GMTArne, That is actually a very small (and relatively insignificant) change http://ayende.com/4267/write-the-checkin-comment-part-ii#comment5http://ayende.com/4267/write-the-checkin-comment-part-ii#comment5Sun, 25 Oct 2009 15:18:37 GMT"Made error log collection configurable at runtime, rather than having it always puke to the console" http://ayende.com/4267/write-the-checkin-comment-part-ii#comment4http://ayende.com/4267/write-the-checkin-comment-part-ii#comment4Sun, 25 Oct 2009 15:17:23 GMTMr_Simple, That is the point of this post, to see if you can figure it out :-) http://ayende.com/4267/write-the-checkin-comment-part-ii#comment3http://ayende.com/4267/write-the-checkin-comment-part-ii#comment3Sun, 25 Oct 2009 14:15:41 GMTI spent no more than 5 seconds looking at the code and wished the author had written a simple comment about what was suppossed to be happening. Maybe that was too simple - or perhaps my brain is just too simple to understand. http://ayende.com/4267/write-the-checkin-comment-part-ii#comment2http://ayende.com/4267/write-the-checkin-comment-part-ii#comment2Sun, 25 Oct 2009 14:10:57 GMT"Ensured I am able to get to see the darned error on startup even when the Prog is operated by a non-human user" http://ayende.com/4267/write-the-checkin-comment-part-ii#comment1http://ayende.com/4267/write-the-checkin-comment-part-ii#comment1Sun, 25 Oct 2009 11:14:07 GMT