Ayende @ Rahien

Stephen commented on A good refactoring session is…

Thu, 28 May 2009 12:21:09 GMT

So you didn't just randomly comment lines out and cross your fingers when hitting compile? I remember going from a prototype to a 'v0.1' the code was about a fifth the size, was faster, easier to program against and was far more extensible.. I don't think thats so uncommon for a prototype to be 'obese' but it was really nice that its evolution was so much smaller and yet tons better. (usual day for a dev right? I always enjoy that feeling anyway, I do a lap around the office for high fives borat style).

Jeremy Wiebe commented on A good refactoring session is…

Thu, 28 May 2009 12:14:56 GMT

Ah, so the refactoring was geting SqlStatement to be more focused. I'm always a big fan of those types of refactorings. :-)

Ayende Rahien commented on A good refactoring session is…

Thu, 28 May 2009 12:06:21 GMT

Ian, Almost, it is called SqlStatementProcessor, and it is a command object

Ayende Rahien commented on A good refactoring session is…

Thu, 28 May 2009 12:05:13 GMT

Jeremy, I create a separate class for handling that

Ian Nelson commented on A good refactoring session is…

Thu, 28 May 2009 09:50:34 GMT

Admit it Ayende, you moved 300+ lines of code to static methods in a SqlStatementHelper class? ;-)

Erik van Brakel commented on A good refactoring session is…

Thu, 28 May 2009 08:53:53 GMT

@configurator: Sometimes, putting stuff on one line makes the whole more readable. I often use that with properties, to cut down on the curly-braces-porn that's going on in there: public string Whatever { get { return whatever; } set { whatever = value; } } public string Whenever { get { return whenever; } set { whenever = value; } } public string However { get { return however; } set { however = value; } } Or, if you don't like it like that: public string Whatever { get { return whatever; } set { whatever = value; } } En then continue using proper spacing in the rest of the code. Those properties are SO obvious that you don't really need to space it out over 8 lines. Either way, I don't think Ayende just removed whitespace, else he wouldn't be so happy with it ;-)

Jeremy Wiebe commented on A good refactoring session is…

Thu, 28 May 2009 05:00:01 GMT

So did some of the functionality move to other classes or were you really able to remove ~300 lines and maintain similar functionality?

configurator commented on A good refactoring session is…

Thu, 28 May 2009 00:04:08 GMT

Clearly this: class SqlStatement { public string Whatever { get { return whatever; } set { whatever = value; } } private string whatever; ... } is much better than this: class SqlStatement { public string Whatever { get { return whatever; } set { whatever = value; } } private string whatever; ... }

Gloubidou commented on A good refactoring session is…

Wed, 27 May 2009 21:22:26 GMT

YUICompressor for CSharp :-)

Kelly Stuard commented on A good refactoring session is…

Wed, 27 May 2009 21:21:49 GMT

Oh, and there was a tag at the end of the first post; but I guess it got eaten.

Kelly Stuard commented on A good refactoring session is…

Wed, 27 May 2009 21:19:56 GMT

BTW: not liking that I have to fire up an alternate browser to IE8 to post comments - not even compat mode works

Kelly Stuard commented on A good refactoring session is…

Wed, 27 May 2009 21:19:43 GMT

So obviously that means it does 30% less now. Or that you put 30% of the code on one line. Oh, I know ... the curley braces are no longer on their own line! Because, of course, there is no way to get rid of or refactor code.

Frank Quednau commented on A good refactoring session is…

Wed, 27 May 2009 21:09:49 GMT

I tend to say that the best line of code is the one you never wrote, but this is the next best thing.