Ayende @ Rahienhttp://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Ayende Rahien commented on A case of massive stupidityconfigurator, But I _do_ control writer, I am the only owner of the reference http://ayende.com/4032/a-case-of-massive-stupidity#comment9http://ayende.com/4032/a-case-of-massive-stupidity#comment9Wed, 27 May 2009 09:44:30 GMTconfigurator commented on A case of massive stupidityIsn't locking on objects you can't control, such as lock (writer), discouraged? Wouldn't it be better to have a locker object? http://ayende.com/4032/a-case-of-massive-stupidity#comment8http://ayende.com/4032/a-case-of-massive-stupidity#comment8Wed, 27 May 2009 00:27:09 GMTAyende Rahien commented on A case of massive stupiditylock(writer) { writer.Write(msg); } I didn't touch the protobuf code. Protobuf isn't aware of threading, and I don't think it should. http://ayende.com/4032/a-case-of-massive-stupidity#comment7http://ayende.com/4032/a-case-of-massive-stupidity#comment7Sun, 24 May 2009 09:12:47 GMTAyende Rahien commented on A case of massive stupidityThe performance wasn't actually the major reason. I wanted a cross platform format that had good versioning story. It helps that it is very perfomant, because I am handling large number of messages. So far I haven't even had a reason to think about it, so I am very happy http://ayende.com/4032/a-case-of-massive-stupidity#comment6http://ayende.com/4032/a-case-of-massive-stupidity#comment6Sun, 24 May 2009 09:08:00 GMTfirefly commented on A case of massive stupidityOren, I mean to ask where did you choose to do the write synchronization, in the higher up code or right in the protocolbuffers file? I am guessing the later is that right? http://ayende.com/4032/a-case-of-massive-stupidity#comment5http://ayende.com/4032/a-case-of-massive-stupidity#comment5Sun, 24 May 2009 08:29:04 GMTCaliCoder commented on A case of massive stupidityAyende, how are the Google Protocol Buffers working out? Is it what you thought in terms of performance? http://ayende.com/4032/a-case-of-massive-stupidity#comment4http://ayende.com/4032/a-case-of-massive-stupidity#comment4Sun, 24 May 2009 03:11:43 GMTAyende Rahien commented on A case of massive stupiditySyncronized the writes http://ayende.com/4032/a-case-of-massive-stupidity#comment3http://ayende.com/4032/a-case-of-massive-stupidity#comment3Sat, 23 May 2009 23:33:06 GMTfirefly commented on A case of massive stupidityHow did you fix it? http://ayende.com/4032/a-case-of-massive-stupidity#comment2http://ayende.com/4032/a-case-of-massive-stupidity#comment2Sat, 23 May 2009 17:21:12 GMTconfigurator commented on A case of massive stupidityWhat happened here is not massive stupidity. Massive stupidity is not knowing why this needs the synchronization. Mistakes, though, happen even to the best of us. Everyone makes mistakes - even Jon Skeet. A mistake of omission of synchronization is damn annoying, and usually very time consuming, but it sure isn't stupidity. http://ayende.com/4032/a-case-of-massive-stupidity#comment1http://ayende.com/4032/a-case-of-massive-stupidity#comment1Sat, 23 May 2009 16:38:23 GMT