http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Ayende, I don't doubt it at all, but there are many reasons why you shouldn't be testing for that scenario in the way that you are. If the code is structured properly (which I assume it is, I haven't looked) then there are much better ways of testing for it. http://ayende.com/3975/find-the-bug#comment18http://ayende.com/3975/find-the-bug#comment18Fri, 24 Apr 2009 20:23:32 GMTPeter, This Peter, That test is there to uncover a bug where we would send several copies of the message to the receiver http://ayende.com/3975/find-the-bug#comment17http://ayende.com/3975/find-the-bug#comment17Fri, 24 Apr 2009 17:17:29 GMTThat's the source (which I would need), but what exactly is the nature of the test? Should get two items when two items are sent there should be no more than two items http://ayende.com/3975/find-the-bug#comment16http://ayende.com/3975/find-the-bug#comment16Fri, 24 Apr 2009 12:33:33 GMTGerke, DING DING DING DING You GOT it. And it took you a LOT less than what it took me. For fun & games, this also can happen on another thread, isn't this FUN? http://ayende.com/3975/find-the-bug#comment15http://ayende.com/3975/find-the-bug#comment15Fri, 24 Apr 2009 12:21:56 GMTWhat does the transaction scope do with receiver on disposal of the scope (leave of using block) after ObjectDisposedException of receiver? http://ayende.com/3975/find-the-bug#comment14http://ayende.com/3975/find-the-bug#comment14Fri, 24 Apr 2009 12:17:52 GMT[rhino-tools.svn.sourceforge.net/.../queues](https://rhino-tools.svn.sourceforge.net/svnroot/rhino-tools/trunk/queues)http://ayende.com/3975/find-the-bug#comment13http://ayende.com/3975/find-the-bug#comment13Fri, 24 Apr 2009 12:16:54 GMTAyende, explain the requirement to me and I would be happy to. http://ayende.com/3975/find-the-bug#comment12http://ayende.com/3975/find-the-bug#comment12Fri, 24 Apr 2009 12:14:27 GMTTommaso, No, it can't, because that is what the test is testing Well, not really, the test isn't testing that It cannot be 5 because messages are received in send order, so it would always be 4 http://ayende.com/3975/find-the-bug#comment11http://ayende.com/3975/find-the-bug#comment11Fri, 24 Apr 2009 12:10:21 GMTSergey, When you dispose, you also break all receives, that is not actually a problem. You are close when you are thinking about transactions, but you are going in the wrong way. If queue receive fail, it is either a timeout or dispose, all others would cause it to exit fully http://ayende.com/3975/find-the-bug#comment10http://ayende.com/3975/find-the-bug#comment10Fri, 24 Apr 2009 12:08:52 GMTPeter, Find me another wait to wait until a message does _not_ arrive, I'll fix this http://ayende.com/3975/find-the-bug#comment9http://ayende.com/3975/find-the-bug#comment9Fri, 24 Apr 2009 12:06:48 GMTJason & Peter, It will only cause it to go into a loop of throwing ObjectDisposedException, nothing that would actually cause harm, until it fall out of the loop when we set keepRunning to false. You aren't thinking about it deeply enough, look what else may be involved. http://ayende.com/3975/find-the-bug#comment8http://ayende.com/3975/find-the-bug#comment8Fri, 24 Apr 2009 12:04:49 GMTreceiver.Dispose will cause receiver.Receive to throw ObjectDisposedException (presumably), but then since keepRunning is still true, Receiver will call receiver.Receive again, which is the bug? http://ayende.com/3975/find-the-bug#comment7http://ayende.com/3975/find-the-bug#comment7Fri, 24 Apr 2009 11:10:15 GMTProbably, after while(true) loop breaks after msgs.Count == 2 receiver will be waiting for third message for 10 secs but you are disposing it in 2 secs – who is going to throw TimeoutException then? It looks the queue is transactional. How are you going to reach msgs.Count == 2 to break while(true) loop if queue receives fail and roll-backs with moving messages to poison-message queue? http://ayende.com/3975/find-the-bug#comment6http://ayende.com/3975/find-the-bug#comment6Fri, 24 Apr 2009 09:52:09 GMTOh, and the bug is this... receiver.Dispose(); keepRunning = false; Which is effectively (sometimes) this receiver.Dispose(); msg = receiver.Receive("uno", null, new TimeSpan(0, 0, 10)); keepRunning = false; http://ayende.com/3975/find-the-bug#comment5http://ayende.com/3975/find-the-bug#comment5Fri, 24 Apr 2009 09:36:03 GMTmsgs[0] could be "Message 5" http://ayende.com/3975/find-the-bug#comment4http://ayende.com/3975/find-the-bug#comment4Fri, 24 Apr 2009 09:34:27 GMTRight, so *all* of this code is in the tests then? As for the Thread.Sleep, that's just awful :-) http://ayende.com/3975/find-the-bug#comment3http://ayende.com/3975/find-the-bug#comment3Fri, 24 Apr 2009 09:30:32 GMTPeter, because Receiver is the component under test, it doesn't know whatever it should keep running or not. As for Thread.Sleep, yes, it is in the test. This is a time sensitive test. http://ayende.com/3975/find-the-bug#comment2http://ayende.com/3975/find-the-bug#comment2Fri, 24 Apr 2009 09:10:44 GMTMy thoughts are Why does the test have a "keepRunning" member? Surely receiver.Dispose should set keepRunning = false and then wait for the while loop to end? Personally I'd also change KeepRunning to IsDisposed or something. But what I'd like to say most of all is this. You don't REALLY have code like Thread.Sleep(2000) in your tests do you? http://ayende.com/3975/find-the-bug#comment1http://ayende.com/3975/find-the-bug#comment1Fri, 24 Apr 2009 09:07:04 GMT