http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660I didn't mean to cause offence, was just interested! And i'll take your word for it then :) http://ayende.com/3965/test-refacotring#comment15http://ayende.com/3965/test-refacotring#comment15Tue, 21 Apr 2009 07:51:42 GMTCiaran, a) no b) you haven't asked what I am testing, this is part of the NH Search test suite http://ayende.com/3965/test-refacotring#comment14http://ayende.com/3965/test-refacotring#comment14Tue, 21 Apr 2009 07:49:53 GMTInteresting, does this not slow down your tests a lot ? http://ayende.com/3965/test-refacotring#comment13http://ayende.com/3965/test-refacotring#comment13Tue, 21 Apr 2009 07:48:16 GMTCiaran, The lack of context is tripping you. In fact, I am blowing away the database _schema_ each time I run the test. http://ayende.com/3965/test-refacotring#comment12http://ayende.com/3965/test-refacotring#comment12Tue, 21 Apr 2009 07:45:44 GMTI notice in your OnTearDown you're deleting every mapped thing in your NHibernate Configuration, which means (unless I'm mistaken, which I could well be) that if there was any data in there that was global reference data that was shared by all tests it would be blown away. I've always been told to strive for Idempotence in my tests so would traditonally have just removed what I created in my setup, am I wasting my time with this approach ? In a non-trivial test where you can setup the entire database as you need it in your setup then I guess its ok to do this each time, but when you're running hundreds or thousands of tests over a complex system that has data that has a lot of shared reference values that would slow the tests down quite a lot I think ? http://ayende.com/3965/test-refacotring#comment11http://ayende.com/3965/test-refacotring#comment11Tue, 21 Apr 2009 07:43:47 GMTNot sure if it's intentional or not but you may want to fix the spelling mistake "Refactoring" Cheers John http://ayende.com/3965/test-refacotring#comment10http://ayende.com/3965/test-refacotring#comment10Mon, 20 Apr 2009 22:10:08 GMT@Frank Quednau I'd say that's naming convention in NH which Oren just follows. http://ayende.com/3965/test-refacotring#comment9http://ayende.com/3965/test-refacotring#comment9Mon, 20 Apr 2009 21:43:09 GMTFinally a prominent proponent for PascalCasedTestNames. All_this_underscore_separation_is_getting_out_of_hand! ;) http://ayende.com/3965/test-refacotring#comment8http://ayende.com/3965/test-refacotring#comment8Mon, 20 Apr 2009 20:53:55 GMT@Ayende: I know it's not worth it, but it is good practice. And this is codesmell and people who wan't to learn what happens behind the scene will get a nearly Kobe feeling ;) The power of example. http://ayende.com/3965/test-refacotring#comment7http://ayende.com/3965/test-refacotring#comment7Mon, 20 Apr 2009 20:35:03 GMTSo instead of a single test you can easily follow you have a tangle of implied function calls. And what if one of those implied calls, say "OnSetUp" fails? Do you get bombarded with false positives or does it just silently ignore your tests? And what if you want a different setup? Do you have to build a whole new class for each data scenario? The original test wasn't perfect, but this new one seems to be both over engineered and inflexible at the same time. http://ayende.com/3965/test-refacotring#comment6http://ayende.com/3965/test-refacotring#comment6Mon, 20 Apr 2009 20:09:01 GMTBenny, Not worth it, this is not a test for an application, this is a test for NH Search, so we have LOTS of stuff like that http://ayende.com/3965/test-refacotring#comment5http://ayende.com/3965/test-refacotring#comment5Mon, 20 Apr 2009 19:36:19 GMTJohn, What you don't see here is that there are transaction syncronizations going on behind the scene to sync the index. I have to use tx. http://ayende.com/3965/test-refacotring#comment4http://ayende.com/3965/test-refacotring#comment4Mon, 20 Apr 2009 19:35:27 GMTI'm missing the factory method for Author, Order and Product. http://ayende.com/3965/test-refacotring#comment3http://ayende.com/3965/test-refacotring#comment3Mon, 20 Apr 2009 19:11:52 GMTAnd replacing tx.Commit with s.Flush(); s.Clear(); in your tests http://ayende.com/3965/test-refacotring#comment2http://ayende.com/3965/test-refacotring#comment2Mon, 20 Apr 2009 18:49:51 GMTInstead of cleaning up using deletes, why don't you just rollback the transaction? http://ayende.com/3965/test-refacotring#comment1http://ayende.com/3965/test-refacotring#comment1Mon, 20 Apr 2009 18:47:00 GMT