http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Don't just say it's bad show how it can be improved, with examples. Good and bad examples should be shown when writing this type of article. http://ayende.com/3950/kobe-data-access-done-wrong#comment21http://ayende.com/3950/kobe-data-access-done-wrong#comment21Sun, 19 Apr 2009 17:56:32 GMTre insolated = 'insolate - expose to the rays of the sun or affect by exposure to the sun' did you mean insulted? http://ayende.com/3950/kobe-data-access-done-wrong#comment20http://ayende.com/3950/kobe-data-access-done-wrong#comment20Sun, 19 Apr 2009 00:06:37 GMTThere seems plenty of people who are willing to moan at every app that is put out in the public domain and actually spend hours writing blog posts to pull them apart. What is funny is that they all state they cannot put together a best practise demo because nobody will pay them to do so. Surely the time spent moaning would be better spent providing? http://ayende.com/3950/kobe-data-access-done-wrong#comment19http://ayende.com/3950/kobe-data-access-done-wrong#comment19Fri, 17 Apr 2009 23:12:45 GMTLot's of examples on the web of how not to do things...how about some examples of doing things right, or refactoring bad code like this into something that's ideal? http://ayende.com/3950/kobe-data-access-done-wrong#comment18http://ayende.com/3950/kobe-data-access-done-wrong#comment18Fri, 17 Apr 2009 21:41:49 GMTJon, The problem is that this method should NOT be written. This is not the proper layer for it. As for constructing the repository for this. All you need is transparent persistence and you are golden. http://ayende.com/3950/kobe-data-access-done-wrong#comment17http://ayende.com/3950/kobe-data-access-done-wrong#comment17Fri, 17 Apr 2009 15:48:50 GMTAgree with the rest of the commenters - I'd love to see more explanation here. The rest of your Kobe posts have said "This is what is wrong, and this is how it should have been done". This one just says "This is wrong". For those of us who don't use repositories and have never used EF, how should that that method be written? Or how should the repository be structured so the method was unnecessary? http://ayende.com/3950/kobe-data-access-done-wrong#comment16http://ayende.com/3950/kobe-data-access-done-wrong#comment16Fri, 17 Apr 2009 15:43:24 GMTI also agree...I post on repository alternatives would be great. What's the strategy to keep the data access/orm choice (NHibernate / EF / Linq2Sql / etc) isolated and out of the "UI" layer? http://ayende.com/3950/kobe-data-access-done-wrong#comment15http://ayende.com/3950/kobe-data-access-done-wrong#comment15Fri, 17 Apr 2009 15:20:35 GMThmm.. interesting comments. I'm partial to Rails's ActiveRecord with dynamic accesors, but you don't get that in c#. Otherwise, I have no strong bias for or against repository, and am curious why so many comments are. http://ayende.com/3950/kobe-data-access-done-wrong#comment14http://ayende.com/3950/kobe-data-access-done-wrong#comment14Fri, 17 Apr 2009 15:19:18 GMTWho ever wrote that IUserRepository should be fired immediately. As a matter of fact, they shouldn't be allowed to touch code any more. ... Since everybody now an interface should have 100 methods...! http://ayende.com/3950/kobe-data-access-done-wrong#comment13http://ayende.com/3950/kobe-data-access-done-wrong#comment13Fri, 17 Apr 2009 15:04:14 GMTI think the point that Ayende is making is that a lot (most) of those methods are really domain behavior that don't have anything to do with data access per se and thus shouldn't be part of the data access layer. Without looking at the code I suspect that this codebase has an anemic domain model. http://ayende.com/3950/kobe-data-access-done-wrong#comment12http://ayende.com/3950/kobe-data-access-done-wrong#comment12Fri, 17 Apr 2009 15:02:11 GMTPopular demand!!! repository alternative!!! http://ayende.com/3950/kobe-data-access-done-wrong#comment11http://ayende.com/3950/kobe-data-access-done-wrong#comment11Fri, 17 Apr 2009 13:26:42 GMTDitto on what everyone else is saying... :) http://ayende.com/3950/kobe-data-access-done-wrong#comment10http://ayende.com/3950/kobe-data-access-done-wrong#comment10Fri, 17 Apr 2009 13:08:34 GMT+1 on repository alternative http://ayende.com/3950/kobe-data-access-done-wrong#comment9http://ayende.com/3950/kobe-data-access-done-wrong#comment9Fri, 17 Apr 2009 12:44:15 GMTCount me in with the RepositoryAsFad crowd... http://ayende.com/3950/kobe-data-access-done-wrong#comment8http://ayende.com/3950/kobe-data-access-done-wrong#comment8Fri, 17 Apr 2009 09:15:21 GMT+1 on repo alternative. http://ayende.com/3950/kobe-data-access-done-wrong#comment7http://ayende.com/3950/kobe-data-access-done-wrong#comment7Fri, 17 Apr 2009 09:07:26 GMTAnother agreement with AdamB :) I wanna know! http://ayende.com/3950/kobe-data-access-done-wrong#comment6http://ayende.com/3950/kobe-data-access-done-wrong#comment6Fri, 17 Apr 2009 08:40:13 GMTI agree with AdamB. Ayende, could you please expand on this? http://ayende.com/3950/kobe-data-access-done-wrong#comment5http://ayende.com/3950/kobe-data-access-done-wrong#comment5Fri, 17 Apr 2009 08:25:32 GMT"Data access details are quite pervasive throughout the application, and the whole feeling of the application is of a circa 2001 sample app using stored procedures and hand rolled data access layers." HAHA this is classic! Writing those factories is like chasing watching a cat chase its tail... go find a biz problem that needs data access, abstract it, go find a biz problem that needs data access, abstract it. Makes my hand shake just thinking about it =( http://ayende.com/3950/kobe-data-access-done-wrong#comment4http://ayende.com/3950/kobe-data-access-done-wrong#comment4Fri, 17 Apr 2009 08:17:36 GMTWhat alternative would you use to a Repository? Just ORM code such as the NHibernate DetachedCriteria API, HQL or LINQ in your services? Or even in your controllers? I'm asking because I respect your opinion and I've been using repositories for a while now, and find that they're a pretty useful abstraction. http://ayende.com/3950/kobe-data-access-done-wrong#comment3http://ayende.com/3950/kobe-data-access-done-wrong#comment3Fri, 17 Apr 2009 08:09:56 GMTHow dare you say bad things about next sample from Microsoft? You barbarian, biting a hand that feeds you! MS programmers were working on it since 2001 so how can you expect the app to be modern and cutting edge? http://ayende.com/3950/kobe-data-access-done-wrong#comment2http://ayende.com/3950/kobe-data-access-done-wrong#comment2Fri, 17 Apr 2009 07:25:26 GMT> I think that Repository is a fad, which is why I don’t use it much anymore myself Would you mind writing some more about this in a new post? I'm intrigued. http://ayende.com/3950/kobe-data-access-done-wrong#comment1http://ayende.com/3950/kobe-data-access-done-wrong#comment1Fri, 17 Apr 2009 06:57:43 GMT