http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Brian, Sort of my point http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment57http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment57Sat, 02 May 2009 06:30:54 GMTHow to make this code throw an exception? Would like to see an unit test that demonstrates. Thx. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment56http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment56Sat, 02 May 2009 06:28:38 GMTIt has now been deleted... I can't get myself into context any more. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment55http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment55Mon, 27 Apr 2009 03:12:33 GMTAslam, Several reasons: a) bad code need to be made public, to make sure that people _recognize it as bad code b) this is actually fairly high on the search for a few important nhibernate concurrency searches http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment54http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment54Tue, 21 Apr 2009 07:34:22 GMT> Well it seems that your criticism of the author has now caused the article to be removed.. It's a shame, that the criticism didn't make the author rewrite it ... http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment53http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment53Fri, 17 Apr 2009 14:49:40 GMTIt's already been voted into oblivion by the community. Hooray. Thanks for reading The Code Project, though. Hope you voted it down! http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment52http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment52Thu, 16 Apr 2009 23:14:41 GMTI have an idea. Let me throw up lousy code, lay back and watch herds of women-deprived geeks laugh about it and throw up more code. Oh, no need to. It has already been done here. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment51http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment51Thu, 16 Apr 2009 18:58:22 GMTI've seen much worse: try { ... } catch(Exception ex) { Response.Write(ex.Message + " " + ex.StackTrace); } http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment50http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment50Thu, 16 Apr 2009 13:32:41 GMTWell it seems that your criticism of the author has now caused the article to be removed.. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment49http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment49Wed, 15 Apr 2009 20:22:06 GMTThe method actually returns a copy of the reference. .NET uses a copy of the original reference inside a method unless the "ref" keyword is used in the parameter declaration. This is why setting the reference to null inside the method will not change the outside reference. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment48http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment48Wed, 15 Apr 2009 13:53:03 GMTThanks Ayende. That was quick. I am glad you restored my sanity. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment47http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment47Wed, 15 Apr 2009 11:59:59 GMTthrow; // keep the stack trace throw ex; // lose the stack trace Losing the stack trace is _bad_. Putting a try catch block without doing any error handling is wrong. DeepCopy should perform a DEEP copy, not a ref copy. What this method does is return the same reference, so it lies about its impl. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment46http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment46Wed, 15 Apr 2009 11:49:24 GMTguys., I am one of those junior developers who can't see what is so wrong with the code. How would it be different if one would do Catch(Exception ex) { throw; } In the case of the author he is still throwing eventually. I miss the point. Also I am not sure what are the inherent problems with accepting a parameter as an object and then returning it? Let me go further and say I don't even understand how does that mean deep copy? Just accepting an object by reference and returning the reference back. I would be glad for any pointers. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment45http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment45Wed, 15 Apr 2009 11:44:17 GMTI call fizzbuzz. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment44http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment44Wed, 15 Apr 2009 03:26:30 GMTWow, that's something else right there. The creator of that code should give this new fangled learning technique called "reading books" a try. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment43http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment43Tue, 14 Apr 2009 23:37:16 GMT@Grunties : What good reasons are those? @Aslam : If you are going to compare with something, try something that people have heard of :-) Seriously though, I thought this post was a bit pathetic until I saw the author's apparent inability to accept his mistakes and fix the code in the article. *Then* I thought the article was worth mocking. It's counts not only how good you are when things go right, but also how good you are when things go wrong! If my code is shit I will be glad for the criticism as I learn from changing it. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment42http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment42Tue, 14 Apr 2009 21:38:10 GMTShame on CodeProject.com. I'll be extra skeptical next time I see a CodeProject article from an unknown author. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment41http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment41Tue, 14 Apr 2009 17:42:54 GMTIt looks like a stub. Move along... http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment40http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment40Tue, 14 Apr 2009 16:28:48 GMTi haven't laughed so hard in ages. thank you for brightening my day. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment39http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment39Tue, 14 Apr 2009 16:02:46 GMTThere is nothing wrong with the code, that is just it, there is nothing. It makes me feel almost zen like... There is nothing wrong... There is no spoon... There is no special ingredient... There is just nothing.... http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment38http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment38Tue, 14 Apr 2009 15:49:02 GMTProbably you don't have realized that the NH's users generation are changing; this is not a minor problem and sure it is a problem. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment37http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment37Tue, 14 Apr 2009 14:58:40 GMTWow... I do not know what disturbs me more, the fact that this article was accepted by CodeProject or the fact that someone out there will use this article in production code. I've googled some of the code in my company's codebase and have found some CodeProject articles come up. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment36http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment36Tue, 14 Apr 2009 14:09:01 GMTmaybe the code was poorly ported from C++ where the object was returned by value and the exception was caught in case the copy constructor failed http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment35http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment35Tue, 14 Apr 2009 13:36:56 GMTYes, this is just bad code. Ayende has rightfully surfaced it as such. But I really don't see the value of hosing the author as a useless developer. Have you asked yourself "Why am I laughing at this - publicly, and loudly?". I watched the tail-end of Romy and Michelle's High School Reunion on TV last night. The laugh comments here reminds me of Christine and her girlfriends ridiculing Romy and Michele at the reunion. I think we are all capable of being better people than this. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment34http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment34Tue, 14 Apr 2009 13:22:00 GMT@Grunties, I don' claim to be a smart fellow or an enlightened .Net developer, but what are the reasons you are talking about? This is not about elitism, this is about spreading bad coding practices, in a community where thousands of developers passionate about their framework and language invest huge amounts of time and dedication to write blog posts, articles and books about good coding practices as a community effort to raise the quality bar of the code .Net developers write in general. We are all better of when bad coding isn't spread around in articles like this one. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment33http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment33Tue, 14 Apr 2009 12:19:10 GMTWhy did you leave out the Disassemble method? It really ties the whole thing together. I actually feel kind of bad for him, but worse for the people reading this as an expert example. public object DeepCopy(object value) { try { return value; } catch (Exception ex) { throw ex; } } public object Disassemble(object value) { try { return DeepCopy(value); } catch (Exception ex) { throw ex; } } http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment32http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment32Tue, 14 Apr 2009 12:13:06 GMT// tl;dr duh, everyone knows that this is just a hook for an out-of-VM exception handler. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment31http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment31Tue, 14 Apr 2009 11:54:55 GMTThere's some things wrong with this code, yes, and it was clearly written by someone with little understanding of what's going on 'under the bonnet/hood'. But, here, there's a lot of Dunning-Kruger effect. There are some good reasons to be doing what this code is attempting, and yet no one here wants to mention any of it. Shameful and misguided elitism, IMHO. http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment30http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment30Tue, 14 Apr 2009 11:37:14 GMTBRILLANT http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment29http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment29Tue, 14 Apr 2009 11:08:40 GMTPERFECT :) http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment28http://ayende.com/3944/there-are-so-many-things-wrong-with-this-code#comment28Tue, 14 Apr 2009 10:18:29 GMT