http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660I actually was thinking I wanted this feature just last week. However, I really see this as a SoC issue. It is not NHProfilers job to show me the results, it is its job to simply profile my app and let me know where i screwed up. If i want to get the resulting output i can simply copy the sql and past into a query window. about the only feature I would want NHProfiler to do is maybe may the copy part easy say with a button. http://ayende.com/3819/it-ain-t-so-simple-mister#comment17http://ayende.com/3819/it-ain-t-so-simple-mister#comment17Sun, 25 Jan 2009 19:44:08 GMT@k03123 Welcome to the "GPL free world".... @Ayende I guess MySQL drivers exists in dual licence, to allow you to distribute it with your application without the gpl restriction, of course, you need to "licence" it for that. http://ayende.com/3819/it-ain-t-so-simple-mister#comment16http://ayende.com/3819/it-ain-t-so-simple-mister#comment16Wed, 21 Jan 2009 20:23:27 GMTk03123, Yes, that is what it usually means. At least not if you distribute it. http://ayende.com/3819/it-ain-t-so-simple-mister#comment15http://ayende.com/3819/it-ain-t-so-simple-mister#comment15Wed, 21 Jan 2009 00:23:29 GMTdoes that mean i can't use mysql and/or mysql drivers for any application without making the source code available? http://ayende.com/3819/it-ain-t-so-simple-mister#comment14http://ayende.com/3819/it-ain-t-so-simple-mister#comment14Wed, 21 Jan 2009 00:07:20 GMTJoe, I am sorry, but what you are talking about is the _Lesser_ GPL. GPL code requires that you would GPL your own code for the mere use of GPL code. That includes merely linking to the GPL code. http://ayende.com/3819/it-ain-t-so-simple-mister#comment13http://ayende.com/3819/it-ain-t-so-simple-mister#comment13Mon, 19 Jan 2009 15:16:46 GMTMySQL Drivers being GPL is not counter to this being a production / commercial application as long as you are not changing the 'compiled' code using the source of the connection logic. The GPL doesn't force you to 'reveal' your SOURCE unless you have modified the GPL items for inclusion. Since in this case you would be using the Compiled DLLs no harm no foul - but still better to check with the MySQL folk and the legal eagles - but It seems that overall precedent is that linking to a compiled item is not enough under the GPL to cause 'full code disclosure' of the code including the GPLed item. Just thought I would point that out. Thanks, Joe http://ayende.com/3819/it-ain-t-so-simple-mister#comment12http://ayende.com/3819/it-ain-t-so-simple-mister#comment12Mon, 19 Jan 2009 15:04:03 GMTI think there are more issues with this than you're even describing. Most likely people want to see the results that the query itself returned, right? I think this is impossible by using an external connection. There are too many race conditions involved if you plan to re-run the same query as the profiled application. If they are modifying objects at the same time that queries are running (seems logical for lots of applications) by the time you run the same query they could have changed the data out from under you. Would people really just want to run the query on the current data? What value would that provide? If that's the case, make it easy for them to copy and paste the sql statement so they can run it in their own query tool. http://ayende.com/3819/it-ain-t-so-simple-mister#comment11http://ayende.com/3819/it-ain-t-so-simple-mister#comment11Mon, 19 Jan 2009 13:33:19 GMTI know this isn't completely on topic, but I guess if you decide to implement this feature, it's better to put results view under the sql statement details view. http://ayende.com/3819/it-ain-t-so-simple-mister#comment10http://ayende.com/3819/it-ain-t-so-simple-mister#comment10Mon, 19 Jan 2009 08:56:29 GMTWhy don't you try something like enumerating a list of the system DSN's the user has created in their Data Sources (ODBC) control panel? That pushes the responsibility off onto the user for managing drivers, how to connect, what to connect to, etc. http://ayende.com/3819/it-ain-t-so-simple-mister#comment9http://ayende.com/3819/it-ain-t-so-simple-mister#comment9Sun, 18 Jan 2009 20:15:41 GMTI have no idea how you detect the SQL queries that are run in NHibernate, but can't you use the same methods to see the results? I know as a user I'd prefer to see the (stale) results that were actually there when the application was run and not the current results which may have changed... http://ayende.com/3819/it-ain-t-so-simple-mister#comment8http://ayende.com/3819/it-ain-t-so-simple-mister#comment8Sun, 18 Jan 2009 18:41:11 GMTAhh the beauty of shrinkwrap that interacts with 3rd party. Been there done that. 10% feature, 90% handling related issues that have nothing to do with feature you are implementing. It's a drag, but we're confident you can pull it off. http://ayende.com/3819/it-ain-t-so-simple-mister#comment7http://ayende.com/3819/it-ain-t-so-simple-mister#comment7Sun, 18 Jan 2009 15:16:29 GMTWhile this would be cool - seems a bridge too far. Not even in SQL Profiler do I get a tooltip or whatever of the results - probably for some pretty good reasons. The issue, as well, is that some people will want what the query would have produced *at that point in time* - which unless you store results on a stack somewhere, will be inaccurate as queries go by and change the database. The only thing I can think of is a setting to set up a preview configuration that is defaulted in certain scenarios where it is feasible. And even then, this feature too much. Having it very easy to get what the query *was* seems like more than enough. http://ayende.com/3819/it-ain-t-so-simple-mister#comment6http://ayende.com/3819/it-ain-t-so-simple-mister#comment6Sun, 18 Jan 2009 14:26:32 GMTOk, but consider to allow this configuration on an per application base. Because i dont want to change the connection string if i have to profile more the one app on a short time. http://ayende.com/3819/it-ain-t-so-simple-mister#comment5http://ayende.com/3819/it-ain-t-so-simple-mister#comment5Sun, 18 Jan 2009 13:40:12 GMTSteve, You just suggested adding _more_ complexity. I don't want to have more than a single way of doing this. http://ayende.com/3819/it-ain-t-so-simple-mister#comment4http://ayende.com/3819/it-ain-t-so-simple-mister#comment4Sun, 18 Jan 2009 13:34:40 GMTWhy don't dont support both? If an option is in NHProf is explicit set and all above assumptions are fine, allow direct execution of the result. Or direct execute all querys and store them in the session file for later reuse. This have the benefit that i have exact the data which are there at profile time. And second, allow the user to put a simple xml/config file at the position where the appender lives or at the root of the application where i can store my connection strings (for each session fatory name) explicit for NHProf. If it is there NProf could copy its values to the session file. I for myself dose not need the results inline. I prefer to have a tab for that data beside the details tab. http://ayende.com/3819/it-ain-t-so-simple-mister#comment3http://ayende.com/3819/it-ain-t-so-simple-mister#comment3Sun, 18 Jan 2009 13:30:38 GMTI _could_. But that make a _lot_ of assumptions. 1) that I am actually in that process space. NH Prof is also supporting profiling from a file or from a standard unmodified installation. 2) that this is actually allowed by the customer. See arguments about security in the post. 3) that there is only one session factory in the aplication. http://ayende.com/3819/it-ain-t-so-simple-mister#comment2http://ayende.com/3819/it-ain-t-so-simple-mister#comment2Sun, 18 Jan 2009 13:16:12 GMTOnce you are in the process space of the application (since you appender lives there too) can you not access the SessionFatory created from NHibernate and then simply open a connection from there? http://ayende.com/3819/it-ain-t-so-simple-mister#comment1http://ayende.com/3819/it-ain-t-so-simple-mister#comment1Sun, 18 Jan 2009 13:06:00 GMT