Ayende @ Rahien

Roy Tate commented on Meta tests

Wed, 08 Oct 2008 18:10:09 GMT

Function AttributesEndWithAttribute should be corrected ... if (type.IsAssignableFrom(typeof(Attribute))) should be if (type.IsAssignableFrom(typeof(Attribute)) == false)

John Rayner commented on Meta tests

Thu, 02 Oct 2008 20:15:10 GMT

Bunter commented on Meta tests

Thu, 02 Oct 2008 13:54:00 GMT

This kind of test is perfect for continuous integration as it will reveal convention mistakes for whole team extremely quickly and well, continuously.

Morgan commented on Meta tests

Thu, 02 Oct 2008 06:11:22 GMT

I think you can turn off rules in StyleCop, but you cant change a rule that says that private fields should start with m_ when you want only _. So you have to disable that rule and implement your own custom rule.

Judah Himango commented on Meta tests

Thu, 02 Oct 2008 01:22:00 GMT

I've tried StyleCop. It complained about some things we don't like ("always use 'this.' before accessing members", for example). We had literally several thousand violations. So we didn't pursue it any further.

Morgan commented on Meta tests

Wed, 01 Oct 2008 18:43:06 GMT

Thats a bit hilarius. I use Code Style Enforcer for this, it plays nicely with ReSharper. You can customize the rules. Anyone tried Microsofts StyleCop?

otter commented on Meta tests

Wed, 01 Oct 2008 13:11:57 GMT

that is very funny, and a very cool idea. however i don't think i would ever want to include a test like that as part of my continuous integration. it doesn't seem like it 'belongs' as a true unit test, perhaps it would be best used as a separate test from your standard unit tests.

Tobin Harris commented on Meta tests

Wed, 01 Oct 2008 07:32:55 GMT

They forgot to add [Test] public void TestNamesAreSmeltCorrectly(){...} To catch the spelling error in "FirstLaterOfMethodIsCapitalized".

Jason Stangroome commented on Meta tests

Wed, 01 Oct 2008 07:27:16 GMT

Definitely hilarious. Really should be using MbUnit's TestSuite feature or your preferred test framework's equivalent so you get one test passing or failing for each interface, method, and attribute, not just a test that fails on the first problem it finds.

ZeusTheTrueGod commented on Meta tests

Wed, 01 Oct 2008 07:17:42 GMT

Looks like reinventing the weel May be better put this into PostBuild event? I prefer Agent Smith plugin for Resharper - it shows me when code convention is broken

Casey commented on Meta tests

Wed, 01 Oct 2008 07:01:19 GMT

Well I started reading it thinking "how ridiculous" ... but now I'm not so sure ... in the absense of FxCop or NDepend ... it is one way of ensuring coding standards are being applied, though I grant a rather ingenious one :)