Ayende @ Rahien

Andrey Shchekin commented on Inline Anonymous Visitors

Fri, 05 Sep 2008 20:04:32 GMT

I just understood what it reminds me of: Mock(mock => { mock.Expect(x => x.OnReferenceExpression(...)) .Callback(re => references.Add(re.Name)) }).Visit(condition) which is much uglier than what you propose, bt is not limited to visitors. Just rename Mock to something fitting, like Inline<>. As for uglyness, new Inline { { x => x.OnReferenceExpression(null), re => references.Add(re.Name) } }; I think with a ton of overloads for Add(,) it may be viable.

Ayende Rahien commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 22:46:49 GMT

Just like your code is doing, by the actual DepthFirstVisitor

configurator commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 22:42:38 GMT

How is this used, if you don't mind me asking? I mean, who calls that OnReferenceExpression method?

Ayende Rahien commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 22:35:36 GMT

That is exactly what I was referring to.

configurator commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 22:22:07 GMT

[NOTE: I have no idea what you are talking about. I have not built compilers (yet) and I do now know what visitors are. But...] I don't see why you can't make such a class: public class InlineVisitor : DepthFirstVisitor { public Action OnReferenceExpressionHandler { private get; set; } public void OnReferenceExpression(ReferenceExpression re) { OnReferenceExpressionHandler(re); } } which you would use exactly as you specified. Or is that exactly what you intended to do?

Ayende Rahien commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 20:00:21 GMT

Not really, this would work if and only if I wanted to run only over ReferenceExpression, and I want this over the entire AST.

ceilidhboy commented on Inline Anonymous Visitors

Tue, 02 Sep 2008 19:41:40 GMT

To make it even more concise, add a static utility method: ... InlineVisitor.Visit(condition, re => references.Add(re.Name));