Ayende @ Rahien

Andriy commented on What I am working on...

Fri, 29 Aug 2008 18:25:25 GMT

AR>I actually got a comment on that being an issue with the code, not reading it from app.config I thought you had asked how else you could make the code more confusing?

Ayende Rahien commented on What I am working on...

Fri, 29 Aug 2008 11:16:49 GMT

Trust me, I don't need someone else to point out the may faults here

Louis DeJardin commented on What I am working on...

Fri, 29 Aug 2008 06:33:31 GMT

No problem at all. I just thought it was funny to see, six weeks later, the opposite situation - an unsolicited code review coming back to you in the comments. Ironic, no?

meowh commented on What I am working on...

Fri, 29 Aug 2008 06:21:59 GMT

I've ran out of all my fingers trying to count principles of good code producing that were broken in this shippet. Do I have too few fingers? =)

Ayende Rahien commented on What I am working on...

Fri, 29 Aug 2008 04:49:42 GMT

Louis, Where is the double standard here? I am not willing to go over uninteresting code bases for free. If you are willing to pay, that is another matter. I am not seeing the problem here.

Louis DeJardin commented on What I am working on...

Fri, 29 Aug 2008 04:40:44 GMT

Hey, wait a second... http://www.ayende.com/Blog/archive/2008/07/15/Why-I-will-not-code-review-your-code.aspx "If the source isn't freely available, or if I don't find it interesting, then I would suggest contacting me for a consulting engagement, in which case I would be more than happy to go over any code base..." Isn't this a bit of a double standard? :)

Manoj Waikar commented on What I am working on...

Fri, 29 Aug 2008 01:51:42 GMT

No Ken, DT has hit the nail on its head. I am in a situation where the client doesn't want to use NHibernate because not many developers know it !!! I wish Oren (or anyone else) is not in such a situation.

Ken Blood commented on What I am working on...

Fri, 29 Aug 2008 00:19:08 GMT

Reading Oren being funny: Priceless! The one I can't figure out is DT's comment. Hope he was being sarcastic!

Yitzchok commented on What I am working on...

Fri, 29 Aug 2008 00:11:04 GMT

This is called "highly maintainable" code. And you can see all the logic right in one file like it should be. ;-)

Steve Campbell commented on What I am working on...

Thu, 28 Aug 2008 22:51:44 GMT

Its an example showing poorly factored code and some common programming mistakes. Excellent fodder for refactoring with a tool, or pre-interview screening.

Alex Simkin commented on What I am working on...

Thu, 28 Aug 2008 22:24:32 GMT

Fimally, I see a beautiful code on this blog. One nitpick though, I think that name 'Joe' in e-mail and message should be loaded from the systemwide string constatnt.

pb commented on What I am working on...

Thu, 28 Aug 2008 21:26:05 GMT

Obviously he's trolling, look at the comments. Trying to improve participation with something that isn't as difficult as his usual fare. Watch I can do it too: Abortion should be illegal and anyone who thinks otherwise is retarded and ugly.

DT commented on What I am working on...

Thu, 28 Aug 2008 20:16:39 GMT

Except for a few peculiarities this is excellent code requiring a minimum of training for new junior developers to maintain.

Jeff Tucker commented on What I am working on...

Thu, 28 Aug 2008 19:56:14 GMT

my eyes actually hurt from reading that. Unfortunately I've seen far worse. . .

Bryan commented on What I am working on...

Thu, 28 Aug 2008 15:52:11 GMT

It's an example for a book your writing.

grega g commented on What I am working on...

Thu, 28 Aug 2008 14:01:23 GMT

i just LOVE the personal touch that was put into this code "Joe forgot ... AGAIN" :D

meisinger commented on What I am working on...

Thu, 28 Aug 2008 13:50:36 GMT

BOO has really come a long way on a more serious note... i would make the private members "conStr" and "rates" readonly keep up the good work!

Dermot commented on What I am working on...

Thu, 28 Aug 2008 12:03:28 GMT

Ha ha, welcome to my world and the world of the majority of .net coders out there. http://www.amazon.com/Working-Effectively-Legacy-Robert-Martin/dp/0131177052 this book is your friend. enjoy

Ayende Rahien commented on What I am working on...

Thu, 28 Aug 2008 11:45:59 GMT

Reshef, I actually got a comment on that being an issue with the code, not reading it from app.config

Ray commented on What I am working on...

Thu, 28 Aug 2008 09:56:18 GMT

restart: goto restart Geez... never hoped to see it ever again... oO

Paul Batum commented on What I am working on...

Thu, 28 Aug 2008 09:12:34 GMT

I agree with Joe. Surely this code was written as an example of how things go bad, as the basis for some lesson.

ibrahim dursun commented on What I am working on...

Thu, 28 Aug 2008 08:37:21 GMT

Everything is a cycle. First, you want to write the perfect code, you reach there, and come back here again. "All this happened before and will happen again."

Reshef Mann commented on What I am working on...

Thu, 28 Aug 2008 07:41:51 GMT

I think that Oren is going to write a sequel to "Refactoring to patterns" and he is basing his all book on this code sample :-) Or maybe he just started working for a big company and he is trying to conform to their coding standards. But hey, not all is bad - at least the connection string is injected to the TaxCalculator and not read directly from app.config...

Blaise Braye commented on What I am working on...

Thu, 28 Aug 2008 06:51:54 GMT

goto 80ths !! I am now wondering why am I reading your post for a few months :(

Mike Brown commented on What I am working on...

Thu, 28 Aug 2008 06:48:02 GMT

Looks like you used that expression dsl you mentioned before to take some old code (probably vb.net) and spit out C#.

Doron Yaacoby commented on What I am working on...

Thu, 28 Aug 2008 06:04:24 GMT

I think Oren is working on an Auto-Refactor tool and this is the input to one of the tests :)

Joe commented on What I am working on...

Thu, 28 Aug 2008 04:14:03 GMT

You're trying to prove a point, probably of mal-practice. It's easier to show what seperation of conerns means, what single responsability is and what DI is when you start off with something bad.

Francois Germain commented on What I am working on...

Thu, 28 Aug 2008 03:31:16 GMT

I somehow remotely thought it was possible to write "VB6 like" code in C# but never dare to. :)

Conspiracy commented on What I am working on...

Thu, 28 Aug 2008 01:46:09 GMT

It's some sort of viral stuff. In the next week, he'll disclose the Rhino .

Josh Schwartzberg commented on What I am working on...

Thu, 28 Aug 2008 01:16:58 GMT

I really like that coding style, you don't have to search thru a bunch of classes and methods to figure stuff out.. it's all in front of your face