http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Wait, you mean you're gonna go through all this trouble of whining about how wrong it is, and not tell us the right way to write this test? Come on. http://ayende.com/3535/an-example-of-bad-test-part-2#comment5http://ayende.com/3535/an-example-of-bad-test-part-2#comment5Mon, 18 Aug 2008 17:56:11 GMTRob - I wouldn't worry about it too much. I've seen plenty of test cases just like that, and I think it is a great example. It might be good to post a link to what this test case got refactored into so we can all see magic at work. ;) http://ayende.com/3535/an-example-of-bad-test-part-2#comment4http://ayende.com/3535/an-example-of-bad-test-part-2#comment4Mon, 18 Aug 2008 13:52:46 GMTI spose my point is that this isn't a test in the literal sense - I just wanted to see if it would work and moreover give people something to comment on. http://ayende.com/3535/an-example-of-bad-test-part-2#comment3http://ayende.com/3535/an-example-of-bad-test-part-2#comment3Sun, 17 Aug 2008 18:47:42 GMTRob, This wasn't supposed to be a review of the code. This was supposed to be a good example to show bad testing practices. http://ayende.com/3535/an-example-of-bad-test-part-2#comment2http://ayende.com/3535/an-example-of-bad-test-part-2#comment2Sun, 17 Aug 2008 03:17:37 GMT... and as I mentioned in your last post (and on my video, and on my blog) - this is a spike. This test is coming out. I happened to put it in a unit test as I wanted to make sure the execution was happening as I wanted to. There is a lot wrong here - but it's a SPIKE. http://ayende.com/3535/an-example-of-bad-test-part-2#comment1http://ayende.com/3535/an-example-of-bad-test-part-2#comment1Sun, 17 Aug 2008 03:04:44 GMT