http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660@Oren - Ahh, that sheds a bit more light on things. Too bad, though, as I have often found that refactorings to clean up Demeter / Tell, Don't Ask violations end up introducing nice clear names for the actions being taken by the code. In any case, thanks for taking the time to post up some of your favorite tidbits from within Rhino.Mocks. For folks like me who love using Rhino.Mocks but who haven't had an opportunity to dig into its code, the little bits of insight into its inner workings are greatly appreciated. http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment6http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment6Mon, 14 Jul 2008 02:47:24 GMTJermey, ExpectationVerificationInformation is a DTO, it contains just the expectation and the actual arguments made. http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment5http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment5Mon, 14 Jul 2008 02:29:12 GMTI think it's an ingenious approach for adding AssertWasCalled to a record replay framework without completely redoing the plumbing. I applaud you for that. It's very complicated though and someone who is not totally familiar with the internals of Rhino.Mocks will find it scary. Scary doesn't mean bad, it just means that its not understandable at first glance. It requires some digging and who knows what you'll find. http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment4http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment4Mon, 14 Jul 2008 01:19:44 GMTThe scary thing about this is it's getting to the point were I expect no less from you Oren. You're code repeatedly makes me look at how we can achieve what is required in different (and better) ways - you take thinking outside the box to a whole new level. Nice code, great way to solve the problem and I am looking forward to being able to use it if I ever get round to building some .NET 3.5 bits :) http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment3http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment3Sun, 13 Jul 2008 20:19:22 GMTWhile I'm sure it will take me a bit to get my head fully wrapped around everything that is going on in GetExpectationsToVerify, I do have a small comment about AssertWasCalled: Law of Demeter violation alert! You begin a minor violation at the foreach line, which gets much more serious when ".Expected." starts showing up repeatedly. If these things were factored into their proper locations (probably everything from the foreach on down first being moved into ExpectationVerificationInformation, and then all of the ".Expected." blocks moved into their appropriate types), with clear names assigned to each new member generated in the process, perhaps that Rhino.Mocks contributor, and others, would have an easier time building up an understanding of the code. http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment2http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment2Sun, 13 Jul 2008 19:01:41 GMT"Extending Rhino Mocks with Rhino Mocks" - No kidding, sometimes I look at some object implementation in a system and wonder why I bother with an implementation if I could instead use Rhino Mocks, declare what I want the instance to do and be done with it. http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment1http://ayende.com/3412/beautiful-nontrivial-code-rhino-mocks-3-5s-assertwascalled#comment1Sun, 13 Jul 2008 09:58:48 GMT