http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Expect is an Assert. You should generally be asserting one thing in a test. If you are asserting that an interaction occurred, you should use Expect/Verify or AssertWasCalled. If you testing state, you should *not* use these things, as then you are testing more than one thing in your test. With regards to your finding Expect/Verify more natural, that's fine, but please don't call it AAA. That will only confuse the issue more than it already is. I didn't mind Expect/Verify as much as I do now until I started writing context/spec style tests. At that point the AAA syntax became a necessity. Even before then though, I liked being able to look at the bottom of the test and see what should have happened... what I was testing. http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment5http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment5Wed, 02 Jul 2008 07:05:35 GMTI am not following on the first statment. For the second, I find it more natural to have an expectation before the interaction http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment4http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment4Wed, 02 Jul 2008 06:50:09 GMTWhat? I would hope that unless you're testing the interaction you're not going to use Expect *OR* AssertWasCalled. How is it more natural to hide the assertion in the middle of the test? http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment3http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment3Wed, 02 Jul 2008 06:48:30 GMTThis test test the _interaction_, as such, I find it much more natural to use Expect() and verify than to assert on that. About ThenReturn(2), good idea, but this happen rarely enough that is is not a real concern of mine. http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment2http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment2Wed, 02 Jul 2008 06:38:35 GMTYou said you "use AAA for really nice syntax", but I don't see that in this test. The new extension methods you added are not AAA in my opinion unless you actually use AssertWasCalled. The whole point of our push for AAA in a mocking was to move away from setting up expectations in the middle of the test (like you did right before your replay) so that the test would be easier to follow. Out of curiousity, why is your ReplayAll in the middle of your stubs? Would it be just as functional before the Run()? I think having to use partial mocks is generally a smell. Most of the time you have to use them it's because you're violating SRP. This is a perfect example of that. I'd consider moving the Command creation into a factory. The two ordered stubs after the ReplayAll are difficult to follow as well. How about a ThenReturn() method? foo.Stub(x=>x.Bar()).Return(1).ThenReturn(2); And no, I can't send a patch for this at this time :) http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment1http://ayende.com/3398/advance-mocking-with-rhino-mocks-3-5#comment1Wed, 02 Jul 2008 06:13:48 GMT