http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660wow.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment17http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment17Thu, 14 Jul 2011 06:23:09 GMTShould have said "For one thing..."http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment16http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment16Thu, 14 Jul 2011 03:08:08 GMTFor in thing, I suspect the developer's first language isn't English (nor their 2nd or 3rd perhaps... :) ). It seems that "Change" is a typo for "Charge"... but still.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment15http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment15Thu, 14 Jul 2011 03:07:17 GMTAs I see it, one reason to cast a null to some object would be if we had a function that expected a certain object type as a parameter. The compiler would then need the cast to decide for the correct function. But in the Microsoft example, I really don't understand it.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment14http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment14Wed, 13 Jul 2011 21:09:20 GMTCasting null may be used in two cases: 1. For generic type inference when compiler cannot figure out type, and 2. When trying to use null as a result for the ternary operator to avoid "no implicit conversion" error. However, this is so 90's. Cool guys should use default(...) in such cases. http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment13http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment13Wed, 13 Jul 2011 20:04:14 GMTIs this really how you should be performing this operation in an "N-Layer" application? Why not just encapsulate that saving logic (i.e. business logic!) into your service itself. What if someone provided an invalid account to the method (etc etc)?: public void LockAccount(string acctNum) { ServiceResult result = BankingService.LockAccount(acctNum); if (result.WasSuccessful) { // do something (display message, redirect, etc.) return RedirectToAction("Index"); } else { // set errors/warnings/alerts/whatever // return view model or some alert mechanism base.Alert(result.Errors, "Sorry, we could not lock the account due to some errors:"); return View(); } } Or something to that effect (i.e. encapsulating this saving stuff into the service itself) so that consumers of your service layer don't need to manually save entities? All of that code smells wrong to me.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment12http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment12Wed, 13 Jul 2011 20:01:44 GMTWho every wrote/reviewed/verified this code should not be allowed next to an IDE http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment11http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment11Wed, 13 Jul 2011 16:22:12 GMTWell, a cast of null can be done in order to remind you what kind of type class you are dealing with. It does not heart. It can be a matter of readability. For instance, I saw similar 'null casting' in PEX & MOLES code. In any case, I beleive that most of that code is outdated as they are working on V2.0 code. That code review is part of V1.0 Sample.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment10http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment10Wed, 13 Jul 2011 14:21:24 GMTHaha this is just embarrassing.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment9http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment9Wed, 13 Jul 2011 13:51:22 GMT@Jay This is what Ayende ment as casting of null: if (bankAccount == (BankAccount)null) {http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment8http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment8Wed, 13 Jul 2011 13:42:30 GMTI don't quite understand the casting of null part??http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment7http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment7Wed, 13 Jul 2011 13:04:41 GMTSigh, and then customers frown because the argumentation and opinions expressed to them are so detached from Microsoft. The null-cast alone shows blatant ignorance to what the developer is actually doing. I have been wondering lately, did you find anything remotely positive about the whole "official guidance"?http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment6http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment6Wed, 13 Jul 2011 13:01:44 GMTIf I'm reading this right, the LockAccount method also unlock locked accounts.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment5http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment5Wed, 13 Jul 2011 12:42:59 GMTWant to learn all the presented internals, how they _should_ be implemented, in terms of locking, tracking, states? Read NHibernate code and _learn_. The wrap around wrap around ORM. Gosh, are they paid for each line of code (additional bonus for ctrl+c, ctrl+v?http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment4http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment4Wed, 13 Jul 2011 12:16:07 GMTWith all respect to the people who coded this, but it looks like it was coded by an intern. Very sloppy stuff.http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment3http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment3Wed, 13 Jul 2011 11:36:55 GMTBetter questions are why LockAccount is always negating the lock status, allowing LOCKaccount also to unlock the account if it was already locked. And why is a entity only marked 'modified' if changeTracker is set? Does this mean that if account.StartTrackingAll() isn't called that entity is never marked modified, but it is actually saved to the database?? And most importantly. If you lock an account, why on earth would you want to redirect the user to a transfer money page? http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment2http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment2Wed, 13 Jul 2011 09:29:59 GMTceremony, ceremony ceremony... why make patterns easy to work with? I mean, if you're MS - if your customers are learning patterns that are used in other languages - that might mean they have transferable knowledge. _This_ is what this is all about. Take the EntLib pile of old *shit* policy injection anyone?! and the EntLib Data Access Application Block!?!? A _lump_ of code that actually makes the task at hand 10000% harder than it would have been without it - while also completely screwing with the whole layout of your system.... NICE! Honestly - what the hell were they thinking?! http://msdn.microsoft.com/en-us/magazine/cc163766.aspxhttp://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment1http://ayende.com/33793/review-microsoft-n-layer-app-sample-part-viii-crud-is-so-90s#comment1Wed, 13 Jul 2011 09:12:55 GMT