Ayende @ Rahien

Denis commented on Answer: How many tests?

Thu, 19 Jun 2008 21:46:41 GMT

It seems that the size of the test class compared to the size of the implementation class is going to frighten people. See http://www.dotnetguru.org/modules.php?op=modload&name=News&file=article&sid=1090 (in french). I think you could underline that some of the code in the test class is not related to unitary testing GetLatest(). Many lines setup and test the persistance layer (can_save, can_load). Shouldn't we assume that the persistance layer (the Inner property) is tested elsewhere by another set of unit tests ?

Alexander GroÃŸ commented on Answer: How many tests?

Mon, 16 Jun 2008 16:32:51 GMT

Sounds reasonable. That's also what I did, although it makes the registration a bit more complicated.

Ayende Rahien commented on Answer: How many tests?

Mon, 16 Jun 2008 16:18:51 GMT

In this case, I don't have different impl, so I don't care. If I would, I would register WebcastRepository twice, once for IWebcastRepository and the second for IRepository

Alexander Groß commented on Answer: How many tests?

Mon, 16 Jun 2008 15:25:58 GMT

My question stems from the following use case: Say you're overriding methods of RepositoryDecorator in a derived class to have further validation happening before a save/insert takes place. I would want users of the repository make "fall into the pit of success" (via Scott Hanselman) such that calls to Repository.Save are forced through the custom repo. The problem I see is that you now have a) a custom repo that should be invoked when Repository is used b) an extended repo with methods like GetLatest() both implemented by one class, but accessible through two Windsor service interfaces. From an application point of view you could now use one of the three APIs above (a, b, c). Which one do you prefer? Alex

Ayende Rahien commented on Answer: How many tests?

Mon, 16 Jun 2008 14:05:00 GMT

Here is my full configuration file: import Castle.MonoRail.Framework import Castle.MonoRail.WindsorExtension import Rhino.Commons.Facilities from Rhino.Commons.ActiveRecord import file from Configuration.boo facility MonoRailFacility facility RhinoTransactionFacility facility ActiveRecordUnitOfWorkFacility: assembly = "HibernatingRhinos" for type in AllTypesBased of IController("HibernatingRhinos"): component type.Name, type for type in AllTypesBased of ViewComponent("HibernatingRhinos"): component type.Name, type fromHibernatingRhinosServices = {t as System.Type | t.Namespace == "HibernatingRhinos.Services"} for type in AllTypes("HibernatingRhinos") \ .Where(fromHibernatingRhinosServices): component type.GetFirstInterface(fromHibernatingRhinosServices), type SetupConfigurationProperties()

Alexander Groß commented on Answer: How many tests?

Mon, 16 Jun 2008 14:01:18 GMT

How do you register WebcastRepository in your Windsor config? Because the class implements two interfaces (IRepository and IWebcastRepository for the "special" methods) it actually implements two services. Do you register two services for the class? (Not sure if this is possible, though.) From the application/controller point of view, when do you use a) Repository.SomeMethod() b) IoC.Resolve(IWebcastRepository).SomeMethod() c) IoC.Resolve(WebcastRepository).SomeMethod() ? Thanks, Alex

Ayende Rahien commented on Answer: How many tests?

Sun, 15 Jun 2008 11:29:22 GMT

I am using it, it is working well enough for most common scenarios. We are still missing some parts in the more complex queries, but we are working on that.

andy commented on Answer: How many tests?

Sun, 15 Jun 2008 09:02:33 GMT

looks like you're using NHibernate.Linq. what is the state of the project and would you also use it by now in a real project? When there will be the first release?

Ayende Rahien commented on Answer: How many tests?

Fri, 13 Jun 2008 15:27:32 GMT

This is part of Rhino Commons, it is a way to run under a transaction. the ()=> is a labmda, a C# 3.0 concept

Yeroc commented on Answer: How many tests?

Fri, 13 Jun 2008 14:04:49 GMT

Forgive my ignorance. I"ve following your blog after learning how nice Rhino Mocks was. Could explain this line of code? I'm unfamiliar with much of what's going on here? With.Transaction(() => webcastRepository.Save(webcast)); I assume With is one of the Rhino.Common classes? What is "() => " doing? I've never seen that syntax in C#. Thanks

Ayende Rahien commented on Answer: How many tests?

Thu, 12 Jun 2008 15:04:01 GMT

That is why I have SystemTime.Now()

Bill Pierce commented on Answer: How many tests?

Thu, 12 Jun 2008 14:57:03 GMT

Don't know that it should appear in your tests but the only other concern would be issues related to not using UTC dates when working with 'Latest' data.

Ayende Rahien commented on Answer: How many tests?

Thu, 12 Jun 2008 13:31:44 GMT

Hm, thinking about it, the test that test for no published results is the same, the code doesn't know if there are unpublished webcasts, after all

Ayende Rahien commented on Answer: How many tests?

Thu, 12 Jun 2008 13:09:15 GMT

First or default would return null, yes. I actually forgot about this

Richard Lennox commented on Answer: How many tests?

Thu, 12 Jun 2008 12:26:42 GMT

I am interested in why you haven't tested the default when there are no Webcasts in the repository? I can see that your GetLatesMethod has a FirstOrDefault() does the method for this test cover this scenario?

Vijay Santhanam commented on Answer: How many tests?

Thu, 12 Jun 2008 10:46:40 GMT

I said 7, I was the closest I think.