http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Oh so subtle. It cracks me up to see such a simple and seemingly pointless test catch such a serious flaw. http://ayende.com/3353/those-silly-tests#comment8http://ayende.com/3353/those-silly-tests#comment8Fri, 06 Jun 2008 14:46:30 GMTDeparcq, DING DING DING DING! That is the error that the test exposes http://ayende.com/3353/those-silly-tests#comment7http://ayende.com/3353/those-silly-tests#comment7Fri, 06 Jun 2008 08:35:10 GMTI'm guessing the ReadAll method is returning an empty string in your test method as you didn't flush the stream in the Execute method? http://ayende.com/3353/those-silly-tests#comment6http://ayende.com/3353/those-silly-tests#comment6Fri, 06 Jun 2008 08:19:44 GMTI mean, if you want to verify the version number, you'd better not to use the same way of the implementation to get the version number of the assembly -- typeof(VersionCommand).Assembly.GetName().Version testers should try them best to make the test fail. Or I misunderstood something? http://ayende.com/3353/those-silly-tests#comment5http://ayende.com/3353/those-silly-tests#comment5Fri, 06 Jun 2008 07:58:49 GMTYou get the version the same way with "Execute"? http://ayende.com/3353/those-silly-tests#comment4http://ayende.com/3353/those-silly-tests#comment4Fri, 06 Jun 2008 07:46:21 GMTI am assuming that Writer.WriteLine writes to the memory stream. Your test is valid because you want to make sure that what you write to the stream is done so correctly by Writer.WriteLine (and that the writer is actually writing to your stream), which can be tested by reading the stream and checking the content. You might also be checkin that writing to the stream has left the position in the stream on the right place for reading it afterwards. (guessing a bit here because I don't know what the specifications are and how you want to work with the stream, do you keep it open or not , do you seek to the beginning etc) Also, I am hoping that you don't have another VersionCommand class in another assembly, and that you are testing here if your using statement is correct in the unit test. http://ayende.com/3353/those-silly-tests#comment3http://ayende.com/3353/those-silly-tests#comment3Fri, 06 Jun 2008 07:45:22 GMTYes, it compiles. + for string == + .ToString(), \r\n are part of the protocol, so we will leave that aside http://ayende.com/3353/those-silly-tests#comment2http://ayende.com/3353/those-silly-tests#comment2Fri, 06 Jun 2008 07:14:28 GMTI can spot two potential points: 1. The Version property returns System.Version, which is not plussable with string (does that even compile?). 2. "\r\n" should be Environment.NewLine, or the test will fail on non-Windows environments. But from the test name, I understand it has to do with caching, so IDK. http://ayende.com/3353/those-silly-tests#comment1http://ayende.com/3353/those-silly-tests#comment1Fri, 06 Jun 2008 07:11:08 GMT