http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660pb, I will make no comment about TFS at this time. http://ayende.com/3210/challenge-find-the-version#comment10http://ayende.com/3210/challenge-find-the-version#comment10Tue, 25 Mar 2008 07:30:57 GMTWhat's up with this? A 2d return array that always has only one element in each array? BranchRelative[][] branches = SourceControlService.QueryBranches(serverUrl, credentials, null, new ItemSpec[] { spec }, branchChangeset); string oldName = branches[0][branches[0].GetUpperBound(0)].BranchFromItem.item.Substring(rootPath.Length); http://ayende.com/3210/challenge-find-the-version#comment9http://ayende.com/3210/challenge-find-the-version#comment9Tue, 25 Mar 2008 00:32:39 GMTWow, you incorporated my code quickly! ;) http://ayende.com/3210/challenge-find-the-version#comment8http://ayende.com/3210/challenge-find-the-version#comment8Mon, 24 Mar 2008 19:58:21 GMTRik, take a look at: http://www.codeplex.com/SvnBridge/SourceControl/FileView.aspx?itemId=94304&changeSetId=17051 GetVersionForDate() Amazing http://ayende.com/3210/challenge-find-the-version#comment7http://ayende.com/3210/challenge-find-the-version#comment7Mon, 24 Mar 2008 19:56:07 GMTI think I might now have the same worst case as yourself. class TFSRepository { private const TFSFirstRevisionId = 1; // Assumption. private DateTime initialRevisionDate; private DateTime InitialRevisionDate() { if (initialRevisionDate == null) { initialRevisionDate = sourceControl.QueryLog( new ChangesetVersionSpec(TFSFirstRevisionId), new ChangesetVersionSpec(TFSFirstRevisionId), 1 ).History[0].CommitDateTime; } return initialRevisionDate; } private void AssertRepositoryInitialized(int latestRevisionId) { if (latestRevisionId < TFSFirstRevisionId) throw new RepositoryNotYetBornException(); } private DateTime RevisionDateTime(int revisionId) { DateTime currentRevisionDate = sourceControl.QueryLog ( new ChangesetVersionSpec(revisionId), new ChangesetVersionSpec(revisionId), 1 ).History[0].CommitDateTime; } public int GetVersionForDate(DateTime date) { int currentRevisionId = sourceControl.GetLatestId(); AssertRepositoryInitialized(currentRevisionId); DateTime initialRevisionDateTime = RevisionDateTime(TFSFirstRevisionId); DateTime currentRevisionDateTime = RevisionDateTime(currentRevisionId); if (date < InitialRevisionDateTime) throw new DateBeforeFirstRevisionException(date); if (date > currentRevisionDateTime) throw new DateAfterCurrentRevisionException(date); return sourceControl.QueryLog ( new DateVersionSpec(date), new ChangesetVersionSpec(currentRevisionDateTime), ).History[0].ChangeSetId - 1; } } http://ayende.com/3210/challenge-find-the-version#comment6http://ayende.com/3210/challenge-find-the-version#comment6Mon, 24 Mar 2008 19:46:07 GMTIn one case, it throw something useful (date before anything in the repos), in the other, it just do random things. In your code, it would return the second most recent commit http://ayende.com/3210/challenge-find-the-version#comment5http://ayende.com/3210/challenge-find-the-version#comment5Mon, 24 Mar 2008 19:15:12 GMTDoes it throw useful exceptions (e.g. something like DateRangeException rather than BadCallException)? If so, I'd be tempted to catch them and report them to the caller or user. It would be more 'correct' to ask TFS for the information first, but if cutting down on wire traffic (or new TCP connections - it can't be that bad, can it?) is that important then I think it's fair to break the "exceptions are for stuff you couldn't anticipate" rule. I suppose the repository's first commit isn't going to change, so you can cache that, at least. http://ayende.com/3210/challenge-find-the-version#comment4http://ayende.com/3210/challenge-find-the-version#comment4Mon, 24 Mar 2008 19:07:24 GMTYou are missing a couple of corner cases, yes. Handling requests for dates before the repository started, and handling dates after the last commit. Both would cause exceptions in the API http://ayende.com/3210/challenge-find-the-version#comment3http://ayende.com/3210/challenge-find-the-version#comment3Mon, 24 Mar 2008 19:00:43 GMTpublic int GetVersionForDate(DateTime date) { return sourceControl.QueryLog ( new DateVersionSpec(date), new ChangesetVersionSpec(DateTime.Now), 1 ).History[0].ChangeSetId - 1; } + corner case handling Is that only 1 call or am I overestimating the TFS API? http://ayende.com/3210/challenge-find-the-version#comment2http://ayende.com/3210/challenge-find-the-version#comment2Mon, 24 Mar 2008 18:54:57 GMTTalk directly to the TFS cube instead? http://ayende.com/3210/challenge-find-the-version#comment1http://ayende.com/3210/challenge-find-the-version#comment1Mon, 24 Mar 2008 17:39:15 GMT