http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660pb, As I said, there is a patch to add locking. The table/column combo ? I am not following. http://ayende.com/3207/nservicebus-review#comment7http://ayende.com/3207/nservicebus-review#comment7Tue, 25 Mar 2008 07:31:34 GMTI meant the lack of locking around the gets and adds on a static collection. Or do you mean that is handled by the table/column name combo? http://ayende.com/3207/nservicebus-review#comment6http://ayende.com/3207/nservicebus-review#comment6Tue, 25 Mar 2008 00:34:56 GMTMike, Yes, I meant Retlang. I updated the post http://ayende.com/3207/nservicebus-review#comment5http://ayende.com/3207/nservicebus-review#comment5Mon, 24 Mar 2008 06:51:29 GMT"Publish and Subscribe looks remarkably like their equivalent in Relang. Same model, after all." Did you mean Retlang? The models are similar but the purpose of the projects is quite different. Retlang is written specifically for in-process messaging and threading. http://ayende.com/3207/nservicebus-review#comment4http://ayende.com/3207/nservicebus-review#comment4Mon, 24 Mar 2008 02:21:36 GMTbp, Take a closer look at Deserialize. Note what it concatenate, the table name and the column names. Those are coming from the server configuration. I was talking about involving the container in the deserialization process. The code in Pesister is SQL Server specific. The usage on sagaIdsToClear is not the way I would do it, and there is a patch to fix this, but it tends to work well enough in most cases. http://ayende.com/3207/nservicebus-review#comment3http://ayende.com/3207/nservicebus-review#comment3Mon, 24 Mar 2008 02:10:11 GMTSorry, just looked at the links for Deserialize and TimeoutMessageHandler. Am I retarded or is 1) a good example of SQL injection vulnerability and 2) a good example of not thinking about multi threaded scenarios when using a static variable? Is SET NOCOUNT ON valid on all DB engines? http://ayende.com/3207/nservicebus-review#comment2http://ayende.com/3207/nservicebus-review#comment2Mon, 24 Mar 2008 01:54:38 GMTYou might enjoy this read: http://code.google.com/edu/parallel/index.html http://ayende.com/3207/nservicebus-review#comment1http://ayende.com/3207/nservicebus-review#comment1Mon, 24 Mar 2008 01:49:04 GMT