Ayende @ Rahien

Paul Stovell commented on Code review WTF, number N

Tue, 13 Nov 2007 23:15:33 GMT

@Markus: class LogHelper { public static void Warn(Exception ex, string format, params object[] args) { Logger.WarnFormat(ex, format, args); while (ex.InnerException != null) { ex = ex.InnerException; Logger.Info("Inner Exception", ex); } } } Now in the many places you use that code, you can have: try { ActiveRecordMediator.Save(foo); } catch (Exception ex) { LogHelper.Log("Error saving Foo {0}", foo.Name, ex); } } There are thousands of libraries which require multiple lines to do something. There's no reason you should write those multiple lines twice.

Markus Zywitza commented on Code review WTF, number N

Tue, 13 Nov 2007 15:08:56 GMT

Windsor's LoggingFacility with loggingApi="console" obviously doesn't.

Ayende Rahien commented on Code review WTF, number N

Tue, 13 Nov 2007 14:58:26 GMT

Well, most of the logging frameworks that I am aware of will handle this correctly.

Markus Zywitza commented on Code review WTF, number N

Tue, 13 Nov 2007 14:46:57 GMT

>What is Logging? No special product, I simply wrote it with a capital letter because I'm accustomed to that practice. German language capitalizes all nouns, hence "Logging" instead of logging.

Ayende Rahien commented on Code review WTF, number N

Tue, 13 Nov 2007 14:40:47 GMT

What is Logging?

Markus Zywitza commented on Code review WTF, number N

Tue, 13 Nov 2007 14:39:43 GMT

Hmm, it seems that the fact that I always use Logging now avenges. Perhaps I should have just used Console.WriteLine(exception) :-(

Ayende Rahien commented on Code review WTF, number N

Tue, 13 Nov 2007 14:18:52 GMT

Markus, is there a reason that you are doing it this way? ex.ToString() gives you the inner exception as well, after all

Markus Zywitza commented on Code review WTF, number N

Tue, 13 Nov 2007 14:10:41 GMT

  
try
  
{
  
	ActiveRecordMediator.Save(foo);
  
}
  
catch (Exception ex)
  
{
  
	Logger.WarnFormat(ex, "Error saving Foo {0}", foo.Name);
  
	while (ex.InnerException != null)
  
	{
  
		ex = ex.InnerException;
  
		Logger.Info("Inner Exception", ex);
  
	}
  
}

If you count the brace lines, it's 6 lines for the exception, too. But absolute necessary unless Castle.ActiveRecord.Framework.ActiveRecordException: Could not perform Save for Foo at ... in ... is enough for you to see the error's cause, which isn't the case for me.

Grimace of Despair commented on Code review WTF, number N

Tue, 13 Nov 2007 11:49:10 GMT

"Using a naming convention where the company name is prefixed to all local variables" I've witnessed a Database that was prefixed with the _DEVELOPERS_ initials, as were all tables in it... I still shiver while writing this.

Paul Stovell commented on Code review WTF, number N

Tue, 13 Nov 2007 11:46:19 GMT

One subject in basic pure math that I wish all developers would take is factorization - taking an equation, recognising and removing the duplicates and simplifying. I still can't fathom how a developer can see the same thing over and over again - like 6 lines of code repeated every single time an exception needs to be logged - and not recognize that they can factor it out. Paul