http://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660Ah, just spotted a potential issue for me at least... Marshal.GetExceptionCode() won't work under asp.net medium trust. Back to delegates :) http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment18http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment18Mon, 25 Jun 2007 11:32:38 GMTProvided this is reliable (something I'm not yet convinced of), this is going to simplify a whole bunch of things in my codebase. Interestingly, you could do this in a supported way in Delphi, and I was talking to a friend recently to see if it was possible in .NET. I wonder, does referencing Marshal introduce any odd dependencies that wouldn't normally be present? If so, this could explain why MS didn't use it themselves in System.Transactions. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment17http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment17Wed, 20 Jun 2007 20:36:10 GMTI would go with the more explicit syntax reason http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment16http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment16Wed, 20 Jun 2007 19:26:04 GMTI wonder why Microsoft did not use this for System.Transactions? Do they know something we don't? Did they simply not think of it? Or, did they discard it because they felt that a more explicit syntax was easier for us to understand? http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment15http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment15Wed, 20 Jun 2007 19:12:30 GMTYou aren't missing much. That is the intent of the code. The ideas behind With.Transaction, etc are to handle the case of thrown exception, so having a good way to handle that is very nice. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment14http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment14Wed, 20 Jun 2007 14:17:03 GMTI'm a bit slow to catch on as well. Is the intention of ExceptionDectector to allow you to dispose differently depending on wether or not an exception was thrown? I would need a use case to more fully understand this feature. @inoodle: I would contend that Within.UnitOfWork is a much clearer syntax, even with delegate { } tacked on the end. @Jeff Perrin: What if you do not want to implicitly commit the transaction if no exception is thrown? The current functionality of SqlTransaction is to implicitly Rollback if no Commit was issued. I would prefer more descriptive syntaxt like using(Transaction trans = new Transaction(CommitStyle.Implicit)) { } What is my feeble brain missing? http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment13http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment13Wed, 20 Jun 2007 12:38:27 GMTayende, this is what MSDN lib says: GetExceptionCode is exposed for complier support of structured exception handling (SEH) only. If called before an exception is thrown, this method returns 0xCCCCCCCC. Ok, so firstly, == 0 seems to be wrong. Then, which exception? The last exception on this thread? The innermost exception in the current scope? The exception in the innermost scope? You'd have to make and test a whole lot of assumptions here. What about portability? Mono? I have to say I'd rather write VoteToCommit() than build on such weak assumptions... http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment12http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment12Wed, 20 Jun 2007 10:36:15 GMTOne last thought... Is this hack portable? What will Mono do? I assume it doesn't necessarily implement its exception handling using Win32 SEH. Therefore I wouldn't be too surprised if the Marshal.GetExceptionCode() method were unimplemented or not meaningful... http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment11http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment11Wed, 20 Jun 2007 09:58:31 GMT@Jeff Perrin, Yep, I've forgotten Transaction commits too. Wouldn't it be nice to have Smalltalk blocks in C# instead of these clunky control structures? Anonymous delegates and even lambdas don't quite cut it. Oh well. Still, the exception detecting using trick will be very useful indeed... My only concern is that its behavior may surprising to the unwary. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment10http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment10Wed, 20 Jun 2007 09:21:09 GMTThen why don't you write the code in the post using the use case, in the first place? There's so much going on in comments on this site, all the time, and you write 187 posts a day, average. When wife and kid start to complain, I'll give them your e-mail :) http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment9http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment9Wed, 20 Jun 2007 07:20:16 GMTDerik, Previously to do a "using" with a transaction you had to do something like this: using(Transaction t = new Transaction()){ //important stuff t.VoteToCommit(); } Using this technique it looks like you don't need the VoteToCommit() call, which is good because I always forgot to add that, and then spent hours debugging why my tables weren't being updated. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment8http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment8Wed, 20 Jun 2007 04:54:37 GMT@Derik, It enable this code: using(new Transaction()) { /// blah } Where the transaction can decide if it wants to commit or rollback based on the exception status. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment7http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment7Wed, 20 Jun 2007 04:30:00 GMT@inoodle, Absolutely! http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment6http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment6Wed, 20 Jun 2007 04:23:21 GMTDoh! Meant within the using statement. http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment5http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment5Wed, 20 Jun 2007 01:11:35 GMTOh neat! Mind that I think it can be fooled... What happens if your using statement appears within an exception handler? Will you be able to tell whether the exception occurred within or outside the exception handler? http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment4http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment4Wed, 20 Jun 2007 01:10:53 GMTOk, What am i missing? In what scenario is this needed? http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment3http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment3Wed, 20 Jun 2007 01:08:05 GMTThat's some sweet stuff :) how come I haven't heard of it until now! http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment2http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment2Wed, 20 Jun 2007 00:56:49 GMTOoooo nice one. That puts: using(new UnitOfWork()) {} back on the table - instead of Within.UnitOfWork(anon delegate etc). http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment1http://ayende.com/2577/did-you-know-find-out-if-an-exception-was-thrown-from-a-finally-block#comment1Tue, 19 Jun 2007 23:32:01 GMT