Ayende @ Rahienhttp://ayende.comAyende @ RahienCopyright (C) Ayende Rahien 2004 - 2021 (c) 202660pd commented on Defensive coding is your friendJust wondering...Ayende writing fragile tests? This is not best practice.http://ayende.com/160898/defensive-coding-is-your-friend#comment9http://ayende.com/160898/defensive-coding-is-your-friend#comment9Fri, 15 Feb 2013 12:18:40 GMTJanus commented on Defensive coding is your friendAyende, is that you?....http://ayende.com/160898/defensive-coding-is-your-friend#comment8http://ayende.com/160898/defensive-coding-is-your-friend#comment8Wed, 13 Feb 2013 08:28:22 GMTDaniel Wonisch commented on Defensive coding is your friendStill this seems to me as a nasty workaround instead of a real solution, what might be OK for test code but wouldn't be acceptable in production code. @Daniel: I have to be on Serhiy side of view. Since you do not want the developer to enable or disable fiddler all the time, but let the system take the decision for you, a better signature for that method would be GetFiddlerUrlOrDefault(). http://ayende.com/160898/defensive-coding-is-your-friend#comment7http://ayende.com/160898/defensive-coding-is-your-friend#comment7Tue, 12 Feb 2013 19:46:13 GMTDuke commented on Defensive coding is your friendMmmm Now the code is smart enough to not fail the test if we didn’t do things right. Is that really a good thing? It doesn't sound it. Feels like the sort of thing which could lead to false positives, thinking you were actually testing something when internally it was circumventing it. http://ayende.com/160898/defensive-coding-is-your-friend#comment6http://ayende.com/160898/defensive-coding-is-your-friend#comment6Tue, 12 Feb 2013 15:44:55 GMTDaniel Lang commented on Defensive coding is your friend@Serhiy, this is why you can and should use named parameters in these cases, like GetServerUrl(fiddler:true)http://ayende.com/160898/defensive-coding-is-your-friend#comment5http://ayende.com/160898/defensive-coding-is-your-friend#comment5Tue, 12 Feb 2013 15:09:29 GMTSerhiy Kalinets commented on Defensive coding is your friendbool args do not add clarity to the code. When you catch GetServerUrl(true) in the code it may be tricky to figure out what that true means without looking at method signature.http://ayende.com/160898/defensive-coding-is-your-friend#comment4http://ayende.com/160898/defensive-coding-is-your-friend#comment4Tue, 12 Feb 2013 14:01:13 GMTGilligan commented on Defensive coding is your friendI did a similar thing recently where I was testing seeding the database. This meant destroying and rebuilding it from NHibernate. However the config file was pointing to the QA database so it got wiped and needed to be restored from backup. Now I have an assertion in TestInitialize that ensures the database is local before seeding it with test data. http://ayende.com/160898/defensive-coding-is-your-friend#comment3http://ayende.com/160898/defensive-coding-is-your-friend#comment3Tue, 12 Feb 2013 12:04:57 GMTJonas commented on Defensive coding is your friendI wouldn't call this defensive coding. You created testable code WAY different. Defensive coding IMHO is ONLY EVIL... But we migh mean different things,. To me defensive coding is what Frank is describing as paranoid coding :) /Jonashttp://ayende.com/160898/defensive-coding-is-your-friend#comment2http://ayende.com/160898/defensive-coding-is-your-friend#comment2Tue, 12 Feb 2013 11:42:09 GMTFrank Quednau commented on Defensive coding is your friendAs with every good advice, there is the evil counterpart: paranoid coding, when you litter your code with excessive null checks on things that cannot be null, catch exceptions you cannot handle, etc.http://ayende.com/160898/defensive-coding-is-your-friend#comment1http://ayende.com/160898/defensive-coding-is-your-friend#comment1Tue, 12 Feb 2013 11:23:30 GMT