Ayende @ Rahien

Ayende Rahien commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 18:21:51 GMT

Ken, This code: var sw = Stopwatch.StartNew(); for (int i = 0; i < 1000 * 1000; i++) { var tcs = new TaskCompletionSource(); tcs.SetResult(null); } Console.WriteLine(sw.ElapsedMilliseconds); Completes in less than 150 ms, so I think that we are good on that regard. As for anyhow anywhen for the error, no. But I am pretty sure that there is a test that will catch it if it will happen.

Ken Egozi commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 17:43:37 GMT

Without looking at your code, I'd guess that CompletedTask will generate a TaskCompletionSource and set its value. A new TaskCompletionSource() is hardly equivalent to new object(). A Task Completion Source etc is hardly a simple object(). who knows what it is doing internally during the construction of the tcs. e.g. Brad Wilson on http://bradwilson.typepad.com/blog/2012/04/tpl-and-servers-pt4.html talks about the cost for TCS creations, and advocates re-using cached versions for Completed (and Cancelled) tasks as for 2) are you absolutely certain that no-when in the future you'll be null-ing a value in that dictionary for some reason, causing a failure here that no test will catch? Dispose calls should be as safe as possible, especially in a highly concurrent server env.

Ayende Rahien commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 17:31:04 GMT

Ken, 1) The cost of new object() is minimal. 2) No, the value is never null.

Ken Egozi commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 16:46:32 GMT

I really like the "making live services more debuggable" series you are running. a couple of things though: 1. why new CompletedTask all the time? since all CompletedTasks are essentially the same you could be able to have a CompletedTask.Instance or something of sorts, if you're doing that a lot. 2. are you 100% sure that keyValuePair.Value will never be null there? connections might leak in that (perhaps remote) case

Ayende Rahien commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 12:56:46 GMT

Chadbr, We are handling this.

chadbr commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 12:54:54 GMT

Wouldn't the application throw an exception if this runs when the app is closing down?

Moti commented on Why does RemoteDatabsaeChanges has DisposeAsync, and other pro dev tips

Thu, 02 Aug 2012 10:14:30 GMT

DDD - Debug Driven Design