Ayende @ Rahien

Wayne M commented on Reviewing Xenta and wishing I hadn’t

Thu, 17 May 2012 20:38:50 GMT

I can certainly believe this code. I see similar code every day at work that I sometimes forget it's 2012. No interfaces, 100% reliance on stored procedures for everything, no understanding of unit tests, a few gotos here and there, the argument that, and I quote, "Writing tests makes code take longer" as an argument against any sort of testing beyond poking around an app. It's real, believe me. And the people who write code like that probably have no idea why it's bad, no concept of evolution. Just churning out the same garbage all the time because "it works for me".

Bil Simser commented on Reviewing Xenta and wishing I hadn’t

Thu, 17 May 2012 00:40:59 GMT

You know people criticize you for giving *bad* reviews (or maybe non-constructive ones) on code bases. This one makes my eyes bleed. There is nothing good that can be said about it. I'm about to write a blog post explaining why coding to interfaces is good even if it does create "more code". I can't believe this is 2012.

Jon Rowett commented on Reviewing Xenta and wishing I hadn’t

Mon, 14 May 2012 09:01:57 GMT

unmaintainable code written in an obsolete architectural style, to be sure, and i sincerely hope i never have to work with this or anything like it (although i probably will).... BUT you guys shouldn't be mean to the developer responsible. comments like "now no-one will hire " are *completely* out of order. it's clearly a labour of love written by someone who enjoys coding. he just needs to get out of his intellectual vacuum.

Lucas Ontivero commented on Reviewing Xenta and wishing I hadn’t

Sun, 13 May 2012 15:15:46 GMT

The goto statements is not the worst part because it can be removed easily, the woprst part for me is the old idea of having WCF services behind web applications to 'improve' the security. It´s the evil for me.

DC commented on Reviewing Xenta and wishing I hadn’t

Sat, 12 May 2012 22:29:08 GMT

Seriously, no self reflection? 88 project, that should smell ....

Rick D commented on Reviewing Xenta and wishing I hadn’t

Sat, 12 May 2012 19:56:57 GMT

Oh, come on, it's a joke right? Right?!?

Alessandro Riolo commented on Reviewing Xenta and wishing I hadn’t

Fri, 11 May 2012 20:49:28 GMT

I shall own up, I must have coded in a very similar way to this the 1st time I started to deal with .Net, circa 2002. Probably even worst. I must say just reminding of Visual Studio .NET gives me goose bumps :) Perhaps the guy has only got 6 months experience with .Net, he'll probably learn how to code better in future, hopefully this review will speed him up ...

magellings commented on Reviewing Xenta and wishing I hadn’t

Fri, 11 May 2012 15:18:34 GMT

I think I just pulled my hair out...

firefly commented on Reviewing Xenta and wishing I hadn’t

Fri, 11 May 2012 04:15:02 GMT

This look like an April fool post :)

João P. Bragança commented on Reviewing Xenta and wishing I hadn’t

Fri, 11 May 2012 03:23:41 GMT

You'd think Ayende would've learned his lesson by now...

David commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 22:53:18 GMT

"what does it do" - http://demo.xenta.net/

Kim commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 19:19:57 GMT

if itlooks like shit it most likely is shit. I would not touch that code under any circumstances :)

Bjorn Coltof commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 18:24:13 GMT

@karep WCF has a behavior concept that allows you to do common stuff once and then apply it to all/lots of services

Karep commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 18:19:54 GMT

What do you mean by "you can do this in a behavior once, and since this is repeated for each and every one of the methods…" What behaviour?

Ali Hmer commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 15:37:18 GMT

The framework has no developers. Only contributors. No wonder. And now no one would hire dnovikov, http://www.codeplex.com/site/users/view/dnovikov. FYI, dnovikov is the sole contributor to the project.

Gene Hughson commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 15:29:43 GMT

You'd think with all the other plug-ins they'd provide an option for direct-connect to the back end. @Ollie, it looks like it's supposed to provide some common functionality around sales, etc. Not a good sign for a "framework" when there's zero documentation.

Ollie Riches commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 15:25:31 GMT

But what does it do? I can't understand from codeplex what this framework is for...

Ian Nelson commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 14:42:53 GMT

Wow. Just... wow.

Wayne M commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 12:41:46 GMT

Wow. Reminds me of my own codebase at work (which I did not write) that uses that wacky `bool Load` type stuff everywhere. I don't get it either. Is this VB6 all over again?

Khalid Abuhakmeh commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 11:05:47 GMT

I like on the codeplex site for the project it says: "Easy to use and customize" Probably, you just need to add another project followed by some goto statements. :P

Rippo commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 10:32:27 GMT

88 projects, really! Resharper is a must for this project. Don't think I have used a GOTO in C# ever, VBA now that's a different story

Rippo commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 10:32:27 GMT

88 projects, really! Resharper is a must for this project. Don't think I have used a GOTO in C# ever, VBA now that's a different story

configurator commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 10:15:25 GMT

Loops? We don't need no stinkin' loops! We have goto!

Yuriy commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:53:41 GMT

Goto's are probably only there to simplify decompilation in some cases :)

Bjorn Coltof commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:53:13 GMT

Wow, a goto that isn't the result of a decompiled optimized assembly... Cheer!!!

Thomas Levesque commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:51:00 GMT

Note to self: never ask Ayende to review your code if you want to keep a bit of self esteem ;-)

tobi commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:50:36 GMT

This really is about 2002. Funny how much best practices have evolved over the years. Today, this code is rightfully regarded as junk.

Matt commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:47:55 GMT

I think I've only ever used a goto once in anger, and that was many years ago for some numerical code in c. It gave a performance benefit that reduced the time to run a model by about 10%. I can't even remember the details now. gotos do have their place, but it's a very small niche and I doubt I'll ever use one again.

Yuriy commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:45:31 GMT

Pure boilerplate - maybe this is an output from some DSL?

Andrew Rimmer commented on Reviewing Xenta and wishing I hadn’t

Thu, 10 May 2012 09:34:14 GMT

Wow, I don't remember ever seeing a goto used in c#