Ayende @ Rahien

Refunds available at head office

Where is the bug?

This cost me two hours of debugging, do you see  why the test will always fail?

image

Comments

tobi
08/14/2010 09:42 AM by
tobi

Reflector tells me that you are not using nunit but xunit and that xunit does not do a reference comparison in Assert.Equals which I hat expected.

Second guess: you have to call SaveChanges.

[ICR]
08/14/2010 09:53 AM by
[ICR]

< should be <= ?

configurator
08/14/2010 12:45 PM by
configurator

My guess: You already have a value in the DB with a value about 1.331m?

Thomas Freudenberg
08/14/2010 12:56 PM by
Thomas Freudenberg

@configurator: the first line in the tests creates a fresh db

evereq
08/14/2010 03:08 PM by
evereq

I don't have 2 hours, sorry, but maybe something wrong with Range indexing for decimal values (i.e. in your Where (x=> x.M ...) )? Cast or something? As far as I remember Db create 2 indexes, maybe it use wrong one and you get not correct result? ;-)

Kristian Erbou
08/14/2010 06:48 PM by
Kristian Erbou

You set up your test using float and decimal. I remember from somewhere (maybe the first time I've actually put an MS certification into use) that float is stored as binary and should not be used in situations where you need to verify equality on large numbers.

fschwiet
08/15/2010 04:14 AM by
fschwiet

Needs more round trips to the server

Imran
08/15/2010 06:44 AM by
Imran

Either decimal will accurately represent 1.33 and so your 1.331 comparison will fail, or you need to use a tolerance value for comparison, like absolute value of val - 1.33 > 0.01?

Steve Py
08/16/2010 01:34 AM by
Steve Py

Hmm, there's nothing wrong with the comparison & data types, unless there's something odd with the unit test framework you're using. (I've verified the behaviour of the data type comparisons with NUnit.)

I don't know much about RavenDB but my guess would be that you haven't told it to retrieve the data, there is no Select or SelectFields, so would the Linq2Object .Where() condition have anything to search through?

Alwin
08/16/2010 01:42 AM by
Alwin

The session.Store() does nothing until the session ends. So session.Query() will never find anything because it is not stored yet.

Wrapping session.Store() in its own session, and 2x session.Quer() in another will pass the test.

Or does calling session.Query() flush first?

evereq
08/16/2010 08:38 AM by
evereq

@Alwin, @Thomas Freudenberg etc - I think its not necessary to call session.SaveChanges() due to usage of WaitForNonStaleResults, or?

My another attempt: maybe you forgot to do initialization (i.e. say documentStore.Initialize();) in NewDocumentStore() method that you forgot to show here as well :D

But still I feel that something wrong with Where(...) and decimal values like from my previous comment :)

Common, Ayende, let us know issue that you spend 2 hours :)

I assume that if you spend 2 hours debugging it, it's simply not so easy to found such bug in just few minutes that most of us have :D

Ayende Rahien
08/16/2010 08:50 AM by
Ayende Rahien

evereq,

Actually, the bug is that there is no SaveChanges, so stuff doesn't get to the server, and doesn't get saved.

The reason it took me so long to figure it out was that I simply didn't notice that SaveChanges was missing

evereq
08/16/2010 10:17 AM by
evereq

ha ha ha :D Nice that such things happens not only with me :D

P.S. I was think that WaitForNonStaleResults should actually do promote changes in context into database for given index... i.e. it's little bit confusing to wait for index to updated in storage with fact that you still have some documents in memory that not yet added to index......

Comments have been closed on this topic.