Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 5,953 | Comments: 44,410

filter by tags archive

A bug that drove me crazy!


I am ashamed to say how much time and effort (and at least one complete re-design) this bug has cost me.

Take a look at the following test, meant to show that Raven can replicate deletes between servers:

image

There is a very subtle bug in this code, which completely tripped me.

Here is a hint, the session interface is the high level client API for Raven.

Can you spot the bug?


Comments

Rafal

A session-level cache doesn't know that underlying data was deleted after it has been read for the first time?

Markus Zywitza

If loaded once successfully, the non-null object is cached by the session.

Benny Thomas

if (company == null) is the bug

if (company != null) is the correct thing you want to do.

Those thing are can drive one crazy

Steve Py

My guess would be along the lines of Rafal..

I don't know RavenDB but I'd guess there'd be a parameter available on Load() to ensure a clean hit to the document source. (I.e. NoCache)

Rob Ashton

Caching is the answer from my glance

Rob Ashton

But that's only because you hinted about it being about the session, I'd not have seen that - and I'm fairly sure I've done similar in NH before by accident!

Glenn

Yeah, I was thinking cache too.

Bernhard

I'd like to jump in and say that it appears your test is missing a pre-condition.

I think you should ensure "companies/1" exists in store1 and store2 before you delete it from store1, and poll store2 until timeout or it no longer exists.

I'm not aware of the specific syntax for RavenDB [yet] but I am surprised that there is no query you can use to see if "companies/1" exists other than to load the company.

I assume RavenDB will return null if the requested document is not found?

Benny Thomas

Damn, my answer came to fast, truly newbie...

Kristian Erbou

If there is a Flushmode enumeration in the Raven Client API (similar to NHibernate) my answer would be that Flushmode is set to Never on the sessions you get back from your session factory.

Mistertom

I think the session should be opened inside the for loop.

Dhananjay Goyani

+1 for Mistertom, Steve Py and Markus Zywitza. ;-)

kamil

What about transactions?

Bogdan Marian

I know that NHibernate session does not sync its content with the DB unless you either commit the transaction or call its Flush method. I do not know if a RavenDB session acts in a similar way, but if it does, I see no transaction commit or flush, so your company was not deleted yet ...

Diego Mijelshon

Two variations on what others said: if the session is like NH's, Load might never return null OR it might never go to the database twice for the same ID in the same session, so the session should be opened INSIDE the loop.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

No future posts left, oh my!

RECENT SERIES

  1. The RavenDB Comic Strip (3):
    28 May 2015 - Part III – High availability & sleeping soundly
  2. Special Offer (2):
    27 May 2015 - 29% discount for all our products
  3. RavenDB Sharding (3):
    22 May 2015 - Adding a new shard to an existing cluster, splitting the shard
  4. Challenge (45):
    28 Apr 2015 - What is the meaning of this change?
  5. Interview question (2):
    30 Mar 2015 - fix the index
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats